Re: This reply comments on the patch to fixes the missing a blank line warning

[Adithya Chandrakasan <adithya.chandrakasan@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]

On 2/11/21 2:36 AM, David Hildenbrand wrote:
> ^
>
> Please create proper patch subjects. Nobody has a glue what you are doing when looking at the subject.
>
> "mm/util: fix ??? warning"
>
> Which raises the question, what is ???
>
> Compiler? static code checker? ... ?
>
>
> Thanks
>
> On 11.02.21 08:29, Adithya Chandrakasan wrote:
>> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations
>>
>> Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com>
>> ---
>>   mm/util.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/mm/util.c b/mm/util.c
>> index 8c9b7d1e7c49..60286876636d 100644
>> --- a/mm/util.c
>> +++ b/mm/util.c
>> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen)
>>       unsigned int len;
>>       struct mm_struct *mm = get_task_mm(task);
>>       unsigned long arg_start, arg_end, env_start, env_end;
>> +
>>       if (!mm)
>>           goto out;
>>       if (!mm->arg_end)
>>
>
>
Hi David,

Thanks for feedback. I have fixed the issues in the patch thread with
change in subject and also log message.

with regards,
Adithya Chandrakasan


[-- Attachment #2: [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix.eml --]
[-- Type: message/rfc822, Size: 1660 bytes --]

From: Adithya Chandrakasan <adithya.chandrakasan@gmail.com>
To: akpm@linux-foundation.org
Cc: Adithya Chandrakasan <adithya.chandrakasan@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix
Date: Thu, 11 Feb 2021 09:59:14 -0800
Message-ID: <0c1ce6d55fb011f29b2c22134f59829402eba175.1613066176.git.adithya.chandrakasan@gmail.com>

FILE: mm/util.c:930:
checkpatch.pl scripts basic coding style issues as below
WARNING: Missing a blank line after declarations

Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com>
---
 mm/util.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/util.c b/mm/util.c
index 8c9b7d1e7c49..60286876636d 100644
--- a/mm/util.c
+++ b/mm/util.c
@@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen)
 	unsigned int len;
 	struct mm_struct *mm = get_task_mm(task);
 	unsigned long arg_start, arg_end, env_start, env_end;
+
 	if (!mm)
 		goto out;
 	if (!mm->arg_end)
-- 
2.25.1