From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70FABC25B47 for ; Fri, 27 Oct 2023 17:33:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C597C6B03D7; Fri, 27 Oct 2023 13:33:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C099C6B03D8; Fri, 27 Oct 2023 13:33:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD1136B03D9; Fri, 27 Oct 2023 13:33:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9B8F16B03D7 for ; Fri, 27 Oct 2023 13:33:04 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 62B1712045D for ; Fri, 27 Oct 2023 17:33:04 +0000 (UTC) X-FDA: 81391937088.28.4824178 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 8E1A41C000F for ; Fri, 27 Oct 2023 17:33:01 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PBpOnDtD; spf=pass (imf20.hostedemail.com: domain of mpatocka@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mpatocka@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698427981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YFCOmqCYSKmzzXjFht9+x7s+AJE8sjtnXGepXVqi1hs=; b=fvj/DJ2QKwrZgb1V9WIOZRR7dtGM/mlFUuLiFOwHZguX5vLamgQDTVolsFOdjqNdwFpmCE 1Kt9TqLhnVq0MARFQ/+hzVcaohJ8KkhAK+c28ONns3MALv2a4xDLuPqCjp9n7sjBFCFAaW 2kCJkL0c8R5MwpKUXHL41DtwX3mz6Ag= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698427981; a=rsa-sha256; cv=none; b=ffO/eP3ckqLADYAJ/+odGBeg9aUhRB2al1Q2TsN5d84Dxbyp2fTUuNe/0WepjCvNCR0GOS 2CVHsGbGxFKIfh+CKtqbRAKyhmLQL8O9p2vY0iYOq9kg4BJBFXOrncWSIe1BDRLWouyas5 O4Hb/fR1T70DTofb4Lzkl5JoX/agx/A= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PBpOnDtD; spf=pass (imf20.hostedemail.com: domain of mpatocka@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mpatocka@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698427980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YFCOmqCYSKmzzXjFht9+x7s+AJE8sjtnXGepXVqi1hs=; b=PBpOnDtDnyhdmXjJHBSJumPzQSXyvn0InnaMfS/TZCGuByiAY6XNiMyLS762ZQUmzuTofv r4WtRofSZevXVyy7U1IwOWBncLJyrlq2UywXBpCnDuSc7II1x3rSPCN4bNeKQBuZPLoD30 EgWWlyg2Jjrq8xrBkuJudEOGq0kwAfo= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-pYVAydJXO6S_qPgr9wWeVg-1; Fri, 27 Oct 2023 13:32:55 -0400 X-MC-Unique: pYVAydJXO6S_qPgr9wWeVg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6940D3816B40; Fri, 27 Oct 2023 17:32:54 +0000 (UTC) Received: from file1-rdu.file-001.prod.rdu2.dc.redhat.com (unknown [10.11.5.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 490385027; Fri, 27 Oct 2023 17:32:54 +0000 (UTC) Received: by file1-rdu.file-001.prod.rdu2.dc.redhat.com (Postfix, from userid 12668) id 338D030C72A4; Fri, 27 Oct 2023 17:32:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by file1-rdu.file-001.prod.rdu2.dc.redhat.com (Postfix) with ESMTP id 293C93FD16; Fri, 27 Oct 2023 19:32:54 +0200 (CEST) Date: Fri, 27 Oct 2023 19:32:54 +0200 (CEST) From: Mikulas Patocka To: Mike Snitzer , =?ISO-8859-15?Q?Marek_Marczykowski-G=F3recki?= cc: stable@vger.kernel.org, regressions@lists.linux.dev, Alasdair Kergon , dm-devel@lists.linux.dev, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Michal Hocko , Vlastimil Babka Subject: Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5 In-Reply-To: Message-ID: <34f6678e-6460-f77-73f4-fc8d3652a8e5@redhat.com> References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="185210117-1463778712-1698427974=:495964" X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Stat-Signature: xx67gknrprafuhhg7oec6dqbs1b9c37f X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8E1A41C000F X-Rspam-User: X-HE-Tag: 1698427981-822135 X-HE-Meta: U2FsdGVkX18VjFlwF6v/VE6ToYRNwkfiBymyNs1qWmphmYZEs6DyzVQ/efo7/C0IY3xt7Q7n3QTkyJLU4bL62FmrDG2UODdSXrQ653iv5mBa9ILCRKqkp/CsmyfBjTLA8P5zM1h1lldI9MUgZG2PEE7Za/sFZ+JjFRIkvBvCqomzT5n48fakKeT0h8lSEkvBO7l/bzIAYnzdG9POIJWiDJwrR4Fs/UOlECI4m20UH/Nx8/FqSK3IaJuKcJy59vcAL+fC4SEymzkhejme853TWEU6Q6nj8fRb0LIZ0CpM2AgK7m4oel3cKASnMHk1C2ljdNVSSuQeUJT1Q8hzwZVJZyM0CJW7aDFEsj4UF9qPjrC1I6wo8fV0xwM4PuaHI1yxfIlbgvrl8v1bNtK642wRMfQY49fm9z26w6tIBFHpSvgT/LyB9IdW7GgQmp0doV61OhMnxmjfbiqULRHZjedNiu5fFH2wOxNRwtGNagMFOhoYjcy+vRESoH6t1lXKUNYvoLE/na6X1oTyreTn5l5KvIzqIviNoZB7+FlhAGGFVoeDZNtaeOsafT1umUJ/aHG0/CTtwAtvZp/TwS7xZ5ObQZtyTLRmdJ4fqRAY1Qksuavb8WU3MaBtVIVEvhDDArmyT+wl2ty1fFwlHRDDt0xbna/Ico7EQg2cx7teuOhzA+MHBpT/GdfRG2W402Yohx9ooGXfatt0aEAMWXLEOInwn2nWuXmtYzjg2gZ01NBYQy8W9LUN9clkqXeJeYL4+64qzAmnBr+F8hJzFb3UrSSAzo4uLEecsWYtmrjmrnRFoAOUzCknsZIpaWcdwmG5ZmdTXB6fEU0hWJO3aEfaiYz/LGbzCFhpbrRM3muRz3xPuvPkZH06D3SXmOzNVDt7HS9ly8kucLE8zRY4tfq7PD4+8kA2uRXPie0n9oqepdDf3FFLSizePhBpin/DobtRFz5qtLwd54+RHS3MXW+Ua9M Fdp8pgiL iztZk/THyDHz7geSlpexnubVf+BIM57rp+/atTgJ4e5PaGw2c8YP4LJt2kQy+8Q5K4zbLO+jgeMRwcVzLXl8IcekmGwv/AkmUD/BIYTQlWP+/zGq+PtqIzxYVjraI4/PYHgCVZYTxOfOSPmUAJVazAdTk6dwLoHYsVEnJ/LBODurKRup8LWuZMkbjbC2upvOrUGCihQu39GGgFnM5Js2IUwmN3EtLYtZXiyMK7iM91rZqxk80MHIM7jVJEvzgbfFCKXvrFrX3DxTgHYQbZMqfomp06D1fRlj9tqLlA5ckrpZVJvX8N4aBpt/FrszLL6yIgZz3ydXXNNIfi7tyG1HIpfbIm0nhgBZVXoPsydv0DRSSDb/jNddNiKWhYKj8XAIT4zlT6fkXp/CpjhbwP99vWWo41Kd5SLdiM48VbbvMTC5H5wFj+tBB9IaTbqEXp2DjDivDZBvLEHCCibrZlVVsGJbuAoDscWyJMz8uGgqwsjyibY7Vexmd7X1hHqyMI1q3lanhnWl9ZoRlo4DXQ0z5vAI2kw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --185210117-1463778712-1698427974=:495964 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT So, we got no reponse from the MM maintainers. Marek - please try this patch on all the machines where you hit the bug and if you still hit the bug with this patch, report it. Mikulas From: Mikulas Patocka Subject: [PATCH] dm-crypt: don't allocate large compound pages It was reported that the patch 5054e778fcd9cd29ddaa8109077cd235527e4f94 ("dm crypt: allocate compound pages if possible") causes intermittent freezes [1]. So far, it is not clear what is the root cause. It was reported that with the allocation order 3 or lower it works [1], so we restrict the order to 3 (that is PAGE_ALLOC_COSTLY_ORDER). [1] https://www.spinics.net/lists/dm-devel/msg56048.html Signed-off-by: Mikulas Patocka Reported-by: Marek Marczykowski-Górecki Tested-by: Marek Marczykowski-Górecki Cc: stable@vger.kernel.org # v6.5+ Fixes: 5054e778fcd9 ("dm crypt: allocate compound pages if possible") --- drivers/md/dm-crypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/drivers/md/dm-crypt.c =================================================================== --- linux-2.6.orig/drivers/md/dm-crypt.c +++ linux-2.6/drivers/md/dm-crypt.c @@ -1679,7 +1679,7 @@ static struct bio *crypt_alloc_buffer(st unsigned int nr_iovecs = (size + PAGE_SIZE - 1) >> PAGE_SHIFT; gfp_t gfp_mask = GFP_NOWAIT | __GFP_HIGHMEM; unsigned int remaining_size; - unsigned int order = MAX_ORDER - 1; + unsigned int order = PAGE_ALLOC_COSTLY_ORDER; retry: if (unlikely(gfp_mask & __GFP_DIRECT_RECLAIM)) --185210117-1463778712-1698427974=:495964--