From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00586CD4F21 for ; Wed, 4 Sep 2024 18:41:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E0836B014C; Wed, 4 Sep 2024 14:41:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 767E16B0355; Wed, 4 Sep 2024 14:41:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58FE46B0146; Wed, 4 Sep 2024 14:41:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 337C26B013E for ; Wed, 4 Sep 2024 14:41:36 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A6A6A1403B5 for ; Wed, 4 Sep 2024 18:41:35 +0000 (UTC) X-FDA: 82527924150.16.7CFB6FC Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf10.hostedemail.com (Postfix) with ESMTP id 242C8C000B for ; Wed, 4 Sep 2024 18:41:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iSFbInw3; spf=pass (imf10.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725475244; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AH+WLoXHA2DlYnqCw15SB7/9MwZ3oRAv3Bk4lKI0sEQ=; b=q3SaWQLOQKbQMp3ek3+AW5vMW3MpBGNHXHCnUynAQBNmw74+dcTwh6p9QneKgyT6vf3iri 1k0nKPp0tfK9DSat8S5Gx3/G9xwYv9HCenyqJ/fLHeY14jGF/Bxdi6Jqac7ytf0hX76xnG isHpyx69wj3xTYly+y59Ih56ifGJlJg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iSFbInw3; spf=pass (imf10.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725475244; a=rsa-sha256; cv=none; b=ASpuSQbWTPO82x1597AFPbIAGQtbzAkzA0RB4YewUryoIl87ADi2LbFB8qx/Zg+1edMzmt ll1Pjx49zPfgXgisLe2oY8gu+Lb0VP/l/DB4nbxcx74oJkT1OZM/5OTdhFjK58RD92fh5+ VprZrlUqfo7vvkAmP9FbZT3oEYEd7xQ= Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7142a30e3bdso938648b3a.0 for ; Wed, 04 Sep 2024 11:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725475291; x=1726080091; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=AH+WLoXHA2DlYnqCw15SB7/9MwZ3oRAv3Bk4lKI0sEQ=; b=iSFbInw3QAImo8tosPRAB95cj4uLtZmotf1hey7u5kpDFwIBXK3kThnu08/oURJU/M LoCcuNBNwVaS2Hk+DRTkrQjAfxtil3Mk/NRokzin4yILjmX2+PnSO+5VrskX4DGCZuPS oa2EFUxDxuuhK/TUgvV9sbjJUSS9exvzxREEz3mg/CHoP67HZZ7XW7yEXUhH8HYS0osi ujWWUz6V+32xlAvKFIympW5w6NKYuWKatpukAIUKlqhP1l6gs8XtI7ML11DwNsonnmln xH45IuCZE7wZgQ8lGhaC5CDqlqZI2P8lIKXu18ssK8Y3BuE4mpt03yDwJ9z3N4mAE6Iw IPdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725475291; x=1726080091; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AH+WLoXHA2DlYnqCw15SB7/9MwZ3oRAv3Bk4lKI0sEQ=; b=s4kihAdnr3HG7oE8MQgGI8DhOG+jua10f351O9IrbLT/ase0iEPH7SDb1vTdQb3XQp +PzV4gRCo2TJx0dHKMbGcB8Ih535pGGMwTnGhLtqGV8sEAMONZ0YRG5lQrPMVSJc4UaJ gW2aU+fnZx3cd96N6Q3MzW5xwnJGXF6uX5NNXZcLLMJ7BoB/zk9S6ty1TSgrisJ4XvMD BUO7iYCYWsz3ahEyHk//fxGHzFuBkOAmebUIBR9KK/a3cgw/sraGA5Tg6ZTVKknAhVTW M33+9Rchb2bWhCId2+kzV/2o5KLtfyXzNkMdNyvBN+X+K0HT1mPPwRuKH1DfMso128QE W/qA== X-Forwarded-Encrypted: i=1; AJvYcCX9mMDn0T1DzDDTtK+RaihtZLWqO3pj1jHkl8AhsIfTPox68LISZp2JBK1pNgkkXdYqgJ3qhAN1eA==@kvack.org X-Gm-Message-State: AOJu0Yy+EDoSFa6kg4BnLB4CvQ43ghcJ1fJZR++SkgyENMADhvIZCM2S cAv1vN05eXZvp8MzFHVYr3aE/RvWhVkY+VWjw+KVsbbu7RRvThSwUlxSaQ== X-Google-Smtp-Source: AGHT+IHC8jK1yXwpDeEL1py+eCkq4NADqbKnhe0Q1HYDr33PYqUrlmaKJ12/vwdFBcnYjdOYudZhIA== X-Received: by 2002:a05:6a21:10f:b0:1cf:1228:c175 with SMTP id adf61e73a8af0-1cf1228c29dmr764911637.8.1725475290475; Wed, 04 Sep 2024 11:41:30 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71778522931sm1936293b3a.4.2024.09.04.11.41.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 11:41:30 -0700 (PDT) Message-ID: <34f3e9bd-9323-43cc-8371-00d8847d8664@roeck-us.net> Date: Wed, 4 Sep 2024 11:41:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/damon/tests/vaddr-kunit: init maple tree without MT_FLAGS_LOCK_EXTERN To: SeongJae Park , Andrew Morton Cc: "Liam R. Howlett" , David Hildenbrand , "Matthew Wilcox (Oracle)" , Brendan Higgins , David Gow , damon@lists.linux.dev, linux-mm@kvack.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240904172931.1284-1-sj@kernel.org> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20240904172931.1284-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 242C8C000B X-Stat-Signature: 3hmac747djn47o1y7t6u4ka9q7sxx6kb X-HE-Tag: 1725475291-374410 X-HE-Meta: U2FsdGVkX19Rw/vaJWNdcjD+CIGrKGK7geU/CvkYrR1GFAJIUUV5zhQK3G86j87BD+xuqmNm89EQo8pleSYs8f6TYXUJlwQuMnNQ1ttl8ubXtM2xUM5Tn9qt+ee3TMeuVr5GlfpNsKaqiZufULWJhAJo2ZlGZtjPW5VSuRQ46RZC/o4xa06tti+Z4GENAv0X/IuskZvfMsJu2KARUsxY1VrPs3QmP6G/0bhEA9jsXS762c7+xDiYlpUCCxJlHT2R42RWZww+qYF5f6/9L5xSokfN2/ggA9hStY8xlxoVFcFGSdP8dimnY++z68JLMjwKEIPPP9KufiLCfBkItY2oE6JjYYdSnYb8zw+MkXzWHWeHq4W5KoPTPu4nzAqopqgwCDWaS8A+y1hj0QCJUbMbjaJuyIHJXVb49WU5GwesNwIrYr2pCT4uNk8fosB1GyRMF81BDgnToE2FMvQfuoQ7eL0TnbLjdbuUWhRXEPnB/Ev4MUgCfWswm6fbZpZTP0hGtg/fAh5IxxrzpXj94WNMaYtxk7Um/cwSwTjQYJHWoF4ptZUAbCxailPg9PKGn6s+Rx9PEy7ZFNnq9HL0mKcLn9UIEUQQFyzaMGHu8IerHbtVT0DLgvHdsD8i0Ns4ifmtd7D4UjUEvxg3hbPGCxfgFhXDwsz2sqXbLaF5puZKNnxP9wBn4RY8liuzwzrqnGeJcUtd3XVd3hDc0q7U6ydwKzESwH3jR5Zjud3gYlKg+AQ2ucM1baYCSkbDQ1o7Mdpwk7H8GmTQBeagSdiK6zhWRR4ra7tBXj1W88XgPM22Ju1YRGGszzbydPd3F/EX1bdHCGUEj1p17InK8oleVrlUoW7CkJQp/miqZ6mJR9RWg5EdDNXqmHYdX6nTSl7BBMTEfo3OHwDWR6iOotupbWD/Tdtqe3TajRNAQqEt8+EgGXyi8r56cNAgQ8rhXya81E7Zv2rV9g/8rbw94+GZJWN nHpDXel/ 2u32AR+jLkhoy1DR0Hi+QH8en4RSSexQd2enmxvBPQd4b+H726PiUvxBvBmCPNa3Lf7Em1Z7RnlYD9bMyPVApCnMil/xBy1/XTWiOoK+n0Ez0P94QNfNw9UyJrTDiBK3ri0nI4M/GVJ0UKK3jfmbM3tIyFaL4bNNxk5nRjrEyUJSR01gzn6V5Z7b+3FLb5JKgNyJ4K/4EBDvoHI24SWaoxBPJMauJmCbD+20s/ihnAxJvDr0N8DDWcy9TWPQNss8paHRghdEnC9Q3Y3NlLiRlA3AaW+YEJBKJYIDuCX1VKpiIn4tbZEU+/zT/CO6/Q/va683tYa0SMcHfIKOTly/JuCjEL6x6s4cySQjPpSxy7Qjl22xJ6wBgMeyALFXBs+11a2Z2VJP9D2CKmPISpNqg6itMHWK0CCY06nnHAkkck/fL5/jtfKnPyKFAmqnCF3haTt1X3PV1BpYgq/Ig0da75UeXlJdpjVR/Uy/tQqY10Gj9gcJrUa7qxCWp/3mcEcUPba6E2KTZDZNRI/FwNed13V620T4b8v/YqNUU2V3Wh8YZgkk0Biz5uyBVXbh+YnBQbZYxI+E+ttWtGytfqqENnRPezox7A78FdWFIDZRILnSdZwZz/mqSEwKkOaIXcObnQtb4fQc3IYjmgw0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/4/24 10:29, SeongJae Park wrote: > damon_test_three_regions_in_vmas() initializes a maple tree with > MM_MT_FLAGS. The flags contains MT_FLAGS_LOCK_EXTERN, which means > mt_lock of the maple tree will not be used. And therefore the maple > tree initialization code skips initialization of the mt_lock. However, > __link_vmas(), which adds vmas for test to the maple tree, uses the > mt_lock. In other words, the uninitialized spinlock is used. The > problem becomes clear when spinlock debugging is turned on, since it > reports spinlock bad magic bug. > > Fix the issue by excluding MT_FLAGS_LOCK_EXTERN from the maple tree > initialization flags. Note that we don't use empty flags to make it > further similar to the usage of mm maple tree, and to be prepared for > possible future changes, as suggested by Liam. > > Reported-by: Guenter Roeck > Closes: https://lore.kernel.org/1453b2b2-6119-4082-ad9e-f3c5239bf87e@roeck-us.net > Fixes: d0cf3dd47f0d ("damon: convert __damon_va_three_regions to use the VMA iterator") > Suggested-by: Liam R. Howlett > Signed-off-by: SeongJae Park > --- > Changes from v1 > (https://lore.kernel.org/20240904004534.1189-1-sj@kernel.org) > - Keep lock usage and update the initialization flags (Liam) Not sure I understand how this is better. Is the resulting rcu warning considered to be irrelevant or a separate problem ? Thanks, Guenter > - Fix a typo: s/celar/clear/ (Guenter) > > mm/damon/tests/vaddr-kunit.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h > index 83626483f82b..a339d117150f 100644 > --- a/mm/damon/tests/vaddr-kunit.h > +++ b/mm/damon/tests/vaddr-kunit.h > @@ -77,7 +77,7 @@ static void damon_test_three_regions_in_vmas(struct kunit *test) > (struct vm_area_struct) {.vm_start = 307, .vm_end = 330}, > }; > > - mt_init_flags(&mm.mm_mt, MM_MT_FLAGS); > + mt_init_flags(&mm.mm_mt, MT_FLAGS_ALLOC_RANGE | MT_FLAGS_USE_RCU); > if (__link_vmas(&mm.mm_mt, vmas, ARRAY_SIZE(vmas))) > kunit_skip(test, "Failed to create VMA tree"); >