From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1071FC7EE23 for ; Thu, 8 Jun 2023 07:38:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 186886B0072; Thu, 8 Jun 2023 03:38:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1365F6B0074; Thu, 8 Jun 2023 03:38:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02499900002; Thu, 8 Jun 2023 03:38:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E6FAF6B0072 for ; Thu, 8 Jun 2023 03:38:54 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B5B19A016F for ; Thu, 8 Jun 2023 07:38:54 +0000 (UTC) X-FDA: 80878778988.26.46E1CC5 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf23.hostedemail.com (Postfix) with ESMTP id C2078140006 for ; Thu, 8 Jun 2023 07:38:52 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=IFqs2V6j; spf=pass (imf23.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686209932; a=rsa-sha256; cv=none; b=jTGqoIMJxqvDk2g4XXHk+xlgDSbWbZRuRq5HCXXIjjJROKi/GSkTJyf39/JPz7/616cJEd qdSYsBJFSGAWVTj4d2LS8uuhLEYRlRRI+FWabPlysOb6uOK7yaUiVyobztcsGzCqFMVWAj frR6xQUhgSPOttSlVaLZyluZrAB5Cnc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=IFqs2V6j; spf=pass (imf23.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686209932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t4c10xINaZk3zkvGR2qh4gks80MlmOsa3Cftwgec9Mk=; b=JuHixf0pj1eAX8fv9ul+bpUGHet/K7KrtYGBNP1pJCfc2fiTs2ci2N1RXjs/8LkhtbLOA6 BtCbUuPPVgbfYLes5SlCcyUF4d/yipvdJyWLeZBeziwyxejqkivrUzZ6uVVrPlDBvlWQcW fa9lSBoS+BTUZOPKcXo1tU9zDM263hI= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1b05e96dabbso981325ad.2 for ; Thu, 08 Jun 2023 00:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1686209931; x=1688801931; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=t4c10xINaZk3zkvGR2qh4gks80MlmOsa3Cftwgec9Mk=; b=IFqs2V6jVzqst1fg75pvcNNdwOM+CQLePTiaSPr9y7U+i518QlsGxYBHaONZtdhwql IAmzimfKOucyw42Kq6aoWhWEeBmvPPKneMrVxIo3go2Sl/Y+MjrkndQ2Ryb/PurF3u+r XRzkM+A+PtEbEX2XtZI9Hj+fWFzEc6kzEmgBYdC3YcmI2wFZ+NKUpZL15ZgFW+NUfVRb kgVJml+/pOZoGB+NwdsrFQwk5cdnpVVykbV3ZnbhsnSVFKAijlgcHf0/ll+5fIhj5l70 l3WQQ8eEUn4qznYg8NanhirB4Xx51epDwFoi7yYYwvhzxiHEUSB046VlAxaxRDI9qGqP b8BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686209931; x=1688801931; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=t4c10xINaZk3zkvGR2qh4gks80MlmOsa3Cftwgec9Mk=; b=APKESzzR1BkLNH7L3hboMajHf1VNvHv6j3QzPsxkxJGOR4YWeu2g3XHWTpHJ0st6oj L1s8jPcwfnPD+Pl9KbHwaJabHrQik9jdabOcJUgV+si+QWP0w9G3YCcaZiCix5LUB8wF Ajfo5sAB4n7cia/AY50gY5lCyQRV/8RSSjustHrAA+/CTXzQVlQ7j3Ktn/cov0yI8NVc YdkrzNYpYTiSJQONSE10/7kKMcy73T7Ws+7LTzCKHZgsO/a0BrQvgnTAoFS7J1UUSjTN r5RXA59XixaTBeF1wohq/G6OShEG83T4Y2hDDSWIz3132qgUQgoaOelYSV1FdyJq9rFp bbeQ== X-Gm-Message-State: AC+VfDzBfL6VD0zWN3n/ryKotQDph84czMrPwReTZkYCgc77u4xFMTwE RJppnsrZOQrugem6W2I3juRXtw== X-Google-Smtp-Source: ACHHUZ4eZ2clfiTJ4i6Erls5cwly7HgZSvTWAjOgDhPPs+vxBT8O5brwPV1eHfWs4gxpNV+tHA/kcQ== X-Received: by 2002:a17:903:11d1:b0:1b2:49f6:6cdb with SMTP id q17-20020a17090311d100b001b249f66cdbmr4051465plh.37.1686209931239; Thu, 08 Jun 2023 00:38:51 -0700 (PDT) Received: from [10.54.24.10] (static-ip-148-99-134-202.rev.dyxnet.com. [202.134.99.148]) by smtp.gmail.com with ESMTPSA id x15-20020a170902ec8f00b001b176ba9f17sm749831plg.149.2023.06.08.00.38.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 00:38:50 -0700 (PDT) Message-ID: <34f32148-24c3-09a3-8bec-9515139e15b1@shopee.com> Date: Thu, 8 Jun 2023 15:38:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] mm/mm_init.c: add debug messsge for dma zone To: David Hildenbrand , Michal Hocko Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230607090734.1259-1-haifeng.xu@shopee.com> From: Haifeng Xu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C2078140006 X-Stat-Signature: m9e67baujtkxwaehpexhp199h74o85qm X-Rspam-User: X-HE-Tag: 1686209932-709076 X-HE-Meta: U2FsdGVkX18wuW6d65cWaKAEtaoQnDFJzZXX+TkcQkrKGlsWEHkfwF21AzNaOPu9315qpF/dCteA3zdFeRmcpRh/a6Ur0KjL/wJf6BHaWWGy7D1Y9FzxRdupagXH8MNH9TF2lyok7ayxR4BZUmPL6qbouqvDEDQJ3rEovY3lQIXbcgS7TYZy1uhqu3camGrMDF9eCQGtO7MRrgr3PO9GrVre3u2A5jCU1K47Ae+obQuhbKXrZuiwenEDLPJYi0vQcd8lL3JeRoWKtlSBQ4L07d6lOeTSdwf5yFQ1cpq93B4YSGBCh/omZGD2rtsS3OI1Z9+48FiKYmofx3VSRbZS+4c+VngJtpOD61aLz0DAQy4W/vt27wVaNmUSk6mLpLKdLv9pbtGmGpYISlaWfegADFFANgErGeW8Rek7sSjjl0wUgPq+Cf5MXBm2e5epyiPgWFF5gFfr4sBor6Rf5ECe36+wtkCyi9K91Il+3KEnIVHO5awzIKUCVjyiAMaP7AqdGUf6K9zwbbNlCvda7uilRsxURkEcvahVNgp5mzza+GiGT1dwaXNgRfHGEj1hluDe1IoDMKzEj8q+Tp+SHsZOzQeOYKVAkr6jlwOw/xCTyg64FoqBK7x322uYKPTtdl8wYZWI7X9sMEmcAM0+Q+eBjtG3n+sHgF3+Cet/aR5SqRiqxCd9qmNO3JFT8AvXJDfG+vwT+bHjDIcr0ff+HdI5ZAPtjEw/5BWbJj9AdSdl3TGIJ1me1kW+rJlYf4KfD+uzC9u25xjO7Ftnran1Zv24T0MAPUr0frhO7kiURRencvnnu6Xu6StTcM7UoH2ahvCV+375TQbvz9HNS6o8elenqvXNMzCEuLN0T1y/ncM2YsPizJLnSz4uWpQv6yLDbS/nTvfShpMN2EwV7vk48CBAFvQ2mgrUrAoqhY4tNIZphrF8Dbnj9dyBnSc/M+pXtbFAGjgxirqlFfBj6lk8vj6 /S4mnOyE A6jYGGDH6xOt9apCKOnHJl3x0zg+fQBQ3xzJsbgsMHerh/f3PCTByw4cMyRJz+UrryfB8/lBUUtQUW2hF2job2mrLSprUqwO8/znujBBr72omKUgBzsw+NBjQVjy8jvr5xSGktiu10yXapNAL23ZA83KqKn4Fgw3PjAsNQqgr9TDRrxJounT/ceozNczCHw4aUtM45/HPHG48qFhWGiW++G5Dp1Tin61s9F5zDdzCEX0nx6pvM8kGKw+xy2xQPXKqrsuPyCJY2CfZCRWKAuIcK0HDRQD0zhjwem2J9s3gCd0aRkPs42O0KUPPA4vYsOcwY8IVFOIThMS1RCcmdQvACp8ADnfypDwrG5DP9UhntZqyWa9dwAIs6Ev6HGcy+A9O/olDMjjhf7B+FLRrZX2ONL4OdYW3KnknymIFZXBNllwasHI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/7 18:22, David Hildenbrand wrote: > On 07.06.23 12:16, Michal Hocko wrote: >> On Wed 07-06-23 09:07:34, Haifeng Xu wrote: >>> If freesize is less than dma_reserve, print warning message to report >>> this case. >> >> Why? > > I'd like to second that question, and add > > a) Did you run into that scenario? > b) What can an admin do in that case with that error messages? In theory，dma_reserve shouldn't exceed freesize, so the error messages can remind us to verify whether the configuration of reserved memory is correct. > > If it reveals a buggy situation, maybe a WARN_ON_ONCE() is warranted ... but maybe only if anybody actually ran into that issue. >