From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 411BDC3ABB6 for ; Wed, 7 May 2025 03:44:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A69BB6B000A; Tue, 6 May 2025 23:44:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1A126B0083; Tue, 6 May 2025 23:44:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E04C6B0085; Tue, 6 May 2025 23:44:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6B4A96B000A for ; Tue, 6 May 2025 23:44:08 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E13781CFA57 for ; Wed, 7 May 2025 03:44:08 +0000 (UTC) X-FDA: 83414718576.14.50D4A6F Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf11.hostedemail.com (Postfix) with ESMTP id CDF1640002 for ; Wed, 7 May 2025 03:44:06 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf11.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746589447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KttPLZtvErYHYmVUD9cnVn2jizXhiM//JArNluP7ZqM=; b=VHPNbyArtDGmP6Q2Nq2uKzhx2XlVYjbuLjFQyoe7wu7hjHdow0g7elEmqzh3TuFMZ87Gnz 0cgbSiL9ZAaN3/wBlwHMqNnQaXhGspngixbTU5r2DcGC7YJYs+Wa74pi1tEpeR5hwWeQO5 N8V3z+bqDao71Zx1fFjezW7QTJfLRL4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf11.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746589447; a=rsa-sha256; cv=none; b=Tu9qKo8xleXwdnNVL+xM5TsrlSsGhP/yCNTgVmZlRprkPukgz5aGC3KQ9xHG00Lz8rqwNp +rzAI+vFFgQynxDz+kRbBC+/Smfxi8Rc6538jxiC6LQe3+CiozkmgelZGyDLt0jPO9Obn5 mijsTAAId5p9jsHYXOgHb6gQJo6Q3SE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 87B732F; Tue, 6 May 2025 20:43:55 -0700 (PDT) Received: from [10.162.43.22] (unknown [10.162.43.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 229DB3F673; Tue, 6 May 2025 20:43:58 -0700 (PDT) Message-ID: <34ed0b92-ee75-4d2a-8aa7-6ede9287c740@arm.com> Date: Wed, 7 May 2025 09:13:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm: Add generic helper to hint a large folio To: Matthew Wilcox Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, baohua@kernel.org, anshuman.khandual@arm.com, ioworker0@gmail.com, yang@os.amperecomputing.com References: <20250506050056.59250-1-dev.jain@arm.com> <20250506050056.59250-3-dev.jain@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CDF1640002 X-Stat-Signature: 5tec6onguktafe9aufwbomc4f77ixcfe X-HE-Tag: 1746589446-647234 X-HE-Meta: U2FsdGVkX18ZzEj09POKiMC4T4Pt1kS6BBnsAi8uAZe7GGFEzi3crUlvxlvXr+3xUBiw/5wLFLaNFqzqoQbgvqCFiN7TDcPvTsLbIbP75kAMLM/xKhOfSS1V8Mr8JhlR8yDQFJsfOFJWhRqm//tsW4p/sZOXJJQGzp6y7aczsrYcKftAKMha8rDo+HQNWZHqLer4Ie7CE3HIsc/4WJ84KRKXR9rT0LY7WuHN292nQLijUWmXSGywrwNabWDEPF7mMu7XyFWxkFaUojFvdB3lAClmsYIG6cNKy7j/gfCFT753Ycl85cpvHf7/AYn9vaL74u+iDxaceo5K2nYQt4QZjStQOglJ19bsU3HQiw1sQ1WLoqOLZp4S6/j1qSjrts0/HMO0CIyw0Q9wNA5FBpItZI3RNfuUQVa2wtFAzit0V1vK/4jY3XHrVhdf+wmzwy2R6yw1m/6alyPkPzgVpkPyn0fjMbPjpSNj9yBONaWTBZznWBlOjVgiuMtP05RUgmoxtRCrfsbWN7Fk2YZA9uIWtNTKwwHNf36w2TIea+Ow1VP+2iZudbN89O5puaQvUwK8WWvz7eJcYLoI5CF8UMDUF3H4oQRyQT1lN37ilfq97LYd9OKJeGCFa0T3i+7aOEUIi1XHqVSI6RPO7irZxOFmk+qey7Hrc1wikBBilWldBl6ILmDzqBLMGOZUkdIYysHP3+ng9tv4WnCW/qWiQgk0yz/fAFapOADaWG5ZTmS2vPvsntbcRvFadfZIgajSbGB55w0qTy6gpJrAp5qONxLg49Rzpx8X0QS28oqCK3/njEXTZ0DUqPiOXAtQFy/0kwqA2popnEck5LfxQ49fsV98oE8yjF4aafgn3KRZhdoeLSxkWsfmKUYnbrBZYIkML/gNYwdERxKiTsJGI8BaY6bLbi7IsN9ReOPLzq0Z8eJHZOFM0T/Y70zqM4XG3Iqz08t2Dvj/oPNpNh4Z6F6L9g6 OOQr6+D+ jS3wCJAvjNfDxKPBZo4tSieC6CYdBuS+AdVMdVj0L95vBcluEWyXZC+27x7D7oVlrXE4K2NGO/EXUT+MV5FekBFRQ1yHJka61QTAgLUWv1sGxCk2y4KxHi8WuUr6hkuyDnvNOs1HDqVG9vKbII2UrpqnYkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/05/25 9:16 pm, Matthew Wilcox wrote: > On Tue, May 06, 2025 at 10:30:55AM +0530, Dev Jain wrote: >> + return unlikely(pte_pfn(next_pte) - pte_pfn(pte) == PAGE_SIZE); > > umm ... PFN is in units of PAGE_SIZE. Did you mean == 1? My bad, thanks for pointing out.