From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D83C021AA for ; Wed, 19 Feb 2025 16:13:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A12EC28023E; Wed, 19 Feb 2025 11:13:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C76C28023C; Wed, 19 Feb 2025 11:13:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77A9228023E; Wed, 19 Feb 2025 11:13:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 50C6928023C for ; Wed, 19 Feb 2025 11:13:08 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CD9E51619A0 for ; Wed, 19 Feb 2025 16:13:07 +0000 (UTC) X-FDA: 83137188414.30.DBD975C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id A12CC40003 for ; Wed, 19 Feb 2025 16:13:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GY5tP2OT; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739981583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qc0Hc4QPkOzkIooUycJdGnAOQy3VZli7UZpS44h6MQg=; b=fxDhNMbLzRWfWpKl7BEs9R2M2PJCyQC63Q47tstEfHG8Eg0dVJmNCuRIoS/fa3BE4W/CPl 94y0O/RCAw1UWL2+7pydXlIW3oABcpNLHvspWN7emU+ecHmWFnx/nACOHvNH1s8vL5NkHk 21Uo+XPkHm4lFfaFZmZqDUpX6XF827o= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GY5tP2OT; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739981583; a=rsa-sha256; cv=none; b=4BEROosikSwT2X2Gcs/P4IZHLN0puhcK+LPPsMV9uMGQ3iCSuNHtfp7GZORPfoj1Lp4DNn y1sHUmRJH3vCrP6GhLSDuJakhETc88/OobqAUOS94mVhd9OU50m0HadToMKbwmRcPePMpF WB1jAUb9AxebRLUDZSHP5mm6hhGfYgk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739981583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Qc0Hc4QPkOzkIooUycJdGnAOQy3VZli7UZpS44h6MQg=; b=GY5tP2OTs4C2L/TAr1Puoc1SllK1wplkh0zu33tLhzBhFAvv0X87vpPqfg1qBvLjFfwXmK CW2LWKmq+ZDYNvakCVjeFihX+RTtFpiwKuHS6s9kSsOcdK+hlb1G15i7J7F6qYiVB/5TU4 EeZSOZWC3bFdyft56U6iVw1tVJvgW1A= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-eq_bYsdsN1GDTJ26aHV_pw-1; Wed, 19 Feb 2025 11:12:59 -0500 X-MC-Unique: eq_bYsdsN1GDTJ26aHV_pw-1 X-Mimecast-MFC-AGG-ID: eq_bYsdsN1GDTJ26aHV_pw_1739981578 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4399d2a1331so4215825e9.1 for ; Wed, 19 Feb 2025 08:12:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739981578; x=1740586378; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Qc0Hc4QPkOzkIooUycJdGnAOQy3VZli7UZpS44h6MQg=; b=odxoNsDAzDrttI/syIihlm02EuIjG0hy301QUAbcmQ/JkKGZgiByPrW1q66fGm7wp6 h8anpg/aX19Y+tIGxrSAQnq2+9mutwutvGgPRcrt8WZVdLFH81a3mfmv8YD/SFCKIxmi 1atrt8SDeZVNl/E+BbWhDspQ8i84/IJXGVoBqT9MmVNExfD7Y/k2/FkskbrGxk/mxf7Z ruPoBhwbMz3y0TCPP/emap3/Xd9IDr0BdxEI0oVgMFACgwcFJUtcrc0WjGhPwMy5UzdJ ZCeafKMeBZDLwMYTPT361jliEgw2TWxvBXYkTMm6y09DIJIFEtlnHpZU/N1WnF59h+mo LQRQ== X-Forwarded-Encrypted: i=1; AJvYcCWV3yAF7AN28llR6XQ3KFPQy0D4AD662Ioe6K0OR0Pi9Ndjs/cxMU3OcCh1edJr/E/PUWZ0+X7yIA==@kvack.org X-Gm-Message-State: AOJu0YzlWQ5ABot1qXQU87qBZm/XrzFr5izocpJJqFnV97eQMJhidTdU 9o1PvOSiaSVCf8t9UxxjJJArs1qnp4FR0f/uOxe7eGJsfmVffzHE10itkAQRQiKEhkH/hnoHSjC 4Wxz3pqWPifNPyMIiGorFR1UV8Oj+hGZqtVhewOS6G5ts8N2r X-Gm-Gg: ASbGnctcwGInOALy72HiS6RN08235t//9B9xbdBOVr+/PxU2AJFVFRJS3GGSRfFBp2z Ows12xToueKF94mjE9+Mag2q1iboSh8x87BmoBXXAkxjOr0OSHylawVJGgO+QU1l/DthqNrJWOK SdI9zEcAA1EwotRlD5gBjiVoMCT5SAq1nsp4kSZRGFg0fkAHm8o+VKFYFvqAhSnPyF224mk4U1+ XjmSnHmrjYVcDgYOmijb4ObwHpwD0nqv1fsSQE9HH98/chPxgCKbOUZIZftGLM1yRCkoNDKPjZr 1SgMoKqLrZM0jsxQzf2OyF5+URMFORh78l9z0z5WxC/IylyVSUuVgJUDrObouWItokcK6YKdfHA fhj6qdg/pE8q4SOHM4fT7dKdC73V/m2sH X-Received: by 2002:a05:600c:17d5:b0:439:8490:d1e5 with SMTP id 5b1f17b1804b1-43999ae0204mr36733555e9.4.1739981578303; Wed, 19 Feb 2025 08:12:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGgyV0oed5NHSmPgVRPD7iiPxy4T1Xt6roKv1XTYfIc76HANJ9uYK3uKYFAmxkXXbO43Swfdw== X-Received: by 2002:a05:600c:17d5:b0:439:8490:d1e5 with SMTP id 5b1f17b1804b1-43999ae0204mr36733385e9.4.1739981577964; Wed, 19 Feb 2025 08:12:57 -0800 (PST) Received: from ?IPV6:2003:cb:c712:8400:50d0:d1c1:90d6:e2e0? (p200300cbc712840050d0d1c190d6e2e0.dip0.t-ipconnect.de. [2003:cb:c712:8400:50d0:d1c1:90d6:e2e0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43992ad82cfsm58079805e9.37.2025.02.19.08.12.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2025 08:12:56 -0800 (PST) Message-ID: <34e18c47-e536-48e4-80ca-7c7bbc75ecce@redhat.com> Date: Wed, 19 Feb 2025 17:12:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page() To: Oleg Nesterov , Tong Tiangen Cc: Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Andrew Morton , Peter Xu , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, wangkefeng.wang@huawei.com, linux-mm References: <20250217123826.88503-1-tongtiangen@huawei.com> <3b893634-5453-42d0-b8dc-e9d07988e9e9@redhat.com> <24a61833-f389-b074-0d9c-d5ad9efc2046@huawei.com> <20250219152237.GB5948@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250219152237.GB5948@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NmCXleWIV_90gVXmlJ4KN33Yrtl926Esmk4eprVxtdo_1739981578 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A12CC40003 X-Stat-Signature: woo5rcn3w31t4uwm5jrc9wks9n7tbnmq X-HE-Tag: 1739981583-193823 X-HE-Meta: U2FsdGVkX1+DhkihlxVjq1EhzXvcD2V0l5pfa06RyIfZ4AfJAWCG0cHOO+DuZa1zQhf9FXWgxtd63vP3rdJZvDfhqxeH4dxGT1mdvpMg8/lmMxIf/1+N1tJ8+kHTbrqIuqBHPOQSf3D1KotyJHvxPKR9r96aKr6vtDatubZDbZea/0IHYuCmd++2xBaJE6LJuo+op9qZ7X+K5e5vlvMHypmv2GpATVJCch9Tc/XY7JVH6O2BTaIJoLpuU8xq4qBRpGzHGWI/AFgWvnAYdVLL4TL5jK9M0C02CcpRBxVB5YAPMUlWU5+NYpEhMvyxzNimwwtrhhT+h7r4Skrasc/A4chWEjLhqGhX3a9n1kejCqQSww1s8YGw7PowjXmvt+s+FMomRfaZtJNenTloMMQ3G2wJhbrpoF13J/1hcf1/oVFsqxWhRfAXtfG//8JmnlLP10+zO9KPAUpy3vKoLHVgbgqj/woXYecIAtCkBNbWlQWgSqjJ5Tm4ogkZI+stypnOBBW/eV+p0Dyknkuj8D/bAzpoRW+lnm28JR3gjrevItNhSMi7XtcwYNbHUQTGRGbSDmvtvzMjh6cX6rRtIvutyZNWB3QaPE7pk36imNwa8IBb6QunYGkUxhuvRF+JG8jKmm2cdwMIEXkzrhkbx9G6xCxX0Ps0REE8JDf0s9tk3JJYEEORkltQh2vGsVMCy4/UsXR+DOKDKlieQqvAt3f5zGmbwxSM3vnPNex6z0PTJdU0awlVO+z7niWdNOXwG9qUnT2FXaVkB8076dPWDwdntPryIDdoByfRki1F0bK81gf3/6Oy+s5ghLXuXFvqPzcJAJZyApAiDxvovbgk9+nPNfV1DPqYa7FZBR67tAwItSMAZfeAXMJ7I6fZzggoLzFCqcZWyzxbb/+hAd5/C/OA+odziiNyqeYSuHrrktJsGH9EpDxZtAguZILL+9rNKm+NUcAwFWsAwq3dtiNeWh1 masEFQxV mCkY/ttflmDEM8I3kVMZ5+MNGyEGU5xNJWh6gGhSJjyu28aJlbZhUy3ToZRtJ2Ji2AvRyXxRxCpxZyoj0qBU5HQuG/k8WaHdHuJrbdcLxgorAi8dbRDXs1AnSIAAOz+CM/LENDzwhtck3oWoU88RDKXGaSqoM0dYPSZTDWICoxm2PAzHoaVcTmbRI0ROHq/rxr8NlVIhqxQhxt52wcKdJakBaAsduxfHTu+QxN8NGFALGax7f4yfB29AjVESlVBB9eu4Yp/wWqQ2iiw9lmQN/OZXd8QZbdRFcuP9lRB5OaYQTgbmpJ7VJg/bOiqhWgC6eaIKV61u5wVig+an/y6JYTM9tdi186rX+WKkZovjLxfTez9piijh3/uF2XL/y+lMk6K7JaT/MHl1in5SaWIbe2aW2GBIpy0OnDhWqmqAFY039EP2pK7g9dNp16H48yiUmZ7r62hmrHei9O18rGySpm2ZiFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.02.25 16:22, Oleg Nesterov wrote: > On 02/18, Tong Tiangen wrote: >> >> OK, Before your rewrite last merged, How about i change the solution to >> just reject them immediately after get_user_page_vma_remote()？ > > I agree, uprobe_write_opcode() should simply fail if is_zero_page(old_page). Yes. That's currently only syzkaller that triggers it, not some sane use case. -- Cheers, David / dhildenb