From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE0F2CD98C7 for ; Wed, 11 Oct 2023 06:32:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E8FB6B0260; Wed, 11 Oct 2023 02:32:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 299606B0261; Wed, 11 Oct 2023 02:32:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 163296B0266; Wed, 11 Oct 2023 02:32:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 033AC6B0260 for ; Wed, 11 Oct 2023 02:32:03 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C5555120173 for ; Wed, 11 Oct 2023 06:32:03 +0000 (UTC) X-FDA: 81332210526.28.3B3C309 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf24.hostedemail.com (Postfix) with ESMTP id 6152C18002E for ; Wed, 11 Oct 2023 06:31:58 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=none (imf24.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697005921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YFYUBIV37fXTF90JGUciSvs7zGA6sd5mJarJaK4bNbQ=; b=q+IzPs9KROFZp2ahdUmfDYwcONfI0JIqJXxPv/OKe0NE5ve4mYj9ZpIdT4hhKCtbOFLE3Z Ub7xvO2bNfWeRL5+pkz5HAy7kpvw8opKE/1vkVlLsHw6AH9XTnEVBwtVMIsRl/Lt/vq0FF AKVr4/GvsZK/HZXFX7A/pMF8yr0nkVM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=none (imf24.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697005921; a=rsa-sha256; cv=none; b=NC4nTDf5VLogeRYT1XB4fOoRc7o2fK4CiB5rIjJ7khdUV2U2wDA2aOXRY6+9Vlwxm8TCBS C+TDz3sDg+k8BIuR3TSuJ/zUnzoxNzM1ysWMOO14FHoD8H1g+iH5n+X5uZ9q2Z+MvJW7E0 VMJggepOtCjWwE2nWwtwy+CAyYYUnT8= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4S52x301B7z4f3lDb for ; Wed, 11 Oct 2023 14:31:51 +0800 (CST) Received: from [10.174.176.117] (unknown [10.174.176.117]) by APP4 (Coremail) with SMTP id gCh0CgAnsdBWQSZlhxytCg--.8746S2; Wed, 11 Oct 2023 14:31:53 +0800 (CST) Subject: Re: [PATCH bpf-next 4/6] bpf: Move the declaration of __bpf_obj_drop_impl() to internal.h To: Stanislav Fomichev Cc: bpf@vger.kernel.org, linux-mm@kvack.org, Martin KaFai Lau , Alexei Starovoitov , Andrii Nakryiko , Song Liu , Hao Luo , Yonghong Song , Daniel Borkmann , KP Singh , Jiri Olsa , John Fastabend , houtao1@huawei.com, Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton References: <20231007135106.3031284-1-houtao@huaweicloud.com> <20231007135106.3031284-5-houtao@huaweicloud.com> From: Hou Tao Message-ID: <34d9c871-223c-7598-dc1a-b1dda27073d0@huaweicloud.com> Date: Wed, 11 Oct 2023 14:31:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID:gCh0CgAnsdBWQSZlhxytCg--.8746S2 X-Coremail-Antispam: 1UD129KBjvJXoW7tr1fKFWrAFyfAFWxXryDGFg_yoW8Aw18pF s8Ga1UCr40qF4I9wnFgF4xCFW5tw4UKr4jk3WkXr1Fyr1aqF92gw1vgr13WFy3tr47Kr40 vF1FgFyFv34UX3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv2b4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a 6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVW3JVWrJr1lIxAIcVC2z280aVAF wI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa 7IUbG2NtUUUUU== X-CM-SenderInfo: xkrx3t3r6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 6152C18002E X-Rspam-User: X-Stat-Signature: rsxjwfs7hm36too8os9q8i73s7ebjuup X-Rspamd-Server: rspam01 X-HE-Tag: 1697005918-949911 X-HE-Meta: U2FsdGVkX19JqdRZWCT4P9hWGycWH9HnVbSYNBPnY+0v+h4dK0ypJWILglvAsoxP3WZARWQtly2ae/CexqSkKez5vnt9MinTL6JBoK4n9e+liz8iSmxkgm0Tn/3ib5kXGdGzox4I8cJDYMF/nRerXyw24+olIGluITUEdeRqqROSoOqQzzxPOaisAHaUheBLRiejiYM8tPX9XNoxRRNTM2JzQXCdR2gsM6Ce/WTughSmKY5i0pAp/WzigPuPHljaCZpSSEWDNk8ipnPMZJUA1IAATlImcnUR1pV43Q9Y+NYXygdrvKBqLbfWS+fgwtcBsABi+TzxgypW88qILZvbYgb+7CKYt6d2yqwqiRS6CCtRVy11yeS/vPWPp2TTHQ7S3SKJxSiPvYdxXKMST0EZruqrg6Q9QOzVwJwyd7O+Dcz78xwN0zxenUCBUPF5D9IQWnQXHtRsjnnmXz3iXB2igVEgndD036IaZeDUBWk4n6b8jaJj64HDsuLejk4LuhVdXnXkMtZq7YhpmkJ/GJyjsEz7FpH9gUf7CYAcWQ4KqCiFgTnAu9MuvXzh7VEW7pJoaKO1w0fEqgxnLKYIwAy2n8e8ocKz2F8geUY4Y8229qwPj3HFhkXJU3LCKzOzDNwxwRi/61tvJHrd/L+Nuv0F2XQ8YTlqK5npK9AaevvMXi9WIwe5KcAXuQAywOyTr+TGJSM8aeYrRlcAk4pjsaWNLyXc1SHJERBZbTKIfToHTO60qN7KaqcSWgMT7D/mxh0Yiys8w4/o6+a1exolPmZnCu+NbEo8BOSJ8OPUEjA7IBTMQxLryiw7Vp2YOUBFLM9H0KIQBWkOFTfL6v+qFUaSzTW3PsLogFbF5qIXswse4ihGrI8xK94SWJdn+CnyqYltJ5kniWxi4x4im4l+vXfCMYSWBQhDlyqSSUBG1xj30be1Rg2WlJlwUqNukifJVB5muuM7tJvoCfVPMq4BbXD +VR42XN4 G5RHTM0CBU5t3q66rdsGuyE3L5ck7jan1PI1Q+PpT/w7ZF4WLyA1xQ3+krlH02KmwO1zPfVmFwJGDTb+x35vDo6VIhFkc/3dUiD3/jPG8lC/vGVVYA4syotza0tDAFmL8lmvgqSmbHlU78/2bL5y3xAkzHGh3QtOO2Xg3xGWYZqQoIYvTjqnEpvA4VJBTJhw3hIbPozauMEwPCviW4Gk0pgwAGUiCodA2qUdALFZsOieAQqUzRJdzKEmg+UcvoN8L9Ks9j5avmQPZNUEYunZqDx9o1X6aIzy9hRX5nZbupZKcZTXnp0AHAMjMTM5wWV6H3/S0TYPXuK+bVjV8C+9vatuJEC0OqVhTLEiWm8hWeft2LSM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 10/10/2023 12:28 AM, Stanislav Fomichev wrote: > On 10/07, Hou Tao wrote: >> From: Hou Tao >> >> both syscall.c and helpers.c have the declaration of >> __bpf_obj_drop_impl(), so just move it to a common header file. >> >> Signed-off-by: Hou Tao >> --- >> kernel/bpf/helpers.c | 3 +-- >> kernel/bpf/internal.h | 11 +++++++++++ >> kernel/bpf/syscall.c | 4 ++-- >> 3 files changed, 14 insertions(+), 4 deletions(-) >> create mode 100644 kernel/bpf/internal.h >> >> diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c >> index dd1c69ee3375..07f49f8831c0 100644 >> --- a/kernel/bpf/helpers.c >> +++ b/kernel/bpf/helpers.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> >> +#include "internal.h" >> #include "../../lib/kstrtox.h" >> >> /* If kernel subsystem is allowing eBPF programs to call this function, >> @@ -1808,8 +1809,6 @@ bpf_base_func_proto(enum bpf_func_id func_id) >> } >> } >> >> -void __bpf_obj_drop_impl(void *p, const struct btf_record *rec); >> - >> void bpf_list_head_free(const struct btf_field *field, void *list_head, >> struct bpf_spin_lock *spin_lock) >> { >> diff --git a/kernel/bpf/internal.h b/kernel/bpf/internal.h >> new file mode 100644 >> index 000000000000..e233ea83eb0a >> --- /dev/null >> +++ b/kernel/bpf/internal.h >> @@ -0,0 +1,11 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* Copyright (C) 2023. Huawei Technologies Co., Ltd >> + */ > Don't think copyright works this way? You can't move the code and > claim authorship. > > In general, git tracks authors and contributors, so not sure > why we still keep putting these explicit notices.. My bad. Thanks for the remainder. Will fix in v2.