From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE0AC6FD19 for ; Mon, 13 Mar 2023 16:21:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D8536B0075; Mon, 13 Mar 2023 12:21:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 487AF6B0078; Mon, 13 Mar 2023 12:21:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 350046B007B; Mon, 13 Mar 2023 12:21:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2247B6B0075 for ; Mon, 13 Mar 2023 12:21:53 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F3203C08CE for ; Mon, 13 Mar 2023 16:21:52 +0000 (UTC) X-FDA: 80564391264.28.0CBE6BD Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf06.hostedemail.com (Postfix) with ESMTP id 9162718001E for ; Mon, 13 Mar 2023 16:21:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="O/lj4ScZ"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=b6G5YtOZ; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678724510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=957lCchpL8BUZawVrhn7/dgEeyT0pbaGfoRJtdtut3E=; b=LrQJO+CG2Gypa/BVEclt6AeUxkIL2ool5zWX/zdQnCy78KLMP2MaGmG29PLxKmzRDBCjkN AtxQF5U+YUOpTUhym4he19+p5PqIidIYEF9ccixk6L+jUoEogZnU1EhEFtxwqDK8uP1YXI 5wQXtt8PYKu7mcV5HmyF7uRZeE5b3zQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="O/lj4ScZ"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=b6G5YtOZ; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678724510; a=rsa-sha256; cv=none; b=IoTk1Dub+sbkIpc4MFSMJWGFJh+2HVWCluTl+BjUxiT57VikGDsJGWTqcInvG1+YUYqwSG g9/984YuCqXViYUO8XuvNbr4e9SbU5t+iHK5HcQ+dpOx6pt1pSXBkaYex6z7MmoyTcT0/T orFmzbYLOsSec4Pc7eUOCZJK25gUV0g= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EC85F1FE14; Mon, 13 Mar 2023 16:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678724508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=957lCchpL8BUZawVrhn7/dgEeyT0pbaGfoRJtdtut3E=; b=O/lj4ScZ6vYmUOtjfzEAfraHQoD09YkGYAw7PBU82SBNDqoexj2W1AxFC2bp85HuWnDE/p 658mRBaeRKa5vGHeoNO1ssbqRFxpckFIRGeoMYPWSiK1G5uhbkWdiq/c2El/qbqIQu0AAW VXqtATlf/gYYvF7P/DS1+beYVdc/6rY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678724508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=957lCchpL8BUZawVrhn7/dgEeyT0pbaGfoRJtdtut3E=; b=b6G5YtOZXimkCUIH/JqU0PgV2013nyqYiVWKEEXEyFSbeIYS2yCf6MfNP/iI5Dj0FxzozR z95LDIkB8hfnCbDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C4AB113517; Mon, 13 Mar 2023 16:21:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id W1I9L5xND2SVDAAAMHmgww (envelope-from ); Mon, 13 Mar 2023 16:21:48 +0000 Message-ID: <34d76760-d24c-0e34-b8c4-d4f5fdc342b7@suse.cz> Date: Mon, 13 Mar 2023 17:21:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm: slub: make kobj_type structure constant Content-Language: en-US To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230220-kobj_type-mm-slub-v1-1-5ae49b96d9aa@weissschuh.net> From: Vlastimil Babka In-Reply-To: <20230220-kobj_type-mm-slub-v1-1-5ae49b96d9aa@weissschuh.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 96jpc7ss7w864e78eatxubkrxuqknccp X-Rspamd-Queue-Id: 9162718001E X-HE-Tag: 1678724510-81778 X-HE-Meta: U2FsdGVkX19BK76yq91atTgztOUkcr+Nt5DDguTUFcL4fPpzrfPdjGp0b/u80OqKtf3y4D0F4M5EeV+SiUf0TVHMQVSSwc28VT5uR/q5Pf5e1qfEd6E3Fbkl/rtPBPo2kEIlKoBy9ou5hGLM739bgVVNm8GjQfUA1Oa7wgtsbfmvdSKF9eTeE8BOne1w2Bnj+9skkJrA9vwaSmqZ4oUPhu8VjMvBZO2OICjL1hYAiAJALcdki5iqThQ71dQLFPz3E0AJI6s+NzW5+BBYAyFtlG9KU2/IsAqjHuKRW9uqt5lymGszALW8/wEntXvoixaSadEIFlx+gG3YiYuN0bcWo7YdeWSSx2ZD0/ZEr5rXzfduHM2omVUL92f6jrTkcZgi9gNzJoyuxgEtnYvz7oD2JpN4mKEexw7K0yn1WV0vfEbX1IthbVvUIKVIdiIaHVuAIz6JL5NJi3Ay7UYREiBARRl5JwvHNg+HLoeQEozZJtBLTAByQw2iIdC4g78ZQZqiHbCyH0RkCY9x/RWOP8HoKpBKXa6kv19YVYTXS97dwZj8foyy4Z9WCq1iLIimU41HNOtzN/ovECm2e5heor/EMaV8sGoiqlMQrrf4Lekt14A2DvvPP/6UXdD/RuFL6CaVplDDVMJjt/Mh+EIvQaYWDymVKMu9tnypzCLgM8cMIqSQ53un29e57HFjlRQbO9/PYx6un7xv4CixUApHx6ODKUMDG166/ZgbWsVlli8okGNaablE1NX+AuO8g0hNWwrg0JTd6LIvW3UTI8AeIU6M0jVM4Rp4pMnIM+gzvhteNOCnSpt+uWwiZU1Ajuxe89g6EhlkBJM/hvO4XY2/qR/OvYWeAqL+uuIW8P6DMRsQd1LLQWnrZnlYzjq+RQMk2nqwG8KAyTB1ooslE0E9uBFr9WDnXlcpTDf3DR3y6jUVNXGp/05ervUJzdj090ODWF8WDWG+994yYHF7KZ2oq7e AtMJ6mPh 21lKMVz/TA71Erj8T1CLXrWzQNDnSSlJxv9KJMMuuxc9IvMoEro0AAHiSMECiw06yhOpEfvcB8thX8ufxhX2A3fzDDaKfMIs/Eb+FuYjUkXL+OEEQHnHomd5sb+9MRUy80z97/tV0i70A/JZQrHQbxAwhsgv+/yCWIN51V+xfVl6L0a2OWblnikoahiMR+8ztjPsqka1WdDn6r50wbq2OlvVc7YTimk+eMGc/IDr0eO+rQHb6j859wnKpuexVXHulhJL1H4zXyN7+/Y7NKIxtiold0/j3QmFqVRcmxv/7oBxKQAt2GolDJ9wtgPXjDGpqxOFxHvUBO+xaf4wqKnxuRzxxBQsEqRTlE52ZVOa6+sKHB2gNiaFtj/xU4kof6MA1IDt2L5cN4L4ABB8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/21/23 00:25, Thomas Weißschuh wrote: > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") > the driver core allows the usage of const struct kobj_type. > > Take advantage of this to constify the structure definition to prevent > modification at runtime. > > Signed-off-by: Thomas Weißschuh Thanks, added to slab/for-6.4/trivial > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 13459c69095a..be710dc4dc3e 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -6058,7 +6058,7 @@ static const struct sysfs_ops slab_sysfs_ops = { > .store = slab_attr_store, > }; > > -static struct kobj_type slab_ktype = { > +static const struct kobj_type slab_ktype = { > .sysfs_ops = &slab_sysfs_ops, > .release = kmem_cache_release, > }; > > --- > base-commit: 5b0ed5964928b0aaf0d644c17c886c7f5ea4bb3f > change-id: 20230220-kobj_type-mm-slub-02d25836de84 > > Best regards,