From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com,
vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] tools: add VM_WARN_ON_VMG definition
Date: Thu, 16 Jan 2025 18:19:57 +0000 [thread overview]
Message-ID: <34d16918-ca87-46b5-a929-7f6ef78f6304@lucifer.local> (raw)
In-Reply-To: <20250116181538.759469-1-surenb@google.com>
Andrew - is it possible to grab this for the 6.14 merge window? As is a
benign fix to VMA tests.
Thanks!
On Thu, Jan 16, 2025 at 10:15:38AM -0800, Suren Baghdasaryan wrote:
> vma tests compilation yields the following error:
>
> vma.c:732:9: error: implicit declaration of function ‘VM_WARN_ON_VMG’
>
> Fix it by adding missing VM_WARN_ON_VMG() definition.
Oh damn, super ironic I broke my own tests with my change... ugh! Mea
culpa. Thanks for fixing this!
>
> Fixes: e3a7ae85f87c ("mm/debug: prefer VM_WARN_ON_VMG() to report VMG debug warnings")
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc: Liam R. Howlett <Liam.Howlett@Oracle.com>
> ---
> Applies over mm-unstable
>
> tools/testing/vma/vma_internal.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/vma/vma_internal.h b/tools/testing/vma/vma_internal.h
> index 2404347fa2c7..1eae23039854 100644
> --- a/tools/testing/vma/vma_internal.h
> +++ b/tools/testing/vma/vma_internal.h
> @@ -38,6 +38,7 @@ extern unsigned long dac_mmap_min_addr;
>
> #define VM_WARN_ON(_expr) (WARN_ON(_expr))
> #define VM_WARN_ON_ONCE(_expr) (WARN_ON_ONCE(_expr))
> +#define VM_WARN_ON_VMG(_expr, _vmg) (WARN_ON(_expr))
> #define VM_BUG_ON(_expr) (BUG_ON(_expr))
> #define VM_BUG_ON_VMA(_expr, _vma) (BUG_ON(_expr))
>
>
> base-commit: 4637fa5d47a49c977116321cc575ea22215df22d
> --
> 2.48.0.rc2.279.g1de40edade-goog
>
prev parent reply other threads:[~2025-01-16 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 18:15 Suren Baghdasaryan
2025-01-16 18:19 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34d16918-ca87-46b5-a929-7f6ef78f6304@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox