From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8021C02185 for ; Mon, 20 Jan 2025 07:50:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5384D6B0082; Mon, 20 Jan 2025 02:50:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E7E86B0083; Mon, 20 Jan 2025 02:50:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 362216B0085; Mon, 20 Jan 2025 02:50:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 15F3C6B0082 for ; Mon, 20 Jan 2025 02:50:09 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7B58481EFC for ; Mon, 20 Jan 2025 07:50:08 +0000 (UTC) X-FDA: 83027056896.25.265CE9F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id E5625A0009 for ; Mon, 20 Jan 2025 07:50:05 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KbmGLCd0; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737359406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uubHGHZOYKVc1XOiZc6ZGTaLVbmG5dy5mGIOvRhGN14=; b=uMItbjKw55dppkBkTnmm/D/tkDcXHSIPM+loPOCCelWGsWvVcO/TGh6e/bkpwsz/Pv88U2 m50TGxeKLmhmSF/qEi/+4TsIOCqfcTswpL7seD6gMV1F3O8fC2I/Cmc7KUNgW0kl7bU4ET fryovYs2TMnuZDlPxYp3HYPpGDc8LIM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KbmGLCd0; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737359406; a=rsa-sha256; cv=none; b=y3J6ciCy8cT03+xJ8dMF5R+t2k2mxpj42MOkHFF5T0v2pUrYSbJ/rWYgVr3wcoiYnLuld1 3soki/L85cmHg4l4uay+T9ZLp0/mjQow9msmEOeExEauCKImstnrEIZG0yRwnglaz5gvO2 p6/1yY9zZqVCa6emzUmafkzuh/JCLSs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737359405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uubHGHZOYKVc1XOiZc6ZGTaLVbmG5dy5mGIOvRhGN14=; b=KbmGLCd0yG3pURsuebgvO9PCSYnFaz4F1jeU7AMlZvvIpY3TJWN0h1ZJyXPpIZm+34RE0J OTU4mRvRpTcx2VmVG9JJFS/zEzDoj7YxzxYxKKN+LjRLtARhY99HjWpU1eDcDJzJi/TBZK 2fU1IE7+wW4Yg+iwyoQ/aEi77solmjU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-604-VKjzyIoeOxe4eDCWdHiamQ-1; Mon, 20 Jan 2025 02:50:03 -0500 X-MC-Unique: VKjzyIoeOxe4eDCWdHiamQ-1 X-Mimecast-MFC-AGG-ID: VKjzyIoeOxe4eDCWdHiamQ Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4362b9c1641so19534595e9.3 for ; Sun, 19 Jan 2025 23:50:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737359402; x=1737964202; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uubHGHZOYKVc1XOiZc6ZGTaLVbmG5dy5mGIOvRhGN14=; b=FUy2rSlQu+cG8t3u/anivD+btLInup3p0eI+RftrcbGywbCB5B+g88VcwkOo1GagbA vro1LmU6ZA2DTa+SrFAImcpMTmd6LPvg2kpa2iZkjHuLqudZ5J29yjHqcBVMMlXxjmtV bm35yfv7wxJHXutOLDseRhh/R4JglJjDw8F3LulLT82/AOEd5fSGjWXET03BmvNcqABh 3sWTAkkqhWldVjmOQ+BCwppnVAEnfVcAVyzLFI4ePgJAudhdSV11amvpA1YeeHqa+Yl9 /Mn/5KXUI0RLp3XHxPmLqr1ie0yYfD8Qt1ByF/EGej6Wcuttb/VKCNS4KCZwAKX2a83a +XNQ== X-Gm-Message-State: AOJu0YwNXZIn97PQt0T6k+RMKjGFOblSRNWFv57XB9HiuV6pOSDpOXQg EVERajzpZDLEtI1DhSOHE2o+Rq5dqXbNtyvB/ejewA/ZG/mTWf9VGcifIYZXaUzicCIIAhc4SVc gk1T7ldq+DnGtrSd80D1uNEs0RN4HBU6bZNzYQZ/a54Sq2J+e X-Gm-Gg: ASbGncsbG/4EaLvfVBOeHLQcUxa0rhOJaZsCQEL+BWj8Jt+Bsjmf1C8FIWmaCb5oUrr y6geYvP/iGenaKlwjM2yL+C/N1kaq5e1+JN8szztpHlFhl38D/zZU8cpJtBwhAYt8CEVasIwvuY rgNJWmQUGRzvert7BwsyTdkoEXOfA/n995RI2lFvK4h0UffF0prthstzwNgmZ1WU/O+WLn4wU8c Ji+Wf1opUPLzP8cyitwm0hJJNKaQKzVeWjRsgx9kART1QD98FvtXxEDHmR84RsIv1xHwJwZn/Bg I31XKKtqjaZn0A9+u3n17FIH/VL6bU/xlPRqfSsiiNgxcGsPdnUQCxyk9VxaGvOxVdlzZaOoBme 4R0rQkFF7FrNEBw6+wUo6JA== X-Received: by 2002:a05:600c:1987:b0:434:a7b6:10e9 with SMTP id 5b1f17b1804b1-438913e2fa9mr113951705e9.17.1737359402090; Sun, 19 Jan 2025 23:50:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRhQiZcCx864cqBqCtmAk+Rz1VIBg6nUspozR4BDSgvMBQ8KVQUqohtdk2nDGJJSZwRuOYUg== X-Received: by 2002:a05:600c:1987:b0:434:a7b6:10e9 with SMTP id 5b1f17b1804b1-438913e2fa9mr113951595e9.17.1737359401795; Sun, 19 Jan 2025 23:50:01 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438904621cdsm128576665e9.27.2025.01.19.23.49.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jan 2025 23:50:00 -0800 (PST) Message-ID: <34ccd133-7623-4cd8-aad7-08526a97c472@redhat.com> Date: Mon, 20 Jan 2025 08:49:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm: memory-failure: update ttu flag inside unmap_poisoned_folio To: Miaohe Lin , Wupeng Ma Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, osalvador@suse.de, nao.horiguchi@gmail.com, mhocko@suse.com References: <20250116061657.227027-1-mawupeng1@huawei.com> <20250116061657.227027-2-mawupeng1@huawei.com> <21674fcc-bd5d-3e32-6e45-f0a16ab93202@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <21674fcc-bd5d-3e32-6e45-f0a16ab93202@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6TSLUHZuFOWjyZm3fy_8aERFmXgK3AlFWc8XVXYgSDo_1737359402 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E5625A0009 X-Stat-Signature: uqydgxkrm6ajkjqgw9ezr6unq6ct6ucc X-Rspam-User: X-HE-Tag: 1737359405-412972 X-HE-Meta: U2FsdGVkX1987vFZ1AcQ6+sB1sbS5NewHX8E2gxNSLCDr572kreq94ULOJqjUMVGr9DVpd2/J9AqX49U5RePWC86bR0XiC1lQ88R9SYcu8CJehvA47uyz+gCoVgeoYx2FuEFVMUQycrIrPLUhy0h8fLGG7WIvceaDDnFKmURm4D1VnQAehhfynWJJkpvWIWPNeX28NFN0UV+icBQ+BIqJy537GcdOR2gUgHY4SYP4Ic6GiMVzzTRo/CrdwS2FJsJdHLwPRBVAQQ7szgyB7RA3b1Fu2hYxT5QjIdhmiRhufGNTmohZgeLeoOF8FB+TdyY4JBk/gfRIwanCmRfv9Nu17SevOssDQJCTwklpG7JHwGmbbaW+hPlzIMZObc7vlC31o2tshLx+W5QIfAmhpfQw/PttESfjStwG55387cjtYLygBhi7eOXxNeplLMgIZV0ifYF47zU8bZaoVJDwQC8vT5WR9g/LUIXCKrlmd+nPxdl01i334judZj6w+xpbUfEUa4ykdutYt6MR9sgDKkdm/BPmRKHoA7poux8n3uUfB+4N1O6RmYQaTtzmBZ5RFiHmPCxrCYF85hb/+Z0aYF4yty4NvBzmHu3bNvlMXGlT1JyQ5+X3YQCyni3yTVRARpVUPd50Rph7cyY56k1CK2Uk2A/T5h+hPcLNCCXx1/YAoEnsi42/ChdXyKARZCbLb9r2KFjteRxj3VKHjqX8neatd66jTtU3dHWUdIxkwtBhC6/9K7cXnRaKmPLb+brzGamiIybG294GPcOqVb++IM5inTusc7JrmTyHDxathFOM8WB9cV03sfUoCJJPTdnbfLbnqmbzANvT04lhLZKMvspmFpV14cBYAJQmskqnFsQ+3pVmvaA9nChWYrIASzBjYh+DKpgnCGMHZR/DbHOdIxdyuihgFDS156qM6XllNmOJb375DjZf8TBLlbWx1q3w8r2IHb5oJ8wxxHaI+IDcQr Kh8k4fEA amsN8342nFkj92bp1iLfkU1sTNuvrWwONKK5PSWmEd0Ddrc1XEFrcIyyIsJ+QbUe//YLb2cYX+VXUF4GdDEWprsKzCXPVme8YKxCLQbBV9bCHPQ2p8Evt6t6GO/5gL/oiAsI0K1ugu3tldReIfhbGsxtkvW45rWMJ5gEu0f65Yh2XtVGTJHzA5gG5i/Gbd5QRVZYY1Ecms2M8CANlo/ol/RypsA6PHetINInZUL9eAqaLUedxVTi7embr1p7mwBMXMO4zKnrMLp6iibjCvzM5hfa8pZn+I9nqQgvNC2kC8FUS5HsJgN1QRXagmheU/xYRSpE24BjUjqIeCkKj9nhyrARQWTJ+JLBMGEdS8VqURw3pJLRXujvf6ys4ornBkrSexkpkQDK3cEqSJIBIrgtnfIM1nY+nWel1LAZ4e26pixwlVg33/BImezeugkLi9ShJ5+h+hTD8jkz8MOhQyAMqBopGlMQ/MUH5AwaHWi3ilotEkJ4/ePyqufe1eE0tvIrK7U4P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> if (folio_test_hugetlb(folio) && !folio_test_anon(folio)) { >> struct address_space *mapping; >> >> @@ -1572,7 +1598,7 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >> if (!mapping) { >> pr_info("%#lx: could not lock mapping for mapped hugetlb folio\n", >> folio_pfn(folio)); >> - return; >> + return -EBUSY; >> } >> >> try_to_unmap(folio, ttu|TTU_RMAP_LOCKED); >> @@ -1580,6 +1606,8 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >> } else { >> try_to_unmap(folio, ttu); >> } >> + >> + return folio_mapped(folio) ? -EBUSY : 0; > > Do we really need this return value? It's unused in do_migrate_range(). I suggested it, because the folio_mapped() is nowadays extremely cheap. It cleans up hwpoison_user_mappings() quite nicely. Any particular reason we shouldn't be doing that? -- Cheers, David / dhildenb