From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69F1C61CE7 for ; Fri, 6 Jun 2025 18:34:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 207376B0092; Fri, 6 Jun 2025 14:34:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DE846B0093; Fri, 6 Jun 2025 14:34:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A74E6B0095; Fri, 6 Jun 2025 14:34:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DB5146B0092 for ; Fri, 6 Jun 2025 14:34:26 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8ABF91A06BC for ; Fri, 6 Jun 2025 18:34:26 +0000 (UTC) X-FDA: 83525826132.24.276AA80 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf04.hostedemail.com (Postfix) with ESMTP id 17B984000C for ; Fri, 6 Jun 2025 18:34:22 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=k5SjJqhb; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=hQj332Jb; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749234863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xwGW4SXK6t1fmAMuoYAX18HVEgcsdTm7bNBwe5X4+4U=; b=QZaQISwaLcbuKMnormmWrpp2/GEY7vstwOhM6Nvv8DVrjWNyXvjW8Qz+ODLJzYgPYwPFvy lvmjZY8SFMUWgOQGiW3djwyO3s35J955qompaErAVxoLQMy3a9KIV6CnNzAa6jxAf4yJMu SqQPo6NGnkA3mAyHV0YQ+vcLYj2qeAs= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=k5SjJqhb; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=hQj332Jb; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1749234863; a=rsa-sha256; cv=pass; b=xj8dltAFQOF54b2OerIoFfsuE59wpIgJw0JsL/PCYsWZ8j6FX6nE3UZof7JCjBjwp+AEju NNtCozmCttNKbXQInXJiz+OObrpZrnv2Ot75Y9b12Uft4rNw4buTUnPIrD3UQinA1NFoHW oSASvnNMDTf7hkadcKcDgpGdFLKhAdk= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 556IMYjQ007862; Fri, 6 Jun 2025 18:34:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=xwGW4SXK6t1fmAMuoY AX18HVEgcsdTm7bNBwe5X4+4U=; b=k5SjJqhba2Xh957g7kExLNf9v3Rv05mgXn S0a1KLpvhSFA3DFf2ftdyTbOV+kmNR8F7lDYTaZGk5C65SUd4INPv1S0NwowFQ6F of3L3hb95P4KC+ikp4K6GVIfJ5o2AVRlQIX09f+zIvIBBiXia7tD3nvLQOmSXYjf S17tW6wUrDnVo/e8y+VVCjUDnrhQR3VWd6bFwnTMwFjfBv/igNEVI0uSICwbRK2W x33KY0ATKH3EC9XSu9/QWQx2I78XgyA6XXAwnI2ZByZFKZUYNwiaZycIq1kz2O6g j7Uc/ORrFXFkKOzC3Hyzvz3W0nH3nHMIhZt23MR/Tb2z3Op+wc3g== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 471g8j8k8v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Jun 2025 18:34:18 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 556ION25034538; Fri, 6 Jun 2025 18:34:18 GMT Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11012029.outbound.protection.outlook.com [40.107.200.29]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4745jxr935-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Jun 2025 18:34:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AjYCW5FRRqBkpwAQuoxXdEioGTRsCaZRryKVHEt0zNfHvWvmEhhuRUfvthn7hpxtpC1nEsCottbhZPv2YMUVWKvwpJcIFlInWZSWvHFUzcNTb8SCCVmasdUUzZiE7i0KqPWlKM29+0ektEUc9yz1/Nu8MfBwNwyFD3zdD2Fvx0fefRxdAFrxHTBvlzsWoRmJm2N0vgKMmLkkt37kbNpXeLbC50lpEeNvbRMKDbbRqEXywoMj5nmIhzOoPcUpn/m7QAkDC17v9TgAOEEzjpbcE5rRcuJT7L4RAjJrAaHVdnpT6hAxGJ1pERLUf/GKt+HqXLmQfhWp9qLcAx9PYt2TAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xwGW4SXK6t1fmAMuoYAX18HVEgcsdTm7bNBwe5X4+4U=; b=Cc0iBmnFQm7WohC7zIVFeXwCulE2dBJgzxup2q7NcaVhD8AHZ9jIe+YmLc0B17TtVUey1FGHihL1jyuDaY15u+GNuHyFyaACqv9gTjs6NkcLQP1XrOB2aexixkG6WapwRv7jUlDTftiqCvMyDqfE56EPC11eO4/3oHTh2eKHE2tROXSh9NnfPxFFtoyXYwaAxIzffevNewZb215RKPba7pZbVgBFo5yBn/OFIetkN0CFL0VHK503tt9V11pBZuiEXL2FHyGC3ip2TRxg/R97Gpp6Id0X9tIBrIPpfCrQBmzLbX9T5wCVxk/WyKaBDIKrw1nrB0+S7QjnmfdOalEIpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xwGW4SXK6t1fmAMuoYAX18HVEgcsdTm7bNBwe5X4+4U=; b=hQj332Jb8/wlYuECeQpni+JKdAK1rtt3osaBXdeeJbSJgPZ3BGoV7uSnVYKstslEtj16vZ2l1uRN2EB/qZD6SAQbpLWQu5FzSTeG6X3Q5mzSkDjtkl4IK9IxxailVxBgDhgJrPq8KXS3lHofoJX2Lk+fP2yUikOLL/dvUOJnTbs= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by SA1PR10MB5868.namprd10.prod.outlook.com (2603:10b6:806:231::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.38; Fri, 6 Jun 2025 18:34:11 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8813.022; Fri, 6 Jun 2025 18:34:11 +0000 Date: Fri, 6 Jun 2025 19:34:09 +0100 From: Lorenzo Stoakes To: David Hildenbrand Cc: John Hubbard , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Jason Gunthorpe , Peter Xu Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs Message-ID: <34cafa8d-caf1-4257-8545-33aa55214c90@lucifer.local> References: <50ff9149-2824-4e57-8d74-d8d0c063c87e@lucifer.local> <1a7513cf-4a0a-4e58-b20d-31c1370b760f@lucifer.local> <72bb36f2-65b6-4785-af9d-5b1f8126fc78@lucifer.local> <2f866f12-2aa0-4456-b215-08ddc9b13b1e@redhat.com> <3dfbbd63-697d-42aa-8906-539d74df9123@nvidia.com> <44af8f5a-2d94-498b-a3e0-31f5dde74538@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44af8f5a-2d94-498b-a3e0-31f5dde74538@redhat.com> X-ClientProxiedBy: LNXP265CA0005.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::17) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|SA1PR10MB5868:EE_ X-MS-Office365-Filtering-Correlation-Id: 935dd941-8eaf-40f2-67f0-08dda528bafb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?1BeI7mXTJkJ0dtj8VT/DEjMdnYkYpVFid4w9qVQeW3R3rfaxC0FyNgy4jrvI?= =?us-ascii?Q?jj0oazbOLjasLQATad7YwXu2n3B+Sk/TGCBoLtzb8kE1wcYruZDKJeJN5NHm?= =?us-ascii?Q?5XN++vM52FLHcfNjX7FHrCM9G1ln33/gE+Zcn9JidHSd9L85DSoBZIHB6Zkb?= =?us-ascii?Q?yJVB9B1FbOo/gXKMd4epYgyMWKUfN7pf0BtulqZrxmPkq+JfQlXcv71aOdZH?= =?us-ascii?Q?noMNv2R+ijjaO/npobxMQfOcCUDY8cZWTVx4PfIYMhGrX6OxZ7am8I9ynU5Q?= =?us-ascii?Q?B12bJrTAo7jNJ7dFNqurRApZQgNYExz0yY2LvslkFW0mhdYTwRyM3MOLdtgB?= =?us-ascii?Q?1JMppcU0LTX5avd3rYzg1o8rqrmk6lKqz5hQJYW24DSsQ1WDM4injf/ppFLk?= =?us-ascii?Q?YVVknXqGxQYDDzCgKcsqMBFSI6+HzXhaDOlbZjCCiopfYDp4x4a13OB0Zi25?= =?us-ascii?Q?QBUCgsPbvwXWjCJwHQAQiTvTOKPtZzlLHCI9T7vh6syL6/G3yJyt52ABrqOH?= =?us-ascii?Q?j9Za3rbIdy0KbddEAivjg/70nU/AT2lCAssApZ5dUk3QGz5ckAgbv+hnc9B3?= =?us-ascii?Q?e33beQY2LU1qu6grBEgxUskf3+X4PLrqNliHnzTMyHCHuczI8gm84qWDZXDY?= =?us-ascii?Q?xUzpt8DCeh8pLgaqfPdtw/iYv1ZKdP50U1K4s2sLQmbynaoAm7SDQWvzUKSP?= =?us-ascii?Q?ec8ujTWorbwoGuRGvXNcfP5NkGDHNFzRgnGCTcuemGqgcxJjYqbCGV+Sy///?= =?us-ascii?Q?nhTkK53uzt9n+M7f1VXuKFQRGuT+04uowMab1FScgu6HQpm+jxrGlehGbJJh?= =?us-ascii?Q?J4sF9ArJABHSVgyxfyDzq5Lj2wleQurRoMQcQARC9d+e1gTWlgNfpo4kxlSC?= =?us-ascii?Q?C9RPY6cDGwmS/MpZ+NHnT8HBYY0EAZQ3Rp4FdWTIokA0FainQsq1TFMHbCAc?= =?us-ascii?Q?HuMocUM6ViTrSQNd4bH/AZeic6XAAr/n+9tQbJ5nmhIVEW753o4cXSSO0DUM?= =?us-ascii?Q?SKwDihG5kQmNQ5ACwkv7Vu7nS8+bZDe2rm4pzZhVp+KutaVWMZtW+KUa8nMG?= =?us-ascii?Q?sFkxfzUYX5WjyMeWPjksp9vEXD73VfUC5k9MaFY+8kfEDEkmhZhSlVa/27zh?= =?us-ascii?Q?F7ioX4xCHE4VoYxf09i8W1ZF6SC3sqoHNz8v3doG0RgooTKSu9esEajt7hWI?= =?us-ascii?Q?oyjEIDCE31kME4/hB39uK/AVD8kLMGj7yO6MQNJdaEoCd9zTYVTHuGHxzIcX?= =?us-ascii?Q?Svq9vjK8ySW3IWrC8T2AQf+G02Bg14qLQEEVtOFOFf5a+OnXhXdNGQrkbbi6?= =?us-ascii?Q?rNJZGiLgIaij5DgK01YgKw7kIUxqHDdUZre0u1izGUowcBaYJU92QBPW0X4P?= =?us-ascii?Q?+erMTyvGKk7hApsYGSd3R9BLDHJ+nm5xQos9o5un7sVeF3Chm3ekI/GfRVBs?= =?us-ascii?Q?VJVATb5IIUg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4AdWgCJWV+wigqADi1wiqeUoLLxjlxG/v1TXXyKNtIy7WPnHmwbWDcWl9B9q?= =?us-ascii?Q?fPiR/9WaocOuWYSTVu+o8vRsRwkINOtTiuXiK734WmCgtgAbG7MSkJdwr3sw?= =?us-ascii?Q?JthY/gFpiR2BSE2p3EmMpcueBqS2MwwfE7qZDB2xD0CpCUD0+wczt9jXzJlG?= =?us-ascii?Q?EGRRHPd5/WZVRVHpTn7tqNeySfA3udT0SlME/je4qHYd6GSWvLRwSrG8dXxX?= =?us-ascii?Q?IC6vDSXfAXhRm6Wqxe2j9F4D/1OeYlorHNjTX4Rm2+3IaITAThEqen/PLKX1?= =?us-ascii?Q?qB/sreShy+UYb0YljnFFS7zTDUaxctgrdmQleK7Bw0EKu0fLGmBsbhwwbdJZ?= =?us-ascii?Q?/Di0WboFlz9Bgf4bPjLBq93HLHF4SDc6tIxGvOQOO9WZ4+wVkUDmtwMGNMZO?= =?us-ascii?Q?UeILQyIgcfBboBIOqgEkBMTGqQ9pkMvDGYjwlUEKIehGMshlaLygPXsx3F6Q?= =?us-ascii?Q?NXxBWL5y7ThJn2rJz5HEx+eUqfFP2OCgxQudmNH5TOOAHPv9shr2+R6+XlTS?= =?us-ascii?Q?+VtZdkBXSg6EXftF6hz7u47anUewMpQKhX73mY/mnf01/SyAa2Abpx3MmNLm?= =?us-ascii?Q?3e7MyG5PMwRvzVq3rbpX3WGQcdWcX8jht2HZaNtCvOy6alv49IwO4NGHwFWo?= =?us-ascii?Q?7RQBFRue7Ibc1DNAeETRRuJv8N8FZrmfW2toJ/9kgxNUTibaGhu/dN7QBPOj?= =?us-ascii?Q?DkJHSGrQfFVquAD+Cb5g7MKShTYZ7OC0owwuBuV9ID95mdSSonYJkQ1qnOpw?= =?us-ascii?Q?V4GyAbGBTqjrM79wHmHrDbfghWfNPNf6Mv4LacgJJ6W1bZkhb6wcPyRX9g+z?= =?us-ascii?Q?H5MUtEOhMlUc302sdIyJrkSICB612x0OqVbXhxVP3aCJD7lEDmnA6DUlzyfn?= =?us-ascii?Q?zB/Atr5DDusytFoykGCghztB4YBc1ttPF0cFJ5rC3a0OEfgODhMYZDREu1QE?= =?us-ascii?Q?xaGT6luiO0sz+NTNOw7ZvyLTIo6xlKsdvsCyaS8IcxJx6AwFTJv6gmxBiGT0?= =?us-ascii?Q?f3oZSc0Fv4mUq3xVHooM8WQmJc8cdnA6H8mSOMdRdOau9TbWMfKOdHO+UvEW?= =?us-ascii?Q?+8+3Q7Dm9AcWjrgBQRglLhRTHEgX9B5zXscXwZG+V0EUix01dh1wxezYYddo?= =?us-ascii?Q?9INLJ5E6+lOJteB7+lL6jw0Djp2CJQPhDdidgCvxoJSpwArAAGtlFpg46ptX?= =?us-ascii?Q?s8M+R1wRwhNv80phkL0mHr12/x5xpxNQ1g1HgdwwJRVsJvDcHlaYM3S5La18?= =?us-ascii?Q?UDpV7IpRUNA4Ls7L5J8KWwuAA+l/DDOasvpYfRS8DN71hmV3I47IWTvtF7ZR?= =?us-ascii?Q?bGCxyTp+5tc7sq8fc4Cos6CGluuqjiUBuj/WXF2zFSkzYt+VitFzaKY2voG6?= =?us-ascii?Q?0kDSJS8W6IhJ2xzoxT4swnZJQM36Tr5iU8WpNygujjIxZamhSigQvVHgAMpa?= =?us-ascii?Q?rsNseUhYf0WcQDn9/ifGXrgf32q4+AwImwq+KGsk0b5Kjjo55pMh9YgCOvFR?= =?us-ascii?Q?apQ0EwSWQDvQxAcLSmJ5j+1rCkuby4EAzIHbdBgyz1zZsiWAyISJLZYpgB1d?= =?us-ascii?Q?4ESiAvvbTTZevHbi8IMth6Kp8obFVTpia1z7wm/ApSM6KwzNEdVHdKwL0fIW?= =?us-ascii?Q?kQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2cL7/20JLdRzfRBIXdHfC9rFuHsKqdOU6j/3DDJHGanxRvx6sAKGmGxBypX9X5EsEvktCzWdXidHGLyJSfqw1aeoyeH+exnMoAR+m3lkEAN/koNlZpyIjt15kWDlUnfNgOFS6ZO1UbFnO5VIFzYGZplLq5HQtEOAiFQLPOGaVa7ZBwT48+qHEUxpEEv5ySD/yP7i7oGz5MO1slFnNnG++CzI7D7ZTDByfl5hhfmLqEAT/UZzg8d/+2K0DW5720zCrROCnFkyfNKnvRlmGMxSWrU1Np/Wwc+RbtUfYkwsvqGdd34SYUdtRIcxKD/aIk1E5bbH0CKwZO2goqK7dIEd1I8jJRakdJH3fX5CqA9hJMAlVVb7QM84InGSVNNyh/WADAUX40C4OK9kBv/uoVklGdBtbAX+g6r1uJezabLAMaZd6MISDQ+uLAcOs3eOSbNeNUrG/XNSaefLWsgiWrMRNzeJAkqqOiGFTUCcRh7QRQDe4Svt8lWLRBWuYFY58CpchblKMNQ0XI2zGNqZp/gcaXPRKVPsmITtI4mLNxgUAUuTZPJNtmi9iDEMK3LbPIJ2LYOosGfFuqLGpk3/uX+eU9RHLxwf2v97Dw+74+J9zPE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 935dd941-8eaf-40f2-67f0-08dda528bafb X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2025 18:34:11.1514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cLzE8KOIZcNKfOrUTmRG4Zk/iKwE6LvlubgQOuzBnmJFeo1fMAyenjbGwRkfVHi0Qcu/D6E7E2YVnRIBR4eUQ/5hiBBAdVsCHFlc7BdQTfk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5868 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-06_07,2025-06-05_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxscore=0 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506060160 X-Proofpoint-GUID: ebyIDUIJ_nPtZo01qK-L-ktoGsXiiMJp X-Proofpoint-ORIG-GUID: ebyIDUIJ_nPtZo01qK-L-ktoGsXiiMJp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA2MDE2MCBTYWx0ZWRfXxvbz8WEpkIns qyu7Hj34LeHLODyhJfnBfZcINQUvHA9hl7ZYaAUn0zILOeA4KsTc2GpvDGPkuZRtOTArTaZbEKa Kyyi6YuI11r/pKDnKNuBcFAvn5MYuBu+yMqTSwjAZhh4QK1jyEQJuzN1eUhDG4EKINNiNpLSsiN AZEGKrQPmvIad7TWQJixlzjy9JUKAuKcZzHLtne7Wms9cGodSU0rf4rnhrVt/NuzguWEXXB9635 UJ5PYlMWaS0+behbongwmdnvULY4/rgwc3w/IgVs5uUksPMYeD2aDxI/WfMlxeNV3L0SFQclSBj ArnKkAwxGKAyO/30OCsNr+D49S/jPoe1Obs8Ctnhu9vzwWiMwMStvoOHv6FlFr0eOVH05zGi22y iRC4e64crBUxrKkSM8+dxadMWKoRP41trhS0X3jdQ8QbriTK+rusnCFuwMU/+wllb/O9wZMb X-Authority-Analysis: v=2.4 cv=QI1oRhLL c=1 sm=1 tr=0 ts=684334aa b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=GoEa3M9JfhUA:10 a=-pN6YscyihrUBHfe6UYA:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:13207 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 17B984000C X-Stat-Signature: kj5cb8cbfjr8x33je6rzptai6cbzsk9b X-Rspam-User: X-HE-Tag: 1749234862-556695 X-HE-Meta: U2FsdGVkX18nAiQYwk3Ecq4MNS9ItlfUtnTkj7UFYCLMtbFmlXJtBl3oGcXqsMORsgMX/wmvQjXsF54LVP+NVJMeQcI0ddP/3johMY2nJXMGKjVcrh7B8F3azPFFwOcqQPf1Woy7cmIBW9xkgXFO3zrlFxiEwDpmukrPlig62DfeJbQ7gphDETjN4wG8QcMXyl3wcoIQld7bjTQMfwwZTiaeEFb608VKfU6RloGEiE2qQNyV3CbQhjKGeu22+FsYQHAO8PPk9uhol5sGw/NhSw8xhAAqaLmg+pOvfUiTCkUzqMAbHku3AVFoD5hK4xUWuD4Vkhp8dNJ0B5qbNX/VFzPPwBJ50NJCRexDXtIy5136XyVoY9l3X0kfPlmKYt+cF7ftHgTvXFXDKu8hwZk3WcO9Sz5HtsKcZ0WEKqGpvEjTXfdWav1xAA6ZG/4f7mjJI+wwc8aeK1WAVf8a4Gf+ZJ8V8jocHh40R3EjKAtpuw/zeifdkpOVx9WGDkHP76JMYsebAf2mYqETuTDD52GZMK4qy3g6Bg4a9YHb9/WvVr8mBA76cz6mxk6VZr8qp2Pc5XF03Y6uS8QWX+2EUTjyA5JH08yszal3RpezxbyyR/FwKQJ4yTNANgOe+z3sYseBhwcuW7AjIi7NR5371hsdc115ZoIa1Tkb3fVqsHQgV4D1rJnXxqVwSEFEEGi6bztKO3gfwolu23VW84WTP9d0R6H2ruuKq90L0qpPw/OLm+pmeeu9mLLMXn7A9Oyga1oy/vq7wHTyd/m3RWwD1Cx1NVq8wVZme4Fzh4SnII50JJtphlKNNLLjiUB1gWVweojy2kgd/CSw169lTiHjMzaCp8sMuBgRy/hM3zZ/pUEE2zUP6gdYdYRCsf2I6Q1rtkQpoDtgVdplTPaHfG6Cu+O5SIGT/KkP6ZhUevagDMu3YZRiqv+jultwjMIHtFMrq72Wd/dkcmuzb74vX5ouBvJ 1Tb8T3ST VeiHE70ToQjqzYEoVX/n170g/G02GSjTgZugnAF10fo/9th2wYv8Rt/WMpMeD9S4rgBcrvEEmTSP0cbbv6OHA0nF5Oiw5R8fKqcrRfsvsU0GuvxgnSk5nT03bWMe7j3Dc5xVrLe1Yj8Wzro5bAPK8nGtdwGcer496NhodYrlucHSE9ylq1PIWfz8aMaZR17UOp9LeN+nveduBMw2viLLg4vr3JfppOzmBJGlTRPLJoAWkmhlr9IGi/Pn6CMkGN0ZfBaKRVHKa8oPWFBoowYMBIWxYGm4iB2KjnPRflgCGrV9MoVzCDHiWO684R6keWFOGSTUwU5mi5qOYceHwL/VHJu8TQ70MDqMU5ho8swmeDa+HKNDoq4vzQq8nUTjhMjJntrD6phL5poNwtqN4F+nMc1sQe0gzfWQsSuBGkUZEZzEbAsDuvf+P5FcbD3BErrNJ2iBuv2SsfFSe3OzIJ7DoZK3BbOPQu0hqqXwpe1kWKu27wbYqWA60H7qzbEuysum58wf/J9qaZjzEBSEsaMHMnwfYgzv+1eLJmSJp+VBRhrhY+lEaZens+GapV5y3kpEeLCSMKDEdk8Xrc62iGGuWP0Gd+wn34YixKpnLmNR4KROR4QDQMR2OIiDzyV2ViuSmLS0QKY4RB3QW6OvtXW6pJAx9dBzhYn+YyFLuwcFx/vXPWsztGpQD2wRaZ5XXgECIHngKznBMupxUcMIuUNkLNtHrwvG7nAkNYgBi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Overall, Since David and I are somewhat indifferent on this point and you would very much prefer a VM_WARN_ON() - when I drop the churnageddon I'll go with VM_WARN_ON() :) And we can obvious adjust case-by-case after that if needed (probably none of these ever trigger tbh). I think the general feeling in the room re: VM_BUG_ON() is 'kill it with fire I don't care how' :P And you know, it's understandable... On Fri, Jun 06, 2025 at 08:23:25PM +0200, David Hildenbrand wrote: > On 06.06.25 20:21, John Hubbard wrote: > > > > > > On 6/6/25 11:15 AM, David Hildenbrand wrote: > > > On 06.06.25 20:06, Lorenzo Stoakes wrote: > > > > On Fri, Jun 06, 2025 at 10:57:44AM -0700, John Hubbard wrote: > > > > > On 6/6/25 4:04 AM, Lorenzo Stoakes wrote: > > > > > > On Fri, Jun 06, 2025 at 12:28:28PM +0200, David Hildenbrand wrote: > > > > > > > On 06.06.25 12:19, Lorenzo Stoakes wrote: > > > > > > > > On Fri, Jun 06, 2025 at 12:13:27PM +0200, Michal Hocko wrote: > > > > > > > > > On Fri 06-06-25 11:01:18, David Hildenbrand wrote: > > > > > > > > > > On 06.06.25 10:31, Michal Hocko wrote: > > > > > > > > > [...] > > > > > > So to me the only assessment needed is 'do we want to warn on this or not?'. > > > > > > > > > > > > And as you say, really WARN_ON_ONCE() seems appropriate, because nearly always > > > > > > we will get flooded with useless information. > > > > > > > > > > > > > > > > As yet another victim of such WARN_ON() floods at times, I've followed > > > > > this thread with great interest. And after reflecting on it a bit, I believe > > > > > that, surprisingly enough, WARN_ON() is a better replacement for VM_BUG_ON() > > > > > than WARN_ON_ONCE(), because: > > > > > > > > Right, these shouldn't be happening _at all_. > > > > > I'm easy on this point, I'd say in that case VM_WARN_ON() is the most > > > > _conservative_ approach, since these are things that must not happen, and > > > > so it's not unreasonable to fail to repress repetitions of the 'impossible' > > > > :) > > > > > > > > But I get the general point about ...WARN_ON_ONCE() avoiding floods. > > > > > > > > David, what do you think? > > > > > > Well, in this patch here I deliberately want _ONCE for the unpin sanity > > > checks. Because if they start happening (IOW, now after 5 years observed > > > for the first time?) I *absolutely don't* want to get flooded and > > > *really* figure out what is going on by seeing what else failed. > > > > > > And crashing on VM_BUG_ON() and not observing anything else was also not > > > particularly helpful :) > > > > > > Because ... they shouldn't be happening ... > > > > > > (well, it goes back to my initial point about requiring individual > > > decisions etc ...) > > > > > > Not sure what's best now in the general case, in the end I don't care > > > that much. > > > > > > Roll a dice? ;) > > > > One last data point: I've often logged onto systems that were running > > long enough that the dmesg had long since rolled over. And this makes > > the WARN_ON_ONCE() items disappear. > > I think what would be *really* helpful would be quick access to the very > first warning that triggered. At least that's what I usually dig for ... :) YES! I wonder if there's some systemd thingy that does this somehow... > > -- > Cheers, > > David / dhildenb >