From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7215C5B552 for ; Fri, 30 May 2025 09:31:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 454A66B0088; Fri, 30 May 2025 05:31:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42C8B6B00A4; Fri, 30 May 2025 05:31:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31B7B6B00A5; Fri, 30 May 2025 05:31:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 167B96B0088 for ; Fri, 30 May 2025 05:31:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BD47F862ED for ; Fri, 30 May 2025 09:31:02 +0000 (UTC) X-FDA: 83499055164.23.F134613 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf09.hostedemail.com (Postfix) with ESMTP id C67AE140006 for ; Fri, 30 May 2025 09:31:00 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=kNHw3vYz; spf=pass (imf09.hostedemail.com: domain of libo.gcs85@bytedance.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=libo.gcs85@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748597460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kZkk3bjH1sfOYp+VjBWd01Gh2LTXey//pWYFXMUcbnQ=; b=XOiBATIlmf6LztlFbJZnjB4O7q2ZsYdHtpDy4muY4jchV9vsjW7/yPfn9rdO1unu4DBjwH qT1B5CRU4chJuHtG/54sM+T+/RNQu6pZbdvpfdSBk+ZYxNXBu7n9K9moMSadhh3VqP6PKj jV6sfHu4/4RvvOueNZwjo3fI+DcKWzs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=kNHw3vYz; spf=pass (imf09.hostedemail.com: domain of libo.gcs85@bytedance.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=libo.gcs85@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748597460; a=rsa-sha256; cv=none; b=eZe9Yw9ADLQrhgsG9VGAO/4RzagnT0xefwjpeLsSidM3rrXkS+wHL+1AkAOhoR47AXV0IR lLkGi3atXxQ5DFF5ADyVrpR/3IPg0I2QEe0eTv8VyQBjRwmMe5XnZiOOkiioI9p1lOfFac g2TQ9ImmybvtaU/QmLWJvzG8ZSviy0c= Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-b2c4476d381so1639177a12.0 for ; Fri, 30 May 2025 02:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1748597460; x=1749202260; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kZkk3bjH1sfOYp+VjBWd01Gh2LTXey//pWYFXMUcbnQ=; b=kNHw3vYzq0Z2DhzyW62tnt2HPlr2kPRiWui8ECeGlydcfo18V4lsgqmRQ7XaAR6wce fqIqFF3NWnjajNEZIeyv8zN8HjUXDhILXi12RFDK+BBK7jeF1iFpDIrlJnZJAsHopZHz 4gfkcj4WcuFry+qMlmtSLeGItFTYaRT887f66Vg5abrSYbHjuNfWyLbDBgTOjuZSTpDq IJIPy6CNz17zPvsYkfgpwqN1De+tZgb0E35DPiQXcNDLAtbY9rEu6Jtb9PTQX8mGT35t WS2MPApuzKRUXapxcqE/Ny+izcB8HrCAB9D7UZxSRTPqzbKTGAkQYNzUNhAbl1VJNmg5 lC+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748597460; x=1749202260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kZkk3bjH1sfOYp+VjBWd01Gh2LTXey//pWYFXMUcbnQ=; b=M91b87xZGvCDOPNo2IgNgho3JE3cuQ2DyrzvE3FknON2dFN1KIgy/stlP9k0bq2v8A ilk9RzgeJoGB4LLVpNMRS7YrYr5AScqJ93d1OsYAElj2L9DCHS7p4womhx+MqxJ8TGDS zYVIYJ6R/sth112KyX34ZYpTercCnb54ycfGjDcsVyK772NJ+ZqBef9kB02ywpL2dFEP 8qPhNqtP3PgKp60F0bhKrpdN7sWwoe92VnzOKvGiO4/jK0JEh/ogWh7ujBr32IxaZo+t VDXPk4PiFz2a7xFTcZdOQQROtXBH4XkrgU8B/L/ujWKdQeJVN0bdqeTp53HorRGj2Ox5 xjXQ== X-Forwarded-Encrypted: i=1; AJvYcCU/sTuFJXhDfvsCZB9VyAiqSEe6f3Pg67iua1XzY8PgEgXt05kLk3AyJxsh8LcNopdvxDivuDkzPg==@kvack.org X-Gm-Message-State: AOJu0YyVlDkN1ekG6X9zAiuwc6jCLvKtLinC75mlsHYDBBllhd2wxf98 h0cV60Ok5uJTWPQVE73LM5JT/zHV/xRd42pKXpaK59dwCsNfwqJ4pcebsINkR0U50j0= X-Gm-Gg: ASbGncva7otusd4j5JlcAFlLZxNmeP46OtOo57cgE29O9Mfrv23ulFqQmaAPCdhzJpE XWfmJNiM22YTVYgnIxwEfMhK4K5rv9xZcDRKzgu6vIIYxcUcGCvZw9TLc7esKKz4s6/5Vx4kVwr d3qFbRKNHtGB168Lg3ERow+25nxrbAAd1zeTDBZotMq7K5QAIu1thbCbBmnRoeEcm3ijzD3y7Ny BVBsvLQoa/EA2bGrFv/HGhCKM8C7B23ve+k0vJYr1pEmNjJCgB4J9/fwX+RTqtzMs67uBFLv0uw xsYL6j8PS833hS4Tam0IWqAUFBUsca9P3hmFaWTP+SikE8oBM+UUjh63xAHCtbf0+Jjq3pxHEcJ e2w3U2LAPLpjDU+DRtYC6rpyo7IOSSLc= X-Google-Smtp-Source: AGHT+IEDp+vpzbXXEsQMocz8uu8WDoupHL7dKOSkVefmCskmswDnpl1KI6oBSxmQepUxjo/3kPsGsg== X-Received: by 2002:a17:90b:28c8:b0:30e:e9f1:8447 with SMTP id 98e67ed59e1d1-31214e11c6cmr9475340a91.4.1748597459572; Fri, 30 May 2025 02:30:59 -0700 (PDT) Received: from FQ627FTG20.bytedance.net ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e29f7b8sm838724a91.2.2025.05.30.02.30.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 30 May 2025 02:30:59 -0700 (PDT) From: Bo Li To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org, kees@kernel.org, akpm@linux-foundation.org, david@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, peterz@infradead.org Cc: dietmar.eggemann@arm.com, hpa@zytor.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, jannh@google.com, pfalcato@suse.de, riel@surriel.com, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, yinhongbo@bytedance.com, dengliang.1214@bytedance.com, xieyongji@bytedance.com, chaiwen.cc@bytedance.com, songmuchun@bytedance.com, yuanzhu@bytedance.com, chengguozhu@bytedance.com, sunjiadong.lff@bytedance.com, Bo Li Subject: [RFC v2 10/35] RPAL: allow service enable/disable Date: Fri, 30 May 2025 17:27:38 +0800 Message-Id: <34c12765bcf534c5afedd10ee3e763695c6a045d.1748594840.git.libo.gcs85@bytedance.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C67AE140006 X-Stat-Signature: dpsxkd6osj3ob8qgz6dtirzbuofztsmq X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748597460-40680 X-HE-Meta: U2FsdGVkX1/VOHfY4QQSjtb0+f1P6uapJotW4SjK3XPL9QthqdB1oGOJR8ihlB7QxIMUTWZokGSgFPssRrjGsaXzmwoEpPjb4KDCCDBFWobmNkFJQZp4zVc4eqrNOynRHnRNtHluVgMhFxl4A50DxHdAoAUr1Hjcyk7isK036cdQ7ABdZzZrUAkTykUpYaj1WkwUIj6syUsLWo+kPP0sxK228Coi7nbZoz5RH5GfoXVWzOLTa3Hc2VXk3pmFyti9Fimsj5G5OHviC8QOInOXPnh4Kq556R+Y9+YCZza3Y7vXE+OWNU+QgIeqWihOfCdBXhNxKKdclFO+Tr9U1vUmNYn4LBWgWZj+dg6kP4VLmatX8k7tRGuFzqhmCdiMEJrX7DqgWKGNuMNPAJEaFImCIxf1CwWcMxgFqVou1Z2NpKeBnqF0LP1SH95wpSicZD0ij5QtZWQhB0H3UjpdqhOc+O44bEC7qIcxonGA54rRZQeh8jy57dYZlC/AAbVfFcNkwqy7PeZ358WIGDjmpZTaPlY1CA/YXJaWA9xQ+dbmBATK6Ow/NdhpZsT33ZSYS/ScTaqImqZjw7u6h2fCGbRrX5Csrddl78Sy2hcGdTlhVltzbwfVTNkr5D+Gh5JGWbMuQC28dTYkz18q7oXJCQ24Ul9Afg1ej8N8kuOkUdSDMhhJfNIoCfGPbdLqov0OmZQeJJhsi4L/m0LGmk1JPtm0enlshHpxHUihh9c4BRxkRjnVZH5ZXXy71I6i3Fw1CCpNI5cFUwE2BWbla+sXXJAuZyftFap7dEzAg83tYN4DLvAENQE+lHUsIjA0LoRq+sQ0cdjtVa+emhxJkRkLINNSuI3XH+CJcMGA/JJ+1nU8nLeI/mwlb64fphclXflsEWvR19MdqreaKkerJ+AYTucC/MJW5dEdGpXetYKYG1KykVGr1NBgQyDxBJwXg3Z94Hg+E46OOiUlv29W7ju7ST8 zOF5+sUs 9Hfl+2rDOdluXqaJV1HoT+haCIdBh2JyCv2fK4JW5Iz0xV0xGZB9+7LdXbRs1331cAnspS3cCgPu+PJQqbutsoqSaf3DTiC1oKWBul3e07jG9e6MvTtgnpEAMo2n4teIF08adFwzMLjc/KE/6p/zLF5kfxAuIJdBbEe5Ir+0l2Nql+vYgOBdZib9+tR1U/Zjub61hlCz6n4aubQJwISt3hpW1N8LBhScN46P5CyQclAldj/srGraj4TdjYTukAtfLw3DayxiHCn7JqF5+ZJr9hZZRvFGVEID5eLKo8N77m3QB/bcNfoCSB18JNKX4B71ncOLKYuXs+UpvonQdjgSd3utSkJSVR6iT7KWs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since RPAL involves communication between services, and services require certain preparations (e.g., registering senders/receivers) before communication, the kernel needs to sense whether a service is ready to perform RPAL call-related operations. This patch adds two interfaces: rpal_enable_service() and rpal_disable_service(). rpal_enable_service() passes necessary information to the kernel and marks the service as enabled. RPAL only permits communication between services in the enabled state. rpal_disable_service() clears the service's enabled state, thereby prohibiting communication between the service and others via RPAL. Signed-off-by: Bo Li --- arch/x86/rpal/internal.h | 2 ++ arch/x86/rpal/proc.c | 6 +++++ arch/x86/rpal/service.c | 50 ++++++++++++++++++++++++++++++++++++++++ include/linux/rpal.h | 18 +++++++++++++++ 4 files changed, 76 insertions(+) diff --git a/arch/x86/rpal/internal.h b/arch/x86/rpal/internal.h index 65f2cf4baf8f..769d3bbe5a6b 100644 --- a/arch/x86/rpal/internal.h +++ b/arch/x86/rpal/internal.h @@ -17,6 +17,8 @@ extern bool rpal_inited; /* service.c */ int __init rpal_service_init(void); void __init rpal_service_exit(void); +int rpal_enable_service(unsigned long arg); +int rpal_disable_service(void); /* mm.c */ static inline struct rpal_shared_page * diff --git a/arch/x86/rpal/proc.c b/arch/x86/rpal/proc.c index 8a1e4a8a2271..acd814f31649 100644 --- a/arch/x86/rpal/proc.c +++ b/arch/x86/rpal/proc.c @@ -63,6 +63,12 @@ static long rpal_ioctl(struct file *file, unsigned int cmd, unsigned long arg) case RPAL_IOCTL_UNREGISTER_RECEIVER: ret = rpal_unregister_receiver(); break; + case RPAL_IOCTL_ENABLE_SERVICE: + ret = rpal_enable_service(arg); + break; + case RPAL_IOCTL_DISABLE_SERVICE: + ret = rpal_disable_service(); + break; default: return -EINVAL; } diff --git a/arch/x86/rpal/service.c b/arch/x86/rpal/service.c index 42fb719dbb2a..8a7b679bc28b 100644 --- a/arch/x86/rpal/service.c +++ b/arch/x86/rpal/service.c @@ -177,6 +177,7 @@ struct rpal_service *rpal_register_service(void) rs->nr_shared_pages = 0; INIT_LIST_HEAD(&rs->shared_pages); atomic_set(&rs->thread_cnt, 0); + rs->enabled = false; rs->bad_service = false; rs->base = calculate_base_address(rs->id); @@ -228,6 +229,52 @@ void rpal_unregister_service(struct rpal_service *rs) rpal_put_service(rs); } +int rpal_enable_service(unsigned long arg) +{ + struct rpal_service *cur = rpal_current_service(); + struct rpal_service_metadata rsm; + int ret = 0; + + if (cur->bad_service) { + ret = -EINVAL; + goto out; + } + + ret = copy_from_user(&rsm, (void __user *)arg, sizeof(rsm)); + if (ret) { + ret = -EFAULT; + goto out; + } + + mutex_lock(&cur->mutex); + if (!cur->enabled) { + cur->rsm = rsm; + cur->enabled = true; + } + mutex_unlock(&cur->mutex); + +out: + return ret; +} + +int rpal_disable_service(void) +{ + struct rpal_service *cur = rpal_current_service(); + int ret = 0; + + mutex_lock(&cur->mutex); + if (cur->enabled) { + cur->enabled = false; + } else { + ret = -EINVAL; + goto unlock_mutex; + } + +unlock_mutex: + mutex_unlock(&cur->mutex); + return ret; +} + void copy_rpal(struct task_struct *p) { struct rpal_service *cur = rpal_current_service(); @@ -244,6 +291,9 @@ void exit_rpal(bool group_dead) exit_rpal_thread(); + if (group_dead) + rpal_disable_service(); + current->rpal_rs = NULL; rpal_put_service(rs); diff --git a/include/linux/rpal.h b/include/linux/rpal.h index c33425e896af..2e5010602177 100644 --- a/include/linux/rpal.h +++ b/include/linux/rpal.h @@ -84,6 +84,14 @@ enum rpal_task_flag_bits { RPAL_RECEIVER_BIT, }; +/* + * user_meta will be sent to other service when requested. + */ +struct rpal_service_metadata { + unsigned long version; + void __user *user_meta; +}; + /* * Each RPAL process (a.k.a RPAL service) should have a pointer to * struct rpal_service in all its tasks' task_struct. @@ -125,6 +133,10 @@ struct rpal_service { /* sender/receiver thread count */ atomic_t thread_cnt; + /* service metadata */ + bool enabled; + struct rpal_service_metadata rsm; + /* delayed service put work */ struct delayed_work delayed_put_work; @@ -206,6 +218,8 @@ enum rpal_command_type { RPAL_CMD_UNREGISTER_SENDER, RPAL_CMD_REGISTER_RECEIVER, RPAL_CMD_UNREGISTER_RECEIVER, + RPAL_CMD_ENABLE_SERVICE, + RPAL_CMD_DISABLE_SERVICE, RPAL_NR_CMD, }; @@ -226,6 +240,10 @@ enum rpal_command_type { _IOWR(RPAL_IOCTL_MAGIC, RPAL_CMD_REGISTER_RECEIVER, unsigned long) #define RPAL_IOCTL_UNREGISTER_RECEIVER \ _IO(RPAL_IOCTL_MAGIC, RPAL_CMD_UNREGISTER_RECEIVER) +#define RPAL_IOCTL_ENABLE_SERVICE \ + _IOWR(RPAL_IOCTL_MAGIC, RPAL_CMD_ENABLE_SERVICE, unsigned long) +#define RPAL_IOCTL_DISABLE_SERVICE \ + _IO(RPAL_IOCTL_MAGIC, RPAL_CMD_DISABLE_SERVICE) /** * @brief get new reference to a rpal service, a corresponding -- 2.20.1