From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B1BC77B72 for ; Mon, 17 Apr 2023 10:33:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 386B68E0003; Mon, 17 Apr 2023 06:33:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3368C8E0001; Mon, 17 Apr 2023 06:33:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 225788E0003; Mon, 17 Apr 2023 06:33:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 136738E0001 for ; Mon, 17 Apr 2023 06:33:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D5D6E1A04A7 for ; Mon, 17 Apr 2023 10:33:10 +0000 (UTC) X-FDA: 80690520540.18.8B6972C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id 2254F180016 for ; Mon, 17 Apr 2023 10:33:08 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf16.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681727589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zb5mHpzhkkDeX3c8TPRg+Y0x1SsSHBRztAO4D01hsh8=; b=cAXKzRpH/CI319v7WxTCLJSzSqwf6/1smewEwKhnHaX0EYJTIMkkknP4f2Vteox+ulmClj 4hHuJ5BzXWiENApE7LIZuzy370BpomvNDav2OP+9AJuNAY+634nqhuoECgzINvhuVsKtA0 MGcKuyuuRPAuA6JAVvSfYwgtH63IlwY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf16.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681727589; a=rsa-sha256; cv=none; b=ypXncyPu/J178C7rVeFaLCIsuHjZHL/UEA4/NYR7IjyBwtt/HwvwbGq0ubx+bUHNavthYM Oky0A5+86+mQurHpGcUnRV3NFUZBSZ22n+PhomzebAhXxxXHVWf+EwSi4J9lucjHQVLi8B URFaOSD6XZkakpy35FUddRUPsKnwLck= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EAF991063; Mon, 17 Apr 2023 03:33:52 -0700 (PDT) Received: from [10.57.68.227] (unknown [10.57.68.227]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A3CED3F5A1; Mon, 17 Apr 2023 03:33:07 -0700 (PDT) Message-ID: <34bf85ce-681b-ebb0-de31-7afc7aa9c5b2@arm.com> Date: Mon, 17 Apr 2023 11:33:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 0/2] Reduce lock contention related with large folio Content-Language: en-US To: Yin Fengwei , linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, yuzhao@google.com References: <20230417075643.3287513-1-fengwei.yin@intel.com> From: Ryan Roberts In-Reply-To: <20230417075643.3287513-1-fengwei.yin@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2254F180016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: f45q8t7esreezixzn38j74gnz981odwk X-HE-Tag: 1681727588-9637 X-HE-Meta: U2FsdGVkX1+aV/ySpXSw6BKJLP8+FXtxiT+0CdfOAtHsC8PC86gAboS8Xzvy/OYFFMdR+haoZD42yvgaaI/jnP6muIYj6xnofmwGGOAvGNoCI/AQ82mV53yNidwy4JzSFq0aJ9gysSsZYf2DKvpd6eV3pj7ZHdsL4D4j8ToUwRPlcob+1RDE/QQ7J7CwtKYl9RgQvPps950F50J9QeUzWtxo+vciUEMUKuoel7uraDt1UKuo1r6HbrBbKvnSk2b37iX/VOYGhkC888jix7xKMABtN57QtwSZgB/qQPteanKKK39AG8P5yHk25B2Y8RiiH/Vf45P+mBYGf8pS9mcSEInNnPpwXQrOwFdOzBZbioPWLbylZsDoKacN1zpzbITmyRRbNsVmTBcV9rrHDBAqsnnphivlAhpOq6BcGPcbubY5tRyda4OZmK23qAnp/k2Jh1X81ulmJ7fhAfhI+bPHx17LBthSR9qcVcCz3Pk90RUrEMPgk9ouVvPzun3Q7PQ3WL8HJ7nuK1jD+HXLme2qqXbaEehmekkYCo1NW/UljpfH0X3pY1gibxqwHsF7rDIE/5fryxj7+Tr5BjAzLOn1v+8KR/Pn8hN7k+zZIbrrM2slmbBKz1c8A3TDPCM5ql4SBi7hwJXeYUG/TK22NZC7bgkCuvPKPD1KLqWyLLDJahKi5OE5zFWcKTZA8eJPhu4nQX0EIhdvgDIdGKInD6MOuiOJ7iuggeyuZIXWMsinV5jy5vbBBJ3Dh/vIDsSa45OgpA50O6MkbsPf/SeLwz17KFe4FifGO0q8+vb9nviNb940sOVNo27wmEcBWDRVC/FXJ+xHce/p4/wV8PwRRvbIgPoDdQRajSnfrdN0Rpgd9MfR95smkTfmtqHVgNU+kV1UWdM7Pq6itHLTqViACqdutC9Qy0n/FKq5sYjRyjtdhA5Bm5X1FWygofGf9dDjdnbkpil6FyCpy9mXrtkjw26 8lcJekM4 aBxZs0tLMMlBpTgSwhkpaBG47yWh8Q9Hp3c7S2gpEn0LnBa4dAS7qryZ3j40ERraLyKzSxIOiGLS8f5aERN8KLD0TDHUhUHlYll2sd/MkqXshytCWtQZXyya43VAfLpeQm3bOocOrHl7Pj+yWBFUemLB3iulzS8BbV2G/KuI6BLSD6ktEGweVxsYzcLblBlNBYBA0RBvJDwKSBGETfzHkdgXmn/3V94MTmyWU5cwVxtd0XOz+9hk9FpKFbw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17/04/2023 08:56, Yin Fengwei wrote: > Ryan tried to enable the large folio for anonymous mapping [1]. > > Unlike large folio for page cache which doesn't trigger frequent page > allocation/free, large folio for anonymous mapping is allocated/freeed > more frequently. So large folio for anonymous mapping exposes some lock > contention. > > Ryan mentioned the deferred queue lock in [1]. We also met other two > lock contention: lru lock and zone lock. > > This series tries to mitigate the deferred queue lock and reduce lru > lock in some level. > > The patch1 tries to reduce deferred queue lock by not acquiring queue > lock when check whether the folio is in deferred list or not. Test > page fault1 of will-it-scale showed 60% deferred queue lock contention > reduction. > > The patch2 tries to reduce lru lock by allowing batched add large folio > to lru list. Test page fault1 of will-it-scale showed 20% lru lock > contention reduction. > > The zone lock contention happens on large folio free path and related > with commit f26b3fa04611 "mm/page_alloc: limit number of high-order > pages on PCP during bulk free" and will not be address by this series. I applied this series on top of mine and did some quick perf tests. See https://lore.kernel.org/linux-mm/d9987135-3a8a-e22c-13f9-506d3249332b@arm.com/. The change is certainly reducing time spent in the kernel, but there are other problems I'll need to investigate. So: Tested-by: Ryan Roberts Thanks, Ryan > > > [1] > https://lore.kernel.org/linux-mm/20230414130303.2345383-1-ryan.roberts@arm.com/ > > Yin Fengwei (2): > THP: avoid lock when check whether THP is in deferred list > lru: allow large batched add large folio to lru list > > include/linux/pagevec.h | 19 +++++++++++++++++-- > mm/huge_memory.c | 19 ++++++++++++++++--- > mm/swap.c | 3 +-- > 3 files changed, 34 insertions(+), 7 deletions(-) >