From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9ECCC35669 for ; Sat, 22 Feb 2020 01:26:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A89A20722 for ; Sat, 22 Feb 2020 01:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Gk595ore" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A89A20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1CE896B0003; Fri, 21 Feb 2020 20:26:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17F3D6B0006; Fri, 21 Feb 2020 20:26:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06D5C6B0007; Fri, 21 Feb 2020 20:26:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id E251A6B0003 for ; Fri, 21 Feb 2020 20:26:26 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9A245180AD80F for ; Sat, 22 Feb 2020 01:26:26 +0000 (UTC) X-FDA: 76516022772.02.kite29_7264ebd732f2e X-HE-Tag: kite29_7264ebd732f2e X-Filterd-Recvd-Size: 6295 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Sat, 22 Feb 2020 01:26:25 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id i19so2206059pfa.2 for ; Fri, 21 Feb 2020 17:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=6NCpMe5fIeuOHKYiRiYoRQz9QV3Z5rhmYqEHZbQFMLE=; b=Gk595oreW2jv6TBfOF4kvyNfqD0vLuaOfKbfM8VvXToBDCiQKGTwjfwkn0GOf5woyO BfuYfJEKjgO+/ymemkGXE2aeC67WifJ8WdeoCrIU5XYAzRrsCYO2v20p5gAViftJnJME +NLFMQVHaM/uG1xUDdOIW0WFs7+piYHbmJwFU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=6NCpMe5fIeuOHKYiRiYoRQz9QV3Z5rhmYqEHZbQFMLE=; b=J3AkXDROsiKomhpDGCFNC1sS9nmEoEdNuFijPIXZLfsw3mOIgbYskPPCqvjYxVLIbs T3kZ5LsWjO3CymzyMFkTnFJEH6AxBy5pJqIhAOeDTWtjE4npIhxaXbUUKT5XQ/YMvzbt 8rWMy5opDQ8MYY55ZB6XbCQowCXnrpk7I5MZp5K0pH8tOr2hhjRbhSvcXwUUTyZZRbbP V9fDi914eIUl0zcs9ROxPcl5xN1N5bV2ar2qMe1Sm6hcjp4njVx5lcuN6yl+dLro+gtB u84uFZIABnQF9EQVDB0RhO+DKBuIZDYKjmsC8NlVOEF6stki/RsiwcR7TW20tUuy4ltI Tm+Q== X-Gm-Message-State: APjAAAVNg7It3um++q7gARmi02rfF/lD4Ua4eLu9JPpDNnLnLvmf430T f4FoaR/XQqNvk/aaOfmoNLWsZXhX3TLTj1tK30HfqCMzTf9fYrA7tGf/XpsbQ2IpzI/yADfz7rk 7nLpnc2OWEtwsouI55m1ZYbV6dhbJc/IPlRIUjfKmAj81Nfv+IZj/IQT72533rpvCua7w5HlR0Q == X-Google-Smtp-Source: APXvYqzPIQBhe1pR5E6N0S/6id2MNzATW0i0RF/NoGfYDo+qYrUrYdL8Z2UKX94zzilK6UDNdB0uqQ== X-Received: by 2002:a62:834e:: with SMTP id h75mr15928037pfe.238.1582334784301; Fri, 21 Feb 2020 17:26:24 -0800 (PST) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id c26sm4184427pfj.8.2020.02.21.17.26.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2020 17:26:23 -0800 (PST) Subject: Re: [PATCH v2 2/7] firmware: add offset to request_firmware_into_buf To: kbuild test robot Cc: kbuild-all@lists.01.org, Luis Chamberlain , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann , Linux Memory Management List References: <20200220004825.23372-3-scott.branden@broadcom.com> <202002220811.ZfoxGUs3%lkp@intel.com> From: Scott Branden Message-ID: <34ac08f4-8528-a150-d451-4ce6cc98d555@broadcom.com> Date: Fri, 21 Feb 2020 17:26:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <202002220811.ZfoxGUs3%lkp@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Will remove semicolon to fix compile error on certain CONFIG_FW_LOADER not selected. On 2020-02-21 4:50 p.m., kbuild test robot wrote: > Hi Scott, > > I love your patch! Yet something to improve: > > [auto build test ERROR on char-misc/char-misc-testing] > [also build test ERROR on kselftest/next linus/master v5.6-rc2] > [cannot apply to driver-core/driver-core-testing next-20200221] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-partial-read-support-in-request_firmware_into_buf/20200222-032851 > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 06e33595e96f212811066df192ae8bf802174296 > config: x86_64-randconfig-c002-20200221 (attached as .config) > compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>): > > In file included from drivers/base/firmware_loader/fallback.h:5:0, > from drivers/base/firmware_loader/fallback_table.c:12: >>> include/linux/firmware.h:97:1: error: expected identifier or '(' before '{' token > { > ^ > include/linux/firmware.h:94:19: warning: 'request_firmware_into_buf' declared 'static' but never defined [-Wunused-function] > static inline int request_firmware_into_buf(const struct firmware **firmware_p, > ^~~~~~~~~~~~~~~~~~~~~~~~~ > > vim +97 include/linux/firmware.h > > fbab976d7ce455 James Bottomley 2008-03-07 93 > a098ecd2fa7db8 Stephen Boyd 2016-08-02 94 static inline int request_firmware_into_buf(const struct firmware **firmware_p, > 6f0a3d616d978b Scott Branden 2020-02-19 95 const char *name, struct device *device, void *buf, size_t size, > 6f0a3d616d978b Scott Branden 2020-02-19 96 size_t offset, unsigned int pread_flags); Will remove ; > a098ecd2fa7db8 Stephen Boyd 2016-08-02 @97 { > a098ecd2fa7db8 Stephen Boyd 2016-08-02 98 return -EINVAL; > a098ecd2fa7db8 Stephen Boyd 2016-08-02 99 } > a098ecd2fa7db8 Stephen Boyd 2016-08-02 100 > > :::::: The code at line 97 was first introduced by commit > :::::: a098ecd2fa7db8fa4fcc178a43627b29b226edb9 firmware: support loading into a pre-allocated buffer > > :::::: TO: Stephen Boyd > :::::: CC: Linus Torvalds > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org