From: Joao Martins <joao.m.martins@oracle.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Matthew Wilcox <willy@infradead.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Jane Chu <jane.chu@oracle.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>, Christoph Hellwig <hch@lst.de>,
nvdimm@lists.linux.dev,
Linux Doc Mailing List <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v6 2/5] mm/sparse-vmemmap: refactor core of vmemmap_populate_basepages() to helper
Date: Thu, 24 Feb 2022 10:39:39 +0000 [thread overview]
Message-ID: <3498d8cd-47b1-e53b-96e2-9a76f19654c2@oracle.com> (raw)
In-Reply-To: <CAMZfGtVD6XyjqrQ4RpDDPOSZCgo1NHXbfjeRwqi2KmUckW-6xA@mail.gmail.com>
On 2/24/22 03:10, Muchun Song wrote:
> On Thu, Feb 24, 2022 at 3:48 AM Joao Martins <joao.m.martins@oracle.com> wrote:
>>
>> In preparation for describing a memmap with compound pages, move the
>> actual pte population logic into a separate function
>> vmemmap_populate_address() and have vmemmap_populate_basepages() walk
>> through all base pages it needs to populate.
>>
>> While doing that, change the helper to use a pte_t* as return value,
>> rather than an hardcoded errno of 0 or -ENOMEM.
>>
>> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
>
> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
I've added this one too, thanks for the thorough review!
next prev parent reply other threads:[~2022-02-24 10:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 19:48 [PATCH v6 0/5] sparse-vmemmap: memory savings for compound devmaps (device-dax) Joao Martins
2022-02-23 19:48 ` [PATCH v6 1/5] mm/sparse-vmemmap: add a pgmap argument to section activation Joao Martins
2022-02-24 3:02 ` Muchun Song
2022-02-24 10:38 ` Joao Martins
2022-02-23 19:48 ` [PATCH v6 2/5] mm/sparse-vmemmap: refactor core of vmemmap_populate_basepages() to helper Joao Martins
2022-02-24 3:10 ` Muchun Song
2022-02-24 10:39 ` Joao Martins [this message]
2022-02-23 19:48 ` [PATCH v6 3/5] mm/hugetlb_vmemmap: move comment block to Documentation/vm Joao Martins
2022-02-23 19:48 ` [PATCH v6 4/5] mm/sparse-vmemmap: improve memory savings for compound devmaps Joao Martins
2022-02-24 5:54 ` Muchun Song
2022-02-24 11:46 ` Joao Martins
2022-02-24 15:34 ` Muchun Song
2022-02-23 19:48 ` [PATCH v6 5/5] mm/page_alloc: reuse tail struct pages " Joao Martins
2022-02-24 5:57 ` Muchun Song
2022-02-24 11:47 ` Joao Martins
2022-02-24 15:41 ` Muchun Song
2022-02-24 16:49 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3498d8cd-47b1-e53b-96e2-9a76f19654c2@oracle.com \
--to=joao.m.martins@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jane.chu@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=nvdimm@lists.linux.dev \
--cc=songmuchun@bytedance.com \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox