From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA47FC61D97 for ; Fri, 27 Jan 2023 08:33:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 592AA6B0074; Fri, 27 Jan 2023 03:33:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 542336B0075; Fri, 27 Jan 2023 03:33:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E3288E0001; Fri, 27 Jan 2023 03:33:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2F1B06B0074 for ; Fri, 27 Jan 2023 03:33:04 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 957F01A055E for ; Fri, 27 Jan 2023 08:33:02 +0000 (UTC) X-FDA: 80399913804.28.9A0961D Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf16.hostedemail.com (Postfix) with ESMTP id 95BDC180009 for ; Fri, 27 Jan 2023 08:33:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="wr/faRoj"; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf16.hostedemail.com: domain of krzysztof.kozlowski@linaro.org designates 209.85.128.52 as permitted sender) smtp.mailfrom=krzysztof.kozlowski@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674808380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mNDzzLve1QZpQMH586QRx6794jByHtxqf4nlX323e/M=; b=4nujtowWS5bl2t5sJZIFBwozD1yMNhQ4sFAQM5Yw63CrUcUFLcu7Rh5ScYC9ZwhbKeBAIv 9EzCO4l86sQ/OFZMJkNY3BOPx+AIoC/nESO6j9MOI+eQQcgsfdAi1V8U3vGrdWYQaN7uAa 0YWIp3L/PGBAMRJPY4NWFxlAWzMtVBI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="wr/faRoj"; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf16.hostedemail.com: domain of krzysztof.kozlowski@linaro.org designates 209.85.128.52 as permitted sender) smtp.mailfrom=krzysztof.kozlowski@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674808380; a=rsa-sha256; cv=none; b=FDYAaAS4xdqerx7x5BdUtvmH3vz5fiyMNnMzYuKrQ+aIPEqW+cLuktx2D5ABTGQI7P2cTp 0qMRKRPD2RhVfhL8wUruJWQb6cc4V5FxK6bcBy7n/EROEyNC0Kd+y2qYo3nIyZXBNWii8k wuwDLVpVMhZ57V50Bc5zqiZXMSad+wo= Received: by mail-wm1-f52.google.com with SMTP id iv8-20020a05600c548800b003db04a0a46bso5260285wmb.0 for ; Fri, 27 Jan 2023 00:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mNDzzLve1QZpQMH586QRx6794jByHtxqf4nlX323e/M=; b=wr/faRojnYtopasMYIZ7X5nKWJvOwIFDt6H3ZwcJFlrglXBSFYxDO20pRk+2obypGw lp6sclR+UR+EHorIMkUXCu8LDlgnas4SNpc653G4SjJSFR1rb/7X/I3yuiJXCETM3EDr 83A6hXp1UGKXUu8nI40pGKALkiqAnnJSwTfoe6hyBxm7uiUuR3xsh9+osuJIJb55MYPm xywXnOVLUbpg5jrSC6ADmSw5oxb91f64hNGPIz4Cicrdjt0iCGcC4T9y2P5LyHewgFxn l/6Pay8nOL53WWvAYGjjlZhjdln3wsBScLS8KjDf2HPqdzZ2rbkWVTiShk6sY4zXS+1N 4Jkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mNDzzLve1QZpQMH586QRx6794jByHtxqf4nlX323e/M=; b=hYugxRU+juHO+V/pCXn3xGPd2I5M9f/iC6EEp7ZcuY5Q73VFYu2Yf35JXYiEmYwg1T 9EdVp+YCQN9/uxJVhYVzrBtOX2GcfDdSeL7A7oOzDi4YwzbvFHvV1bR5xMZ8Ng6ROZha bu7g2EkjaTT/lggDDNwH7+Ep5oNEBkUMG6+ZRtvzYWm0PNvWhZTnHzh86QhilPh7L+YF MbJ+mgoUato94QZleDvP7iDWrwBV2KcklxTOriaXYBpy636kLU2LNOTdNvax5bmWC83s LG9Df2sN2RytCcurCTPqtx3SevBbive+DRbb/mta3Qflcgc4y3iOtp3kIusgpohhlxjs veyA== X-Gm-Message-State: AO0yUKXZtsKq28aHfei3Nj5livrGPfCVQlK77QquNNKPK0N+Uq7FfPNZ V2ClW1NSpBpzx2Py9Zald4uPPA== X-Google-Smtp-Source: AK7set8AUVYQ3DMEqB5mb5eVqgQNd79NxSGC2QpLaYfkKjZyelI9gwbfI++aOYEpI1mjO/SKh2lGNQ== X-Received: by 2002:a05:600c:1caa:b0:3dc:4042:5c30 with SMTP id k42-20020a05600c1caa00b003dc40425c30mr177420wms.10.1674808379017; Fri, 27 Jan 2023 00:32:59 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d10-20020adffbca000000b00287da7ee033sm3318241wrs.46.2023.01.27.00.32.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 00:32:58 -0800 (PST) Message-ID: <348c3416-be44-b912-98ef-7f394bd408c0@linaro.org> Date: Fri, 27 Jan 2023 09:32:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC PATCH v2 02/31] Documentation: Add binding for kalray,kv3-1-core-intc Content-Language: en-US To: Jules Maselbas Cc: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guillaume Thouvenin , Clement Leger , Vincent Chardon , =?UTF-8?Q?Marc_Poulhi=c3=a8s?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , "Jason A. Donenfeld" , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan , Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-3-ysionneau@kalray.eu> <20230126161032.GH5952@tellis.lin.mbt.kalray.eu> From: Krzysztof Kozlowski In-Reply-To: <20230126161032.GH5952@tellis.lin.mbt.kalray.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 95BDC180009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: iaz8wxmm9yrw8s3omqssn4cgft59rr1q X-HE-Tag: 1674808380-44454 X-HE-Meta: U2FsdGVkX19I4bsrbw8iKryUx4XlFdTqQEmPY5gvMGhaqR0kulYHwtH18LS0+RX5Ayh+Bkkh8Irb+5LmttD5pK1hfEnS9vVuMYsMORU7+bvP2mn7XvshsvEvN1LxCkJS1AdTvtep9unbTn3IvPo5aNGnqHKSp5NZkw/5NWfUPExLsRAFvUl3K7BiQdcUJga/mCCP2JYLty611qU6x/PDIzFvOBmErL9+d58/P9nS7qQQ6GA06DkAV3FbhYtTjylV4tjC70wLtBBbZesu0nBYDNYHT3RN9XrE5sIat043SfDyVfdwkL9DnDi32j3Tlc/oeL08YheGhWJs8fgrVrY5cRGXQa5GoTGUqVUJJ9WjTpQbZcQ06+SGuVrIIgmEkfFqUHqJ4YDpCBEWxab/79nLOlFX9sZYzQEuomFH92MGtmewMLFU+PROSqUseLV4LFQnDMhp7uI6oHCOGDuFuBKK/FQmnY1bdqiXUBRHhTP8HRyGO1rd9vWpWA273wlJBPPQjdLQIJiKuiqPuJGZDIWZwu8J5JJtrqyuCkIadm2sWCJa54XFbZXB9MRb/uxT+zTmMo5/qIUA0g5j7ekYbgKZPqX1OJDMPW/D38CvDALCg7Bgymsc0ksJiveC+270Z7obvnO7XSyyl30+HIyc2H9H1J/xSqgGNDtkK6QkaEAomlH8eotD91B6aky5E00lVz8cybZhZy+80KlJ9ziMUY0QojBTXZR2GOKYXMuVE+xoLbOyQRHXbjBHvknn+05IcQniNUjVj2gf4vRFf38tQ0yfH7kYw+Qwb57CN1BfvFv8JPg6wBYDWRTTiEvlDZPWWNMsWzZohgkE5IMnrLP5uqEg1hUeGapLBykIS7MiuLguq7E4q3jb66aASPlaevShCbOYpro/H6CsCDa9JgdBe+mZYfPEtNzy2gkkhUgJAB0zj5bA//pTG4Kia4yfgLf2zpYyzZlsjsdOz3u5SR2abbe QL2cZIgG hBoawHOQzEPY/xw+rF0svuEn0IYT/gjnyyvKrauELRl6mUI2ybsdZ4v+nc2C+CBBJPy5v3hu2D+CbAPfVSkcVqHCbVtUQmTgUDgQTngAS8tQCGqdeYRW0dm1OmHpGbY8KDD4C44qqWiBxAKRlyAn/Ua6Zeq61S/fuhvfsoFafLzMY7dDEQ91bmfDUaVHEyTGGftFzWd4h/ZUFQlJ9mWhsHq0kwqvT4BUTJmZpyXASzgFAx+ceCPID1DyNH834ATS50HXzq6u7b4JS0WKWZeJO77/uwdelJpBPgotlasKAX/IlvgmhAIKswT0L0w2LI+GqUvChx98vbPf3giDGe3Oz4F5rLO0ny2o0VeSu9uin1LBW8J4DUHxI2AelcfN/6/RGQU9XQA8+1FBvHbQH649uYk4Au0ri47ASo3kCI1Z/ckrZC6IRpJ7neffKIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26/01/2023 17:10, Jules Maselbas wrote: >>> + reg: >>> + maxItems: 0 >> >> ??? No way... What's this? > This (per CPU) interrupt controller is not memory mapped at all, it is > controlled and configured through system registers. > > I do not have found existing .yaml bindings for such devices, only the > file snps,archs-intc.txt has something similar. > > I do not know what is the best way to represent such devices in the > device-tree. Any suggestions are welcome. You cannot have an array property with 0 items. How would it look like in DTS? There are many, many bindings which are expressing it. Just drop the reg. > >> >>> + "kalray,intc-nr-irqs": >> >> Drop quotes. >> >>> + description: Number of irqs handled by the controller. >> >> Why this is variable per board? Why do you need it ? > This property is not even used in our device-tree, this will be removed > from the documentation and from the driver as well. > >>> + >>> +required: >>> + - compatible >>> + - "#interrupt-cells" >>> + - interrupt-controller >> >> missing additionalProperties: false >> >> This binding looks poor, like you started from something odd. Please >> don't. Take the newest reviewed binding or better example-schema and use >> it to build yours. This would solve several trivial mistakes and style >> issues. > I am starting over from the example-schema. > >>> + >>> +examples: >>> + - | >>> + intc: interrupt-controller { >> >> What's the IO address space? > As said above, this is not a memory mapped device, but is accessed > through system registers. Sure, but then you cannot define a reg which was confusing... Best regards, Krzysztof