From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED883C4167B for ; Wed, 6 Dec 2023 09:17:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EA6B6B0096; Wed, 6 Dec 2023 04:17:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 899826B0099; Wed, 6 Dec 2023 04:17:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6ECD66B009B; Wed, 6 Dec 2023 04:17:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5FD8D6B0096 for ; Wed, 6 Dec 2023 04:17:55 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 337F480164 for ; Wed, 6 Dec 2023 09:17:55 +0000 (UTC) X-FDA: 81535841310.25.694F209 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id D908F14001B for ; Wed, 6 Dec 2023 09:17:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XoOBMuHa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701854273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Eleg+pE/R+BnHgWT+QuZEqcgCjnh9bHSZKzS94qCP7w=; b=8Snk/h0l7/n2XJSA3UGLRQTUgT7PaFnUapBSe3jKNET+3nDBaitqNZJbLgAIWW66y+2Pnn krRENzaEK1vWYSTqiXaZCtbQOdeT54wFNe2pJASOVi0Z89guwpm1IA2BAydk5O9LQYDzyN iBkuk/ISDp2v2f/DBIlMeWJmNm1qOMU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XoOBMuHa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701854273; a=rsa-sha256; cv=none; b=HSuIllG0EHLaAnt4hdGjjtDqkWUPkJSoRvzDr6Rpn16st4+rDyEMyO/0WgbEOPvU37icAm tLI6BMouAYnmQqD0o4ZOdKxDhu5Yf1+ZS6RbI982OXgTMjQL4c0/ID8mMf1TkjN4TZgUyj xloslyWNuZoOXX1klKb/ZN1qQPJEf/U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701854272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Eleg+pE/R+BnHgWT+QuZEqcgCjnh9bHSZKzS94qCP7w=; b=XoOBMuHaiOClMHIcu2JnqjnaaPhyGZiAq8bYAGhe6OHmuJW8YUWnfq+GIFFWePjjsrVjfQ vHicO4yAQZpXj2Qa/azCf0jnc7oiAMcqLqg71tWFGWGUQy/eyJ+aVoHe+H8nLISlgqUJeg i3HkWuCbkHeXxnSybGaHcgcVVZA9RZg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-tCxUtEtcOBiut_2iSsHQUw-1; Wed, 06 Dec 2023 04:17:50 -0500 X-MC-Unique: tCxUtEtcOBiut_2iSsHQUw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40c1257782fso12279605e9.1 for ; Wed, 06 Dec 2023 01:17:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701854269; x=1702459069; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Eleg+pE/R+BnHgWT+QuZEqcgCjnh9bHSZKzS94qCP7w=; b=ldt81VyGFaaJM/ulZTBp56dyTJNpaQZYU05aD569m4rLS4D55+XoKf+pO6SXbEufre 15czxHDmfmBJ9x2MfB3JRkPBYi3iDo1ixfyxo+uR/BQDZpIptd93jXxIhrFT+kpwZUbm sk//qxZdF2YDL4qeMVjEhd9CrOPtQnCnXbaRfi+DAKs6MAj0oZM6L5jIfnS0fKKO+Bjm zt2UtZTHqO31+UbWb+NQsQ2AKol4wBlDwYDMSvD1+l3K02b/TCBpZQJaWmy/97Z51/6K I9EO6WSpEnPTKa7hfGSIDfPK+cKB/7P+1j0soDxJOGhN28f3BF4c4expu6hPQ2zSw6cd n+Qw== X-Gm-Message-State: AOJu0Yz20ur/UGjblfwMGK8Itr73u8fUR68+J+bKI/8jYHYCvcAqXWv1 IHGF4+JsJ7eLAB2cFtYDdfRowqwsIv/BHnWR6zDpiaA7WnlNRBVqOwg29SOvR4zl67UuYCFlwkv v9LP+4cKxUvM= X-Received: by 2002:a05:600c:1e24:b0:40c:709:d924 with SMTP id ay36-20020a05600c1e2400b0040c0709d924mr361262wmb.147.1701854269682; Wed, 06 Dec 2023 01:17:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnNvYZ9E+Rd4ZGT4BMa3yUJznXzkNiJ5+PR0E9T/A9POYeopO+Hj2OEscQF7QLC32L1eCdrQ== X-Received: by 2002:a05:600c:1e24:b0:40c:709:d924 with SMTP id ay36-20020a05600c1e2400b0040c0709d924mr361252wmb.147.1701854269301; Wed, 06 Dec 2023 01:17:49 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id iv7-20020a05600c548700b00405959469afsm21255103wmb.3.2023.12.06.01.17.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 01:17:48 -0800 (PST) Message-ID: <3488f910-891d-48bf-a5da-5bc01955b072@redhat.com> Date: Wed, 6 Dec 2023 10:17:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 07/39] mm/rmap: convert folio_add_file_rmap_range() into folio_add_file_rmap_[pte|ptes|pmd]() To: Yin Fengwei , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Mike Kravetz , Muchun Song , Peter Xu References: <20231204142146.91437-1-david@redhat.com> <20231204142146.91437-8-david@redhat.com> <12d26867-c6cf-4927-bc89-124a0179dfe4@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <12d26867-c6cf-4927-bc89-124a0179dfe4@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D908F14001B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: xoqt31dua656kndzt5q9csyfhosc87n7 X-HE-Tag: 1701854272-400308 X-HE-Meta: U2FsdGVkX18q/S6T0qaPvxc2vcssOJJRfE+iAFGCZJaTk0FXf/swONfxJxgZ4QzRa/fsw+gTo/N4ArVFLrpA8h5NPT024RAqsSTvHpWSyt3VT7u/EauL6TCw3w7LNEnHIYOr/DxcCTih6KpZ5Sxlu9x4IH9m2q3iw6R+gIAAcerGNZFCL2cs4GIUJzZRO7YnaeWwVRjMshGR8J8Kh1CaxBIhfLAa+E77KQlh9PL5L7nPhdxCdRHFaD4WVQT4QEjhjOF2OeXrSvmC44RRKQv6L1EZzfLwBeza16cMun6SZud/lEuHr9PplqE4L4EiTfchO/B2IvwOmDc7g6dizDPvQi7AXYv+DRrGVys2dsUttFjtQDXMmLkftD0lBEPXKhKBK0u9608fiDpT5rT4ag1ba5lbMuUAvqoeJif8n5bQUD0aozByU6S3vfJn883wWOD/F3sCnMCDJ8ROuH7GjI+4YHna372/FXAt+QGKmqrbMUNboSnTN1GWlOs5N8Ld6S4aUFBa/i/vdZi5BmfNTQEFxqFrBXWyL/SBr9rZxLZJ/wXZMLzlpZ+sQdaqIp1N8WLUpT9wJ447iFP1EdULp9MNOcnkFMmAc2HIKLS8ebWOf31hFHgf1yYspU3S9TF1i46y/iD9w3rF2RaKfldEChB27EsZwZyd/s9it+25H0FpOpco5jEdvEUrImQ9IRxaoSGdnoa03it1BC8eJOPxXb0Txv6avUjtMKDWN2G6Wym5VL6QrnPrKIYWuoUfB2xxBr1uZ3EK+XLUFs7hVtTAJnRw1bY/IFzueb2QKWwzb5jQF+ftEFX7I9k1tiVBaRjo2PsxMH8JgxhqYrwpcM8gft5PdyaOBvEJSVn0rwk6ebIDMOWWdwT0seKLWbNLA67E3+n4ayDwKX+mrBfo/QD/JsNGPfjYjaVYktT0y4AU1/WT0PlO0A3V8pGdmiUodgG0F3IOnmzdQ8sT3BtyshhM5NN eXxkeLBr Q1SikdR4rYIHo0UwiH0Oi/P896L+HsI2c3ENIC9lqUcQnfjYn5M6xfGm/KtH6mijeV+xPkPtvQmyiMGoJxrmXf0UmTQToC1/J63oyLIQ376gPcvkdZtH4zTbk+i+N/m4VwClrzLrCgCfCFr5C4oVUpvW0N8qFEthdR8j/O1ouoNTr69M5vi+1AeyO5/VwQIAECpbJHof7WiQaZEGH8XHAY+b/RgQ0gEpF9ZBpwD7EjYNO3leuku5IpI7uMM5IPYU16FaaKU3ye5cXLMgrokelxOc6dyx0g3M51gENAAmInOglU7v93e5Mrz+ElTeqLbO4ZIO/uMhRz77G0i9DlJolYrcqTQy1TRwNetDS4vuE/4SPHADonx1iaP8ka01SH6PgzE2BX2b2YPI5qeFsr0MFWquTeYubu7c6G54FMm7jAm1a2ONfEozwGMwVzZJboyJIcxQlLUVsYfzHcxnTS55RfSWDVprI8KdWKFAd/bNC8rLG+Sq3QXo6XqHgVD6N7UtnaIak1/kUfECHZFN7eADv7XfdQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.12.23 02:30, Yin Fengwei wrote: > > > On 12/4/23 22:21, David Hildenbrand wrote: >> Let's get rid of the compound parameter and instead define implicitly >> which mappings we're adding. That is more future proof, easier to read >> and harder to mess up. >> >> Use an enum to express the granularity internally. Make the compiler >> always special-case on the granularity by using __always_inline. >> >> Add plenty of sanity checks with CONFIG_DEBUG_VM. Replace the >> folio_test_pmd_mappable() check by a config check in the caller and >> sanity checks. Convert the single user of folio_add_file_rmap_range(). >> >> This function design can later easily be extended to PUDs and to batch >> PMDs. Note that for now we don't support anything bigger than >> PMD-sized folios (as we cleanly separated hugetlb handling). Sanity checks >> will catch if that ever changes. > I do have a question for the folio which has larger size than PMD in the > future: > Will the folio size be only just like PMD size/PUD size? Or it's possible between > PUD size and PMD size? I strongly assume that we'll see in the future folios larger than a single PMD (for example, 4 MiB on x86-64). This will require quite some care in other areas (and this series, as it converts some PMD handling function to folios, further prepares for that). > > If it's possible between PUD size and PMD size, will the mapping be mixed PMD mapping > and PTE mapping or just PTE mapping. I suppose it could be mixed because of efficiency > of page walker. Depending on with which alignment such larger folios are mapped into the page tables and some other factors, we might indeed end up having parts of the folio mapped by PMDs and parts by PTEs. Well, and once we involve PUDs we might have a mixture of all of these :) The current API here will be able to deal with that (excluding the _pud variant). To improve performance, we might want PMD batching and have _pmds functions. We'll have to tweak the rmap internals to do the rmap accounting properly then (and the sanity checks will catch any of that and highlight the need for rmap-internal extensions); maybe once we come to that, we no longer have these subpage mapcounts, but we'll have to see if/when/how that happens. > > It may just be too early to consider this now. > I had that in mind while working on this. I assume it will take some more time to handle everything else that needs to be prepared for that, but the rmap interface should be able to handle that, only the internals will have to be extended. Thanks! -- Cheers, David / dhildenb