From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C14C433F5 for ; Thu, 17 Mar 2022 18:53:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA8348D0002; Thu, 17 Mar 2022 14:53:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B57738D0001; Thu, 17 Mar 2022 14:53:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A20818D0002; Thu, 17 Mar 2022 14:53:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 92F0F8D0001 for ; Thu, 17 Mar 2022 14:53:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 44EC88248D52 for ; Thu, 17 Mar 2022 18:53:16 +0000 (UTC) X-FDA: 79254775992.17.87A779A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf26.hostedemail.com (Postfix) with ESMTP id 9CEF0140031 for ; Thu, 17 Mar 2022 18:53:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3EE5C1F38E; Thu, 17 Mar 2022 18:53:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1647543194; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sg6FmafrPdR1KtYNg/JwS0y/weg8uwWLi0b4wB9DaB8=; b=CW+6aHqwJGO16ayz+hSnPGa0OPbIHWsUKut3I4UlP3B9++g8YafKAZteQjBFUdF6bEJfoH hpy6Ebcd2p94U4iCH9Lc1apwE77b13nAy1ZvtBdnmBxqwOdyTaVCwhE1JXtYPQ4Uq7QOy7 s1DPlV+jNFXxC91mvrPiXyLcTnNioUY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1647543194; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sg6FmafrPdR1KtYNg/JwS0y/weg8uwWLi0b4wB9DaB8=; b=o8CjYA0ITGwkIvMJKFrEfzWkeowZgmhKOTbhiqLw0rKG8pL+AQyrQ9lPQ17fvlbiiikol3 lPAUcMEz8wfNLADQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0DB7A13BB5; Thu, 17 Mar 2022 18:53:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id G5OlApqDM2IkKwAAMHmgww (envelope-from ); Thu, 17 Mar 2022 18:53:14 +0000 Message-ID: <34856139-e2db-4d34-07b5-c0af2bdf44f4@suse.cz> Date: Thu, 17 Mar 2022 19:53:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC PATCH v2 1/4] [PATCH 1/4] mm: refactor of vma_merge() Content-Language: en-US To: =?UTF-8?Q?Jakub_Mat=c4=9bna?= , linux-mm@kvack.org Cc: patches@lists.linux.dev, linux-kernel@vger.kernel.org, mhocko@kernel.org, mgorman@techsingularity.net, willy@infradead.org, liam.howlett@oracle.com, hughd@google.com, kirill@shutemov.name, riel@surriel.com, rostedt@goodmis.org, peterz@infradead.org References: <20220311174602.288010-1-matenajakub@gmail.com> <20220311174602.288010-2-matenajakub@gmail.com> From: Vlastimil Babka In-Reply-To: <20220311174602.288010-2-matenajakub@gmail.com> Content-Type: text/plain; charset=UTF-8 X-Rspamd-Queue-Id: 9CEF0140031 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CW+6aHqw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=o8CjYA0I; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: iig6k6esp7x951pbtey6z5ixuukoqo7w X-Rspamd-Server: rspam04 X-HE-Tag: 1647543195-191816 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/11/22 18:45, Jakub Mat=C4=9Bna wrote: > Refactor vma_merge() to make it shorter, more understandable and > suitable for tracing of successful merges that are made possible by > following patches in the series. Main change is the elimination of code > duplicity in the case of merge next check. This is done by first doing > checks and caching the results before executing the merge itself. Exit > paths are also unified. >=20 > Signed-off-by: Jakub Mat=C4=9Bna Reviewed-by: Vlastimil Babka It's a nice cleanup on its own. Removed duplication and reduced indentati= on levels helps.