From: Vlastimil Babka <vbabka@suse.cz>
To: "Jakub Matěna" <matenajakub@gmail.com>, linux-mm@kvack.org
Cc: patches@lists.linux.dev, linux-kernel@vger.kernel.org,
mhocko@kernel.org, mgorman@techsingularity.net,
willy@infradead.org, liam.howlett@oracle.com, hughd@google.com,
kirill@shutemov.name, riel@surriel.com, rostedt@goodmis.org,
peterz@infradead.org
Subject: Re: [RFC PATCH v2 1/4] [PATCH 1/4] mm: refactor of vma_merge()
Date: Thu, 17 Mar 2022 19:53:13 +0100 [thread overview]
Message-ID: <34856139-e2db-4d34-07b5-c0af2bdf44f4@suse.cz> (raw)
In-Reply-To: <20220311174602.288010-2-matenajakub@gmail.com>
On 3/11/22 18:45, Jakub Matěna wrote:
> Refactor vma_merge() to make it shorter, more understandable and
> suitable for tracing of successful merges that are made possible by
> following patches in the series. Main change is the elimination of code
> duplicity in the case of merge next check. This is done by first doing
> checks and caching the results before executing the merge itself. Exit
> paths are also unified.
>
> Signed-off-by: Jakub Matěna <matenajakub@gmail.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
It's a nice cleanup on its own. Removed duplication and reduced indentation
levels helps.
next prev parent reply other threads:[~2022-03-17 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 17:45 [RFC PATCH v2 0/4] Removing limitations of merging anonymous VMAs Jakub Matěna
2022-03-11 17:45 ` [RFC PATCH v2 1/4] [PATCH 1/4] mm: refactor of vma_merge() Jakub Matěna
2022-03-17 18:53 ` Vlastimil Babka [this message]
2022-03-11 17:46 ` [RFC PATCH v2 2/4] [PATCH 2/4] mm: adjust page offset in mremap Jakub Matěna
2022-03-11 17:46 ` [RFC PATCH v2 3/4] [PATCH 3/4] mm: enable merging of VMAs with different anon_vmas Jakub Matěna
2022-03-11 17:46 ` [RFC PATCH v2 4/4] [PATCH 4/4] mm: add tracing for VMA merges Jakub Matěna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34856139-e2db-4d34-07b5-c0af2bdf44f4@suse.cz \
--to=vbabka@suse.cz \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matenajakub@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=patches@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox