From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA02C19F2D for ; Wed, 10 Aug 2022 01:57:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61B308E0002; Tue, 9 Aug 2022 21:57:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CB2F8E0001; Tue, 9 Aug 2022 21:57:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 475E38E0002; Tue, 9 Aug 2022 21:57:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 343A18E0001 for ; Tue, 9 Aug 2022 21:57:01 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 09370AB9C4 for ; Wed, 10 Aug 2022 01:57:01 +0000 (UTC) X-FDA: 79782019842.24.B7E893D Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf13.hostedemail.com (Postfix) with ESMTP id 09A9D20179 for ; Wed, 10 Aug 2022 01:56:59 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4M2Y1H2CKXzGpJy; Wed, 10 Aug 2022 09:55:31 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 10 Aug 2022 09:56:55 +0800 Subject: Re: [PATCH v2 01/16] mm/page_alloc: Cache page_zone() result in free_unref_page() To: "Matthew Wilcox (Oracle)" , References: <20220809171854.3725722-1-willy@infradead.org> <20220809171854.3725722-2-willy@infradead.org> From: Miaohe Lin Message-ID: <347ec49c-8a02-cce2-b401-e2d9bb5ab4f9@huawei.com> Date: Wed, 10 Aug 2022 09:56:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220809171854.3725722-2-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660096620; a=rsa-sha256; cv=none; b=WArSjNQZaNlvj/2bjCdhjvKr3iRinMjsQVq/Tmz3m3S+lAlz1ERShFm75FH9V8YkkEPEva jANdpGC2PGftroHRgUv6OgLPPbCj/U647pkP8xhhUNAbQKi1Wn6+xwFeseP8RjcUyTRiLf gkeO8MuMYHLn94SVRd4wmd9fomSefMo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660096620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V0nvutCoB1IE6iCH8/Za49finiTabXtlODdEphYMYTA=; b=lpyTK9V16/FTYDDLeRDygcdeh+ji8MpQGKm7j7qDv+gVavvgOcl169xrFSZpBMTrdeDP9O Rw0Uzn1aMpraZPO5ftiBd2DgMpYNiL/OPdxHMIY4GB0J3cxUMwqGboDkQPpLk5HHSHDDZx ffnQTITc20UIPS8YM35cQZgHgJVWEu0= X-Rspamd-Server: rspam10 X-Stat-Signature: 699z1dtwbrojko1pauu98ymiuqde8a67 Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: X-Rspamd-Queue-Id: 09A9D20179 X-HE-Tag: 1660096619-921640 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/10 1:18, Matthew Wilcox (Oracle) wrote: > Save 17 bytes of text by calculating page_zone() once instead of twice. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Miaohe Lin Thanks. > --- > mm/page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e5486d47406e..2745865a57c5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3483,16 +3483,16 @@ void free_unref_page(struct page *page, unsigned int order) > * areas back if necessary. Otherwise, we may have to free > * excessively into the page allocator > */ > + zone = page_zone(page); > migratetype = get_pcppage_migratetype(page); > if (unlikely(migratetype >= MIGRATE_PCPTYPES)) { > if (unlikely(is_migrate_isolate(migratetype))) { > - free_one_page(page_zone(page), page, pfn, order, migratetype, FPI_NONE); > + free_one_page(zone, page, pfn, order, migratetype, FPI_NONE); > return; > } > migratetype = MIGRATE_MOVABLE; > } > > - zone = page_zone(page); > pcp_trylock_prepare(UP_flags); > pcp = pcp_spin_trylock_irqsave(zone->per_cpu_pageset, flags); > if (pcp) { >