From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57485C433EF for ; Fri, 28 Jan 2022 17:57:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC8DD6B010F; Fri, 28 Jan 2022 12:57:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A78776B0111; Fri, 28 Jan 2022 12:57:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 942A66B0113; Fri, 28 Jan 2022 12:57:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay039.a.hostedemail.com [64.99.140.39]) by kanga.kvack.org (Postfix) with ESMTP id 854706B010F for ; Fri, 28 Jan 2022 12:57:45 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 58515120B1A for ; Fri, 28 Jan 2022 17:57:45 +0000 (UTC) X-FDA: 79080453690.02.7CAED9E Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf09.hostedemail.com (Postfix) with ESMTP id E295D14000A for ; Fri, 28 Jan 2022 17:57:44 +0000 (UTC) Received: by mail-il1-f173.google.com with SMTP id u5so6069026ilq.9 for ; Fri, 28 Jan 2022 09:57:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=71w7hp/9pxq3OWpPEt+fr6pzk72moXbSFhLNj69p5Gc=; b=JOUFeVTTVbxykvWeZe3975fNFyii01VRwwe0Et/oKrD+vqXDViwHH3tq1DW/IRH5y/ gM4K1Mp5UNoFTFJpIOtAutDsnmqeVh4IsoLz548NPWb4OBZuggFWo4XmV5elN2DbIBDZ ygdVRSSak/6C2v/8a1kqHLtoPukK/ScKWNGB4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=71w7hp/9pxq3OWpPEt+fr6pzk72moXbSFhLNj69p5Gc=; b=pp9uT1IJF/R8xrCDbD3qONN8P5h0isdFxjk44yv4l3mJ/2kUwhR2pHbfDPPBsZ+f5K fNrzTYZB3/l/YOcq1TwBezdlY1vo0iLhHt8dB3QAmo4b/CXyTBQhmuuwARrr6Am72lpP lPB6jFoSbUFh/RH93DJ6NxoFIn1ubtxJO9apagWOrOjEn2lcUTEi9Nc7HQqCTufCl1oQ p8AbAAVlwoErtcxhkCeN9/eMRAis9ZsKrhw7RKWd5C+NjTIXuzOI0NGHZradBntcbhuZ uxBPPUZ+lR5gPzIrbUO2sG98Q/NNe+zH5Zlt8QSWxkdm0v5Gp2ygb5C/YXGliMKKdUqi 0amg== X-Gm-Message-State: AOAM532hX04lh7EKK7O1mlzzAIpYDb1Gaikjkvx30pw4RuF3LbfgBDfe M+ZAJKQ4mu35cFDtO9npKcVAug== X-Google-Smtp-Source: ABdhPJx0SgoWYQZrhr841aQYRHdcYG2jST3CaeyEkaXR7nLgdiYdMx2XA4SIl+VHJTrcP1M1jYG36Q== X-Received: by 2002:a05:6e02:1a21:: with SMTP id g1mr6630384ile.58.1643392664143; Fri, 28 Jan 2022 09:57:44 -0800 (PST) Received: from ?IPv6:2601:282:8200:4c:4e31:d3a8:3801:7e36? ([2601:282:8200:4c:4e31:d3a8:3801:7e36]) by smtp.gmail.com with ESMTPSA id p9sm13919577iln.61.2022.01.28.09.57.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 09:57:43 -0800 (PST) Subject: Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail To: Sean Young Cc: Alexei Starovoitov , kernel test robot , Alexei Starovoitov , LKML , Linux Memory Management List , lkp@lists.01.org, kbuild test robot , Shuah Khan References: <20220128075346.GG8421@xsang-OptiPlex-9020> From: Shuah Khan Message-ID: <347bae9f-f775-4976-3d27-b0c725211d78@linuxfoundation.org> Date: Fri, 28 Jan 2022 10:57:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E295D14000A X-Rspam-User: nil Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=JOUFeVTT; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf09.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-Stat-Signature: wc7gi5ucu1eiu93u5azybqoo579nmkbo X-Rspamd-Server: rspam08 X-HE-Tag: 1643392664-455913 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/28/22 10:38 AM, Sean Young wrote: > On Fri, Jan 28, 2022 at 10:27:52AM -0700, Shuah Khan wrote: >> On 1/28/22 9:49 AM, Alexei Starovoitov wrote: >>> On Fri, Jan 28, 2022 at 1:32 AM Sean Young wrote: >>>> >> >>>>> ir_loopback.c: In function ‘main’: >>>>> ir_loopback.c:147:20: error: ‘RC_PROTO_RCMM32’ undeclared (first use in this function); did you mean ‘RC_PROTO_RC6_MCE’? >>>>> if (rc_proto == RC_PROTO_RCMM32 && >>>>> ^~~~~~~~~~~~~~~ >>>>> RC_PROTO_RC6_MCE >>>> >>>> So this commit removes the copy of lirc.h from tools/include/uapi/linux/lirc.h, >>>> so now the test uses /usr/include/linux/lirc.h. It appears that this file >>>> does not have RC_PROTO_RCMM32 defined on this system, which means it is a >>>> kernel header from v5.1 or earlier (this was added in commit >>>> 721074b03411327e7bf41555d4cc7c18f49313f7). >>>> >>>> It looks like this machine is redhat 8.3, which ships with kernel 4.18. >>>> >>>> I guess my change was far too optimistic; I had no ideal enterprise kernels >>>> were so ancient. > Hi Shuah, > > I was thinking along the same lines, however RC_PROTO_RCMM32 is an enum > value so a pre-processor #ifdef is not going to work. At the moment I haven't > had any bright ideas other than doing a `#define RC_PROTO_RCMM32 26` at the > top of the file. > One more idea. Let's see if this works. Check for RC_PROTO_MAX if it existed before this commit that RC_PROTO_RCMM32, you could define RC_PROTO_RCMM32 conditionally in the test scope. If not let's go woth your plan of defining it at the top with some info. thanks, -- Shuah