From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D830C3DA7A for ; Thu, 5 Jan 2023 12:17:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D2B88E0002; Thu, 5 Jan 2023 07:17:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05C0D8E0001; Thu, 5 Jan 2023 07:17:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3F438E0002; Thu, 5 Jan 2023 07:17:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D08868E0001 for ; Thu, 5 Jan 2023 07:17:22 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AA2A74035E for ; Thu, 5 Jan 2023 12:17:22 +0000 (UTC) X-FDA: 80320645524.14.B18DA2E Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf27.hostedemail.com (Postfix) with ESMTP id DBEC140012 for ; Thu, 5 Jan 2023 12:17:20 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EEHa3dsN; spf=pass (imf27.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672921040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kwt7t/CJH1y9ow8O0/w8MvRjyKQlEsOGR187S/Ep1Yc=; b=je2Wc+VSHyPZD4kBK9l/zgkIh7+QSN1nRAZTENgKcV4iKDQtLBgtjuU89LNfkmvAxjNyBJ gBoMj2AdFE5ZQaPzqiqHiyD9BLukbvhsWUu2IVzWipz4YJBmHmoP/pfik0NBpwQK4Y3Z+q OTa+Fv1pBFGzSCzUygV/tyWstnlYN8U= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EEHa3dsN; spf=pass (imf27.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672921041; a=rsa-sha256; cv=none; b=ltHo8YW6phV97MjXDu3BlKsBnnSklMceN2gn9BY7Ly7vM3quhKNpqOLgKJtTSdFFiULQPF v3X8SkTLEAnYG2wB9nW3z8eWeWxH5VfXQvCRnWeT3GGxzhIk7vvocyeUeQKCroUTL7gkAf Z0gYSn74QnEbIsH8aP8+MvphpIhPsTk= Received: by mail-wr1-f50.google.com with SMTP id r2so1101054wrv.7 for ; Thu, 05 Jan 2023 04:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kwt7t/CJH1y9ow8O0/w8MvRjyKQlEsOGR187S/Ep1Yc=; b=EEHa3dsN09ZqzdRIQzB3skfi58Ttb6P5m9dQKWMu4EWf45Ny8zFqRTXKGlnuZuykg1 53QIwOHCaSXs7PFlifjY/i6VZj9PKxGwMHB/QzMLbX4IkeSLHqovpz1pLJNPxKZ93iPq 9XJJXV7hVVNb50tQVfE5s4lkaeBMSLkqqCf4oOQ0bC4AzVlJcbXqcqLbZQnnkn1V991b tGYPFkSd1NnFPQsKYy0vByVsTECHhBjlh5+47BFuvFqos3s/VWAiHiAws5SyV8Tk7L6X xzwm6idQBKh0FnyHFHZ83lYgQNzUq57yW15Epyfzx9L5iDiwcnkTVjBrtp8pGtwUadbu 1/dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kwt7t/CJH1y9ow8O0/w8MvRjyKQlEsOGR187S/Ep1Yc=; b=bHu+F0NNYlPBzZVKkFWQeMeRPXY4eHvkDmOq31+cE7DMq0jGwDCZ9QINyHcyirOUjN yTp4MqrMN6k2ws7h+qIMRGIbrFL5PMrRllgq9lnTOE8hv7uOjIpT2Eshte/n+k9XvL1d 2YLc6RnBhrtll3EvlszpBH8nD4wPE+ucRAQeUlXVtthPsG5qdTsZgEcor6rVpI98AEZb Stm0iYtvX+8wclLABhksB4bfdwlAv6zNpo2iRDv2yOVLGrHLnX6tVuq4V5uop4+8hn1W DZG8lDocElvglLHrKaMkQy4jK7v72k2b4kM+B9QJHnMWCBDPxr6WXYSt10C3SR6NYXJx fyfA== X-Gm-Message-State: AFqh2kp6b7HttcGZ5u5VkXzrPJomkaZ4NccZfxjVExqfAUegTuVV9F7Z 3r+4RcmmK/I8sqzi62bQQMs= X-Google-Smtp-Source: AMrXdXtc6CuEAd4hOJmOLbfJkC/PUZxn0pqlC6OaHDUrm2oDJb3Z5ScuShHqV64Hl216ISr93ru+Og== X-Received: by 2002:adf:e703:0:b0:242:15af:27f with SMTP id c3-20020adfe703000000b0024215af027fmr33092970wrm.28.1672921039487; Thu, 05 Jan 2023 04:17:19 -0800 (PST) Received: from suse.localnet (host-79-56-217-20.retail.telecomitalia.it. [79.56.217.20]) by smtp.gmail.com with ESMTPSA id y2-20020a5d4ac2000000b0027323b19ecesm34747506wrs.16.2023.01.05.04.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 04:17:18 -0800 (PST) From: "Fabio M. De Francesco" To: Matthew Wilcox Cc: Andrew Morton , Ira Weiny , Sebastian Andrzej Siewior , Alexander Potapenko , Bagas Sanjaya , Andrey Konovalov , Tony Luck , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: Remove a sentence from kmap_local_folio() kdocs Date: Thu, 05 Jan 2023 13:17:17 +0100 Message-ID: <3474652.iIbC2pHGDl@suse> In-Reply-To: References: <20230104121845.15770-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Stat-Signature: 91c6i1q1u6npxre8kf3amdinz3t5ysoy X-Rspam-User: X-Rspamd-Queue-Id: DBEC140012 X-Rspamd-Server: rspam06 X-HE-Tag: 1672921040-60022 X-HE-Meta: U2FsdGVkX18GnR9Y9vU91NTcsA126KNJOw/mCDm1w7Tqe1xv2/irZQKiYu4RwcIKUmjzU67e/nZE3sF8H2MCV1VzDqqibpgjBefQAxRKBI+FPdvyfseRQazPmSmNkl6GG4xnNNtvyzJJt4vQTUE7tlr25xLwcZsSD04VOHnZqLTMGpkcjWex18YKx/axjrKy4B+Y4jBnKb8AC+/KSzPwidebcqdx3h2NG+lMsR0kvX5KLhchn1uOq0/mR1VypadQWMf0NPpqsGTdN1yLS6VFw8BqQazqMRgPBGt1QaX5XchLX5KZTfuQwJpcaEKjQksr/P+m6jlpFC5ko5eHgRk7mD6vueyMgm4OLSBlyx1KaIUYiN97Zmvf1cCX9soctNtD9h90o/lOjc7bjUcAwJQh+gg9gliAoTrSf+/ZJZCCzy3a7CpwokiKdnINzgUoLruZGcOaUKA3o0srTPcnz2qP+jnhLAVtXRwAmI9IzySW8xqi8NevlhTUkOfd02u9g7DATr9b56CC9q2sd67jaUCMRM4f30/E2+jG6bypdG97Zb6UufhvUTZirpI38mLhooJN4ShUtOUH0FBOYANHUajA3oTZXOC0QPqKc9qJex4TbXAkVZkre5sFqlOexk1mWIZSqAO49GKvUGfbxq9bx8FY/aSe7c7GLsQpy9PHjYbQqwv2ZYLq2Oc5FX8TTJ8mVQ/czeHpsFDw/oZV3eZJun8PGNkk+iPH3eGXiLFREmSSs3WlgrH+1GtP0s6dkRG1JyoS8U+9EsGbJG7A91kBqsvB6H/68ThMcHKLDyK/QhQmrlkfSWRhMXo9F/srmXk+MsY8bSY4hzDPBSoEvWp1JIFNq87nNayn/Q5GWY8bf8WbChXBD971WJ26As61dXK5jhaVWfoeoGOv12LJEc04UKPgUP63v4JawS2QoOJNluX2UWF1DCwoNctl8LCBBg08nrXUb1vnGECPnCLaeI7v2km 9r3pqpUV juQIbOFs5WMjM38BFQ/b7HQ9a2vi8Qkbqjh6LNBu8DLn/Sq6QttY6IcrS5nQaZR/7TKe3TwlMEvQaQ4HovtJrR5Sc11qBKM0eedGtgvskBIEjO60co+7Ind7ncXUvCKKxMMJmhE3KIRjfce4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On mercoled=EC 4 gennaio 2023 15:40:26 CET Matthew Wilcox wrote: > On Wed, Jan 04, 2023 at 01:18:45PM +0100, Fabio M. De Francesco wrote: > > In the kdocs of kmap_local_folio() there is a an ambiguous sentence > > which suggests to use this API "only when really necessary". >=20 > Looks like you removed it from kmap_local_page() docs in 72f1c55adf70 > after I copied it in 53c36de0701f. That information should probably > also be in this changelog. > Matthew, =20 I just added that information in v2 (I didn't know that I should have bette= r=20 added it - thanks for letting me know about this practice):=20 https://lore.kernel.org/lkml/20230105120424.30055-1-fmdefrancesco@gmail.com/ > > > * While it is significantly faster than kmap() for the higmem case it >=20 > Also, s/higmem/highmem/ (both in the kmap_local_page() and > kmap_local_folio() docs) > Since these spelling mistakes are un-related to the purpose of the deletion= , I=20 fixed them in a separate patch: https://lore.kernel.org/lkml/20230105121305.30714-1-fmdefrancesco@gmail.com/ Again thanks for commenting my patch and suggesting improvements. =46abio