From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68CDDC021AA for ; Wed, 19 Feb 2025 11:01:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 030A028021D; Wed, 19 Feb 2025 06:01:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F24A128021A; Wed, 19 Feb 2025 06:01:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4E7128021D; Wed, 19 Feb 2025 06:01:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B224F28021A for ; Wed, 19 Feb 2025 06:01:45 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 454EA515CB for ; Wed, 19 Feb 2025 11:01:45 +0000 (UTC) X-FDA: 83136403770.14.DEE26C9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id 88D66160004 for ; Wed, 19 Feb 2025 11:01:42 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zXkIKhes; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=chs1dt7A; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zXkIKhes; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=chs1dt7A; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739962903; a=rsa-sha256; cv=none; b=QZCbGwpM6MLh+cmWr63LXsrps78yzrsNGF4U999gLUaXG0Jcwi/+qywxD1AYxEaqb24V7t EzZJnhGY0C63PT3xXvz1BeP+TdUR/T1ZssWMcGTdb9eesG7o/yf7YfkAsF4GjLuHhQ0Ijm AD/0uibDG/q6rlhYAeOPgajsxsfOkjY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zXkIKhes; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=chs1dt7A; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zXkIKhes; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=chs1dt7A; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739962903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UQ39+Q6zWe5FH6m8gxGxNwSLfvpsDPqpS3BC6AkGyLA=; b=Y+j4I0WEEl9IVlzlF1eVdnYsaKqenlsnMqXjzTdZX95AwJHZyyOcRGe4Mj6sLbvQn9n3bY ++yeoIoDgicycFXeU7livV/T+IL+50ZNSdH1VQkCAF1OI/8Y08J+eQjjUtphKniHTO4gZe +/RK5vQqfSGURGdYbOqVqzxF/S0IxLM= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 98C5521A7A; Wed, 19 Feb 2025 11:01:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739962900; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UQ39+Q6zWe5FH6m8gxGxNwSLfvpsDPqpS3BC6AkGyLA=; b=zXkIKhesFTquq+VTtJw95pv57tG0q0BLMTqfmk8ZpYf21ZaJTqOzdg6C/ip9dgqZ2LJWOq ALiKplTFjZaHMUTQdRaRUSnXBaXUgN590yGhS0uwozQ4BMOnQOwuiSyYHAWSzDdFHOrdm8 WzjissaB/8qu5EJvoFmavadOY7R8y20= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739962900; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UQ39+Q6zWe5FH6m8gxGxNwSLfvpsDPqpS3BC6AkGyLA=; b=chs1dt7A9jGiX+Cw7lt6J0giTARWgf18O3T27Xk6GxYVVne4/1Ug4mq9Df++SfuqKsnriK TcCo5htQqOofKzBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739962900; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UQ39+Q6zWe5FH6m8gxGxNwSLfvpsDPqpS3BC6AkGyLA=; b=zXkIKhesFTquq+VTtJw95pv57tG0q0BLMTqfmk8ZpYf21ZaJTqOzdg6C/ip9dgqZ2LJWOq ALiKplTFjZaHMUTQdRaRUSnXBaXUgN590yGhS0uwozQ4BMOnQOwuiSyYHAWSzDdFHOrdm8 WzjissaB/8qu5EJvoFmavadOY7R8y20= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739962900; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UQ39+Q6zWe5FH6m8gxGxNwSLfvpsDPqpS3BC6AkGyLA=; b=chs1dt7A9jGiX+Cw7lt6J0giTARWgf18O3T27Xk6GxYVVne4/1Ug4mq9Df++SfuqKsnriK TcCo5htQqOofKzBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7DA04137DB; Wed, 19 Feb 2025 11:01:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id U+JMHhS6tWe6UwAAD6G6ig (envelope-from ); Wed, 19 Feb 2025 11:01:40 +0000 Message-ID: <345e4f5b-2427-4964-b0f1-e6f72e48f409@suse.cz> Date: Wed, 19 Feb 2025 12:01:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_alloc: Clarify some migratetype fallback code Content-Language: en-US To: Johannes Weiner Cc: Brendan Jackman , Andrew Morton , Mel Gorman , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed References: <20250214-clarify-steal-v1-1-79dc5adf1b79@google.com> <20250214212647.GB233399@cmpxchg.org> <764394d9-592c-4d68-8910-67362dd8810a@suse.cz> <20250218203830.GA1264207@cmpxchg.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250218203830.GA1264207@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: wpt55c8gtnzskmunr9k1owz1dsk4xszt X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 88D66160004 X-Rspam-User: X-HE-Tag: 1739962902-926925 X-HE-Meta: U2FsdGVkX18GopgDp0D8fhGzDIlcH7F99E6wK9zKBukV6tRH65aCwtZKS/VF/uKr1e/0OJJoq9drO3Gj+V0gnjQQGZAf6MNgud3obciK/TxHUv7onbscfF0s4PpC64zrV6vgo9ptyuLuC3X0ZILkA0ZQCdx8i9Jbrn8didF1m2Ieky+jjA+GcMDNS5nnszRrsibJ9hCbqwRFhy9wH6MjujwcK7irVJSE8t4gGqfjdzQu+lpZiK/6TStQiw16C7ezMiyu7QlKB+wz4JWaniqkSgHThw38Vli0ByeHM52g4tQO01svFGkUJSe8jMw//VVJTaAabNH3kUiFUrPtcu1nu0rrQ0zKNb5uoLZi5Pdso5X5CIL+doh9Pa8WVrKyQr5M7W5gWni/y8rWjPz4i1KS29+66p4nY3zYJgL6wvEetTZhwG3t2qc2zM3pJGHEnr23UdxmUxbvmKOWif+pvUb17tHiPg9e8bI12Oa1UkOr9bBtRbXr5lFRg5BcSzeJoCFBxuANK4ngTOO2G5uT/Oo7jH5Gegg8Upm7ydTVGO4D4HKNs2FadNMViIyR/TaFOSZEyp+C3chYQ3RiZdvsuK0UML0OMhQF2eqArsRyLR+EQoX2Lb9z76Ahvp5gqa9RXpBBhIlg93McmcH3waY07zv2FJhMDLrB5MxfgIc81oQ88GqOXOh8XvcoyF86MeqwlDj5Lcr7i6vIBmHLtn+uy9LQFXvuUmo5cTB5p3vFlp6AfvA/R2w3ipkMzq/YIK6Waw64d9U6ntGm8tbHWw0H3P9vFRloyHyFCXmix52vWSJcuf4SK6RzH6f8mhCmP+tGx2+n/ujktyfHt56CcRVolEIylO1HBMp3YWmlBBF7BmULxz+sDwSLk6Gd+PDS5G+JNR+tIiKZHKR0U0DbChe703N4rbcK8OIabjDqKgEWIxhEw5/C+nbeK9wu0cjupPTgbg/g3qsk4yZWFRdahq6PP4e SY+neFHK eK5yD8J2pvB7Zt8qAscn5m75N2Ezh7dxiKXkqf1+vFh3om3HM4elK6pp53hCA5cAgA2PZAkI+L9xAygIR2h+954lYdiPRKxEiRO9Hlvsvwt1ai0kdH1yFci3gRpLFMng0XuwRSE5ZiUqWCay/ogQnxXmy7ZbdSH16aSBE1cI76A49TYRx7z4dIbg/R4/uXs0T8DO42tj9a+Gr6te3s4ocZ8dr0Z6w1Y98m7Csd+V4XPF0KUeVuZah8zuG4s5J8XtphmjMipNT8aAGfKlkMibDMjtWfBgiWf5EXeu1kXObn7PEAdbIIFh2ocU5yNElgg3azGE2sk5t7gD7+E4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/18/25 21:38, Johannes Weiner wrote: > It still makes sense to have the two passes, though, right? One pass > where we try to steal a whole block starting from the biggest buddies; > and then one pass where we try to steal an individual page starting > from the smallest buddies. Yes. > Something like this, completely untested draft: Looks good to me!