From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C751FC4332F for ; Thu, 14 Dec 2023 09:02:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 541C78D00A5; Thu, 14 Dec 2023 04:02:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F1F38D00A2; Thu, 14 Dec 2023 04:02:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36B948D00A5; Thu, 14 Dec 2023 04:02:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 25EBC8D00A2 for ; Thu, 14 Dec 2023 04:02:35 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F100F1C130C for ; Thu, 14 Dec 2023 09:02:34 +0000 (UTC) X-FDA: 81564833028.23.67F44F4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 8528B18000C for ; Thu, 14 Dec 2023 09:02:32 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B+6wPTZL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702544552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h1TM7UKmcJlXLTWCpMTjmgDFsXanKawH+R6EnWS6jFo=; b=GIbo6955dBsGL95VChKdRlXI5E+pG9SgkcHMMiZeFhgTfjJFGx7mBgbULxalVc+lpryGuD Iq8rayTgX/DrMByeSMhOrMOPlaVlx26JcVWySjSwve3yXXQCvZ8orPS/1G6xdXTYbRVdhF M26CrZj9N1aDyXcVKD2iyvHgx1WHkRc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B+6wPTZL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702544552; a=rsa-sha256; cv=none; b=ZWCji4clPp/9dwP8bC99WRDo42noZt+4OFedej2CxgfbbfRjxk6eKCtzHG15+5fZZwouX8 C0KFCf2SCJOo9F1174oAv+upmjOy4ZcvrGldt44LsFkhMQygZFZY6IP/ToEBqo86neObsT IUVlwEupZOPtPKeZPIFkfYp9HZNnZZA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702544551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=h1TM7UKmcJlXLTWCpMTjmgDFsXanKawH+R6EnWS6jFo=; b=B+6wPTZLTjKW0X+PUL0yY8bMmErHBYXTh5QrqeLtTfCFXge9qoJVheU4wdhcezY6kGyCQI /e58Vh2oNhl/CnacweWXCtwVMZqTx7ah0lbha/HIeM51naT/69o/ne56Ai+CgULeabVu3R FjQJ/zGgBjeBucudm9TrmnybOLh3piQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-v96eWpG1NRyIfq8QPyWrKg-1; Thu, 14 Dec 2023 04:02:30 -0500 X-MC-Unique: v96eWpG1NRyIfq8QPyWrKg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3334b1055fbso6550674f8f.2 for ; Thu, 14 Dec 2023 01:02:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702544549; x=1703149349; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h1TM7UKmcJlXLTWCpMTjmgDFsXanKawH+R6EnWS6jFo=; b=MnQZqEgpaPtBq1Ewo4cl8OS3ICF37wcG8OJ/xx/Uwq1AGcNotFXRrJ1e6v+5V/fzxs mrt1BQ3vnOMUJ/qqX8gHGPjP/t0nrdRa0J/35baNIvp78W6mX6CK5ptZz87iA2nwT9pR HisI6935s2G152cjxV89o10SbcMspUsua6K30IgKn9xmX0uZQGKzfpQ+f7bbk/jWVVEv LLYENLohrm5RbpZTIK3uga8eEVMjJB5Amtz+Q0rwAUl1XQ5i+s007WzCbFeDTBQ0ZGVf 6+d26onNYr1SOvCN52PjunlPpfjcs2ucNXb4CBk6Ycq8K7E8kYfT3jwV2VRzjoDHywzb KyAA== X-Gm-Message-State: AOJu0YzBWAKrtNSqm4t9L42ah+vpG6RHSSWLY1gne4gvrTCLVown0plo f2QgnxDtWe3y2Wf/MK9oXxrP+2Qyw9fKsSqWZxfUYVMDnMJ4PKTiZBmz1FkfaCPjbS9mx6+CeVH bOgOAAUGNKtM= X-Received: by 2002:a05:600c:3423:b0:40c:224b:a72 with SMTP id y35-20020a05600c342300b0040c224b0a72mr3152306wmp.147.1702544549087; Thu, 14 Dec 2023 01:02:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHOBDn00paajws5P0gB/8daVj/BLkCqfKKSO5c19sQQxL5edLeTHbvcV/FQANCLcq3HuvyAHA== X-Received: by 2002:a05:600c:3423:b0:40c:224b:a72 with SMTP id y35-20020a05600c342300b0040c224b0a72mr3152273wmp.147.1702544548569; Thu, 14 Dec 2023 01:02:28 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id m27-20020a05600c3b1b00b0040b38292253sm26220931wms.30.2023.12.14.01.02.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Dec 2023 01:02:28 -0800 (PST) Message-ID: <345a414e-42df-4b2d-8425-2b605c46d2a9@redhat.com> Date: Thu, 14 Dec 2023 10:02:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test To: John Hubbard , Muhammad Usama Anjum , Mark Brown Cc: Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, ryan.roberts@arm.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Peter Zijlstra References: <50385948-5eb4-47ea-87f8-add4265933d6@redhat.com> <6a34b0c9-e084-4928-b239-7af01c8d4479@sirena.org.uk> <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com> <3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com> <3d22f342-280f-4a44-87f4-8cca291cfce7@sirena.org.uk> <0f97db9c-5b86-4f56-8463-2520fe79f709@sirena.org.uk> <2e4a719b-f2b3-48db-99db-d96040d78b12@collabora.com> <0d68fe7f-2a96-467d-87b0-52db36704e1d@nvidia.com> <926b42f9-3689-480f-8dd5-78fc0ee6088d@nvidia.com> <783a4178-1dec-4e30-989a-5174b8176b09@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8528B18000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bksarasnx3oqejkob815oyxujnfqh8qf X-HE-Tag: 1702544552-788777 X-HE-Meta: U2FsdGVkX1+6uf1U7mfEYMOpSuVakuAS/s3x1IVSQ64ssHqX008ladnSMqWSo5o9IkDJ0zFJ2hLQfm4DZH7uzyK+FUeHxzvWesOySv5r5zUpH1XHb6hw65S22Fsq8fNGdl8oggVWu92rTGLeeFZdCwq0Zb4MgW5WeqE8KcPGwxTw+szmf4sSRLESBTiBEP37oYIfGRhigf235Kad1CeVrVRUymFR3urwco+3y31Qz+CUq+/+IdzE1HgVYBtkcy+Fb1TyXDacank1++sK7a7euK+JumaRnGrbvD8Hbh0ev6i9/fmEFCqpJyCKgASOCuKqmhaYu6SZOAVQXHpkkaaWA4ydyTSw7u+HVwlXO6Mi2AKjL3iCJ9cqMEVg2gNz8PXw9GEPG8OZ0P3DKeuCaX4luEH7Wsp8TPn4wgI3pCQcwXvMkU0eDY0SQXNzeFW0IXoa9pHThgxvittUw0f618+T1/E+D4HfIM9yL3fvK8Nq8wFqN+FuEJgqnakyh/5XA1VBSS5HNvjBUyKZjBS39OIOSQED0MR8e40/YRAKQIYSN60HExMaZkwviqlI1+PyMTmlN/36SjfZ9V4qfIkXA1iMUJCJg5Zmk3CoaTr75HLurDPKPfUb4zyGZsHUGLHo6f/ETjtDBkyz8y/9NArohU3TfGWEggL68YHAzCzidPtWVQ5/1YM77CYVTX/4vjMv6Rz8Bj2xmMQ77LYBpeN56IBQ+ldXGQhY/2jaBl/g6L/r6kR5xQzNDj2HmW/mf1rtMpOVtDMLO+nR3xg53CtDfHXPMXG2/8z56cFMCpqg7AW+P6HhglJELgag/4YEELlYh1TdBwglUhEsEXrAzOcPmqoJQjdF6eDj4drC22wklQ5W3sCD10joFoauhvl54zyvH9I0xmn7UiuPs9Y4u16DqXXv2I1rWPjXq2szAWD8duU7jeO8GO2gh/Xn4h0Whk7NdqZN1ex37oph09K1D04uSio u3sIhUUI KYhEyVBAPS00mZgjsvOzs86TnQsJODM1qPTZGRbXYgeTAsJ98HP8e/ZDVMkOEdYHnamN+IVwWydI6SPEKO9AycTfJbnx7lGUm/kSDN+IOXva2SJl98t1Im401oZEunUJPko86C6cgjUx8Pl0LEASuBl9WQki3mtDiwsDl+fizqspQ5iHJNoMp+Kcn0D4V2G37BfsBkSpWbGI5+yuN+dU0b0AzIblAou8LGEXIoQ79ErPmgDxIrGg81mWuUxkN2/2F05/OGiEG6ITLGuxSEiT4KTNySlxAcMFtGUATeGaJEJ0DPbZTMknce7Mnk+bgSLlQOhiCgTgOlF/8MC6VCDDUBdoFSQxfohIkZo2eiXa6P1OyhHiKCbNLkR1BbsMVdiYB5HoyUvNSy/snSIKV1rDZblrbINRPVrl53/fqU515TfNlfghqq78rr2gjF34GJDmlP416vFkZH3B5H0yjuWA31Z0n7fhBwFA54/d3JtQ6hFNHRKoxF2uQnrDDEoxknVME05EGjTPozPrBQ0v/T6FpjBy79g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.12.23 23:01, John Hubbard wrote: > On 12/13/23 01:59, David Hildenbrand wrote: > ... >>> Another variation though, would be to run "make headers", and snapshot >>> some of those files into tools/include. >> >> ^ this is what I had in mind >> >> If you're writing a test that needs some new fancy thing, update the relevant header. >> > > OK, and Mark Brown's nearby response [1] supports that, as well. > > Thus fortified, I plan on doing the following steps: > > Step 1: Do nothing about the revert patch that I sent earlier, thus > allowing it to continue in its journey (so far, Andrew has moved it into > mm-hotfixes-stable branch). > > Step 2: Send out a patch for a modest part of selftests/mm, that uses > this latest approach, and see how it fares in reviews. All sounds good to me! -- Cheers, David / dhildenb