From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FD3C3DA4A for ; Mon, 19 Aug 2024 16:51:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 266626B0083; Mon, 19 Aug 2024 12:51:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2167C6B0085; Mon, 19 Aug 2024 12:51:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DECD6B0088; Mon, 19 Aug 2024 12:51:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DE4686B0083 for ; Mon, 19 Aug 2024 12:51:25 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 82C54A8D7B for ; Mon, 19 Aug 2024 16:51:25 +0000 (UTC) X-FDA: 82469585730.28.6E4D32D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id A1E3A20006 for ; Mon, 19 Aug 2024 16:51:23 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S/S85/Wj"; spf=pass (imf03.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724086205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=baSDQDw5G5UUnctFQXilEPZrnly/docCCU+r/lFMOuI=; b=lykdGNzrVSlvSNHpuSOB3p4ZtmvHKvqO0PWXPAX67XoxD1ACOYXFD05gzNJPsWnjaaFZLt qJ3P6VqWLHAu0iu0ZgskD/IXkVs96buJY9joFAjNqFJ35EJD+3TMpmMR2S3iagXtl5eW0X rKMZb3c30nWaeJGM3rRXv1PgyXTW+B4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724086205; a=rsa-sha256; cv=none; b=g5bD8o0VmcO0Yhr9h2UytZZpANZPB4IL8M2pCdolOvZqiPyKao4/jxAr/d3aWEe1yOGqYV 80+PVHMpsqS/1iZLiThVjrVsfTH2kJ2tCiYTj9bcAM9A7BEVfLJMXVQa7p+HbFzVc44fw9 ntsljEoSzcdE6ZrPaL26V1wfjIgGmzk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S/S85/Wj"; spf=pass (imf03.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724086282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=baSDQDw5G5UUnctFQXilEPZrnly/docCCU+r/lFMOuI=; b=S/S85/Wjo7jxTXZat1uYllQ/q9dE7PhAf2okS7gE3GzSO4NzLlq1No7ke/VikQV6ck/lrc I9NmRoDuFLyI/H1/nrSILoMob72a0eMxsbjmrnIrUy6QjKDnbJkwN73SH+DprKAaW/dTSX kjHpNbd6MmROVTk4cRuuyJPCXc7yUPk= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-rWSG64mtNlKc-GWHIcJm3Q-1; Mon, 19 Aug 2024 12:51:17 -0400 X-MC-Unique: rWSG64mtNlKc-GWHIcJm3Q-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BB3B21954B19; Mon, 19 Aug 2024 16:51:13 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.30]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E19E01955BF8; Mon, 19 Aug 2024 16:51:07 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <2924797.1723836663@warthog.procyon.org.uk> References: <2924797.1723836663@warthog.procyon.org.uk> <20240815090849.972355-1-kernel@pankajraghav.com> To: "Pankaj Raghav (Samsung)" Cc: dhowells@redhat.com, brauner@kernel.org, akpm@linux-foundation.org, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, djwong@kernel.org, hare@suse.de, gost.dev@samsung.com, linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com, Zi Yan , yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, john.g.garry@oracle.com, cl@os.amperecomputing.com, p.raghav@samsung.com, mcgrof@kernel.org, ryan.roberts@arm.com Subject: Re: [PATCH v12 00/10] enable bs > ps in XFS MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3455346.1724086266.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 19 Aug 2024 17:51:06 +0100 Message-ID: <3455347.1724086266@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Stat-Signature: emzbq3ps8jmzz3or5yifke4bfcbu7mzo X-Rspamd-Queue-Id: A1E3A20006 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724086283-16100 X-HE-Meta: U2FsdGVkX1+REVM1JzXfzOyBab4wzWftqRSW7kHc4tCJuBv5wVg0SP+KIBYK8Bq7xdNZ/oM+HApfwEXE819b1Kmc46H4n+RwzTug4MI/hF4PlQv1Vcc8+DpDfIiDxNNbAbz3lfMWbWaUfcEMQrnZ56Qx1+/MBUBsRMMPLDBXvKhVNTjSuAVAqlZgUPYlwB+YwTALBnFB77m7DALcxRONUsuowtHDREtYuZ7o6OS6MFy67LJEDn+Ea1nG7KSQBKfMiH7tQO3NWe8TA7LI+Nd7KZHcJQn6DbshNixXSrqFyCeb37om0M8jrJMGdHq/C9nwGl/pFRzM7z2g1Nx1+gRTSD9xoP8pMyCzhmSOS0kktN3gO3iEhiW9GaXTu7f3sVwItM9ILNC2DaEH96wDmmAfp9PcdmCgLMLglMuTOzvIqbLc6+sVusu4zWM7glaD5ngb8HCiAXWYRiol+nR9To6zJCp4dvO6D0wgTGSlnJJvfG/dwVidImtn5k7ASb3sabVazntVPEPVz+cpvUGyUhmXS9Rfz3p/bxjmErC22nAT6xAR4lv7tnuwcNIeop8Q3fqHV1iYXortnSyaebCTTbP0JAQuJlOysia++rI9L9Cona/6PLkGTnuofpsLDefOYJdJIIGupcUl5dV/VzoY2m7ZsA/YIuEr09QeELVl1wXEWh3frbIrmuUtx8Da8nf8E4JS4akBQNrkwllRH3AINIr8FgKuBldf4Ay3onh0O2/XNT5s+nUF0FipHibwlq35bp3+wB15HxZGFjki++splewZUEqSfHtcPyqr6tM+ZzwGjS1wTnjS2qpasACObbbr4xlxsYAYEYT0DatV8GOGTogvCxJtzmFm1preLsWHQLmPxop3PCd5kdK3sdpVrFuLB+Q/m1Bg7p7FoayL/zxGdcOstkUu/H8zJ3/tYtaOwcu+qO/6LAuLBmLFx5G6U3/udl8l8j8MOU7l17UnGAY0bva rqFClB1h ot2Lk0n0XGp8g+NwYH70dj+atQbQEOo1RfNRHgZMCN1pp08+ZiYU/qq0UF09r7Clc/O4zvMOtG0185eKlUJtqHb3a2ajmFHk9vAgEKrFpa81YZYt/ptH+IPuNUfkXt4q8PhU7gLXYetvrR3MVj7GJTgtUldHjRGFDhZGYufwfYCVI/SYosZ1HXR5XGyccKqTW/7Gdq40pIfLQ8MvIAs7gl5uS/jUstEQOzsTc+Wz4sLWVH01Ef0OftqsqEBTBKwwelJNLj8L5Dqnxo/GNHwqWkyAIACPPkTi22Pdy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Okay, I think there is a bug in your patches also. If I do: xfs_io -t -f -c "pwrite -S 0x58 0 40" -c "fsync" \ -c "truncate 4" -c "truncate 4096" \ /xfstest.test/wubble; od /xfstest.test/wubble I see: xfs_io-6059: netfs_truncate: ni=3D9e isz=3D1000 rsz=3D1000 zp=3D0 to=3D0 xfs_io-6059: netfs_set_size: ni=3D9e resize-file isz=3D0 rsz=3D0 zp=3D0 xfs_io-6059: netfs_write_iter: WRITE-ITER i=3D9e s=3D0 l=3D28 f=3D0 xfs_io-6059: netfs_folio: pfn=3D10d996 i=3D0009e ix=3D00000-00001 mod-n-= clear d=3D5858585858585858 xfs_io-6059: netfs_write: R=3D0000000c WRITEBACK c=3D00000002 i=3D9e by=3D= 0-ffffffffffffffff xfs_io-6059: netfs_folio: pfn=3D10d996 i=3D0009e ix=3D00000-00001 store = d=3D5858585858585858 xfs_io-6059: netfs_sreq: R=3D0000000c[1] UPLD PREP f=3D00 s=3D0 0/0 e=3D= 0 xfs_io-6059: netfs_sreq: R=3D0000000c[1] UPLD SUBMT f=3D100 s=3D0 0/28 e= =3D0 kworker-5948: netfs_sreq: R=3D0000000c[1] UPLD TERM f=3D100 s=3D0 28/28 = e=3D0 kworker-5948: netfs_rreq: R=3D0000000c WB COLLECT f=3D2120 kworker-5948: netfs_sreq: R=3D0000000c[1] UPLD FREE f=3D00 s=3D0 28/28 e= =3D0 kworker-5948: netfs_folio: pfn=3D10d996 i=3D0009e ix=3D00000-00001 clear = d=3D5858585858585858 kworker-5948: netfs_rreq: R=3D0000000c WB WR-DONE f=3D2120 kworker-5948: netfs_rreq: R=3D0000000c WB WAKE-IP f=3D2120 kworker-5948: netfs_rreq: R=3D0000000c WB FREE f=3D2100 xfs_io-6059: netfs_truncate: ni=3D9e isz=3D28 rsz=3D28 zp=3D0 to=3D4 xfs_io-6059: netfs_set_size: ni=3D9e resize-file isz=3D4 rsz=3D4 zp=3D0 But ->release_folio() should have been called here because netfs_inode_ini= t() would have called mapping_set_release_always() for ordinary afs files. xfs_io-6059: netfs_truncate: ni=3D9e isz=3D4 rsz=3D4 zp=3D0 to=3D1000 xfs_io-6059: netfs_set_size: ni=3D9e resize-file isz=3D1000 rsz=3D1000 z= p=3D0 od-6060: netfs_read: R=3D0000000d READAHEAD c=3D00000002 ni=3D9e s=3D= 0 l=3D2000 sz=3D1000 od-6060: netfs_folio: pfn=3D10d996 i=3D0009e ix=3D00000-00001 read d= =3D58585858 od-6060: netfs_sreq: R=3D0000000d[1] ---- ADD f=3D00 s=3D0 0/2000 = e=3D0 od-6060: netfs_sreq: R=3D0000000d[1] ZERO SUBMT f=3D00 s=3D0 0/2000 = e=3D0 od-6060: netfs_sreq: R=3D0000000d[1] ZERO CLEAR f=3D02 s=3D0 2000/20= 00 e=3D0 od-6060: netfs_folio: pfn=3D10d996 i=3D0009e ix=3D00000-00001 read-d= one d=3D0 od-6060: netfs_folio: pfn=3D10d996 i=3D0009e ix=3D00000-00001 read-u= nlock d=3D0 od-6060: netfs_sreq: R=3D0000000d[1] ZERO TERM f=3D02 s=3D0 2000/20= 00 e=3D0 od-6060: netfs_sreq: R=3D0000000d[1] ZERO FREE f=3D02 s=3D0 2000/20= 00 e=3D0 od-6060: netfs_rreq: R=3D0000000d RA ASSESS f=3D20 od-6060: netfs_rreq: R=3D0000000d RA WAKE-IP f=3D20 od-6060: netfs_rreq: R=3D0000000d RA DONE f=3D00 od-6060: netfs_folio: pfn=3D10d996 i=3D0009e ix=3D00000-00001 read-p= ut d=3D0 kworker-5948: netfs_rreq: R=3D0000000d RA FREE f=3D00 David