From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3303C4708F for ; Tue, 1 Jun 2021 12:15:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6BA3C613AE for ; Tue, 1 Jun 2021 12:15:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BA3C613AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F32C36B00C5; Tue, 1 Jun 2021 08:15:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F09036B00C6; Tue, 1 Jun 2021 08:15:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D832F6B00C7; Tue, 1 Jun 2021 08:15:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id A35E56B00C5 for ; Tue, 1 Jun 2021 08:15:56 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4169598B6 for ; Tue, 1 Jun 2021 12:15:56 +0000 (UTC) X-FDA: 78205051512.23.A0E10D9 Received: from so254-9.mailgun.net (so254-9.mailgun.net [198.61.254.9]) by imf24.hostedemail.com (Postfix) with ESMTP id EAF69A000271 for ; Tue, 1 Jun 2021 12:15:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1622549755; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=tprHWYokWxxPsEVWwyMkMhvSmSsooYLul99ouTewZiU=; b=oh2L8zLBiaVci3eDakvsfbaPwyMw/4qdZpHHocd6naZCEfA6dxvz22zyyqw2vVLLn9NgjI/b MOnZjcx2owOZbHa2q6eh1gAV7Wvqdart/FOtXCEM5JwTBzMUvi8RkZWumVarxIQX6d+exrAS d2gZAxDYHaSHBs8SUEkhT2LBM5E= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyIwY2Q3OCIsICJsaW51eC1tbUBrdmFjay5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 60b624eaf726fa418852bf90 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 01 Jun 2021 12:15:38 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 74E50C43146; Tue, 1 Jun 2021 12:15:37 +0000 (UTC) Received: from [192.168.0.105] (unknown [49.204.181.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: faiyazm) by smtp.codeaurora.org (Postfix) with ESMTPSA id DAAD0C433D3; Tue, 1 Jun 2021 12:15:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DAAD0C433D3 Subject: Re: [PATCH v8] mm: slub: move sysfs slab alloc/free interfaces to debugfs To: Vlastimil Babka , kernel test robot , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, greg@kroah.com, glittao@gmail.com Cc: kbuild-all@lists.01.org References: <1622542057-14632-1-git-send-email-faiyazm@codeaurora.org> <202106011959.5wcQP2E6-lkp@intel.com> <96578f05-79a0-96eb-c015-02e8640e6016@suse.cz> From: Faiyaz Mohammed Message-ID: <3449cf29-3c21-69e2-d410-31a5730d4574@codeaurora.org> Date: Tue, 1 Jun 2021 17:45:30 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <96578f05-79a0-96eb-c015-02e8640e6016@suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=mg.codeaurora.org header.s=smtp header.b=oh2L8zLB; dmarc=none; spf=pass (imf24.hostedemail.com: domain of bounce@mg.codeaurora.org designates 198.61.254.9 as permitted sender) smtp.mailfrom=bounce@mg.codeaurora.org X-Stat-Signature: gh11zz8fbymoyf6mg6651rscezkbetbw X-Rspamd-Queue-Id: EAF69A000271 X-Rspamd-Server: rspam02 X-HE-Tag: 1622549738-769647 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/1/2021 5:44 PM, Vlastimil Babka wrote: > On 6/1/21 1:08 PM, kernel test robot wrote: >> Hi Faiyaz, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on linus/master] >> [also build test ERROR on v5.13-rc4] >> [cannot apply to hnaz-linux-mm/master next-20210601] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: https://github.com/0day-ci/linux/commits/Faiyaz-Mohammed/mm-slub-move-sysfs-slab-alloc-free-interfaces-to-debugfs/20210601-180903 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c2131f7e73c9e9365613e323d65c7b9e5b910f56 >> config: i386-tinyconfig (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 >> reproduce (this is a W=1 build): >> # https://github.com/0day-ci/linux/commit/9540acc4691d680b7124d8daa1a2eb98a97ee19a >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review Faiyaz-Mohammed/mm-slub-move-sysfs-slab-alloc-free-interfaces-to-debugfs/20210601-180903 >> git checkout 9540acc4691d680b7124d8daa1a2eb98a97ee19a >> # save the attached .config to linux build tree >> make W=1 ARCH=i386 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All errors (new ones prefixed by >>): >> >> mm/slab_common.c: In function 'slab_caches_to_rcu_destroy_workfn': >>>> mm/slab_common.c:452:3: error: implicit declaration of function 'debugfs_slab_release' [-Werror=implicit-function-declaration] >> 452 | debugfs_slab_release(s); >> | ^~~~~~~~~~~~~~~~~~~~ >> cc1: some warnings being treated as errors > > Oh, right, CONFIG_SLOB. > How about moving the ifdef-ed declaration from slub-def.h to mm/slab.h and > discarding the slab-def.h empty one. That will take care of SLOB too. > Yes, doing the same. >> vim +/debugfs_slab_release +452 mm/slab_common.c >> >> 427 >> 428 static void slab_caches_to_rcu_destroy_workfn(struct work_struct *work) >> 429 { >> 430 LIST_HEAD(to_destroy); >> 431 struct kmem_cache *s, *s2; >> 432 >> 433 /* >> 434 * On destruction, SLAB_TYPESAFE_BY_RCU kmem_caches are put on the >> 435 * @slab_caches_to_rcu_destroy list. The slab pages are freed >> 436 * through RCU and the associated kmem_cache are dereferenced >> 437 * while freeing the pages, so the kmem_caches should be freed only >> 438 * after the pending RCU operations are finished. As rcu_barrier() >> 439 * is a pretty slow operation, we batch all pending destructions >> 440 * asynchronously. >> 441 */ >> 442 mutex_lock(&slab_mutex); >> 443 list_splice_init(&slab_caches_to_rcu_destroy, &to_destroy); >> 444 mutex_unlock(&slab_mutex); >> 445 >> 446 if (list_empty(&to_destroy)) >> 447 return; >> 448 >> 449 rcu_barrier(); >> 450 >> 451 list_for_each_entry_safe(s, s2, &to_destroy, list) { >> > 452 debugfs_slab_release(s); >> 453 kfence_shutdown_cache(s); >> 454 #ifdef SLAB_SUPPORTS_SYSFS >> 455 sysfs_slab_release(s); >> 456 #else >> 457 slab_kmem_cache_release(s); >> 458 #endif >> 459 } >> 460 } >> 461 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >> >