From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AAB9C001DF for ; Wed, 16 Aug 2023 17:15:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D7498D004E; Wed, 16 Aug 2023 13:15:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 887488D0001; Wed, 16 Aug 2023 13:15:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74F6A8D004E; Wed, 16 Aug 2023 13:15:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 630098D0001 for ; Wed, 16 Aug 2023 13:15:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 00CDFB291B for ; Wed, 16 Aug 2023 17:15:16 +0000 (UTC) X-FDA: 81130618674.17.2A9C251 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf26.hostedemail.com (Postfix) with ESMTP id 2D2A0140013 for ; Wed, 16 Aug 2023 17:15:12 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ON1qj7hz; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf26.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.51 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692206113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i7pZ8yXv877xqgWHoGs7GnAl1TuvEBADR0sH782/8U8=; b=tbBYWsAuq8AVvLhVHmW0x51i4YMYIveWg6DoV7DrjFZGfib1eVChu5bUtNoxl9nUTW27sn ilv05clgdLxhHKKGAwEt2bq02n0Ojgxm/z9Ir1nxmiADArVTTlIviJYzmoJnGD5BsrkkX/ RmfH5BerVaqdBdS+xL5J26OJmSAeRtI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ON1qj7hz; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf26.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.51 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692206113; a=rsa-sha256; cv=none; b=SBAGCMT5Zfby67oWZl+URbhNY14l41csAh1jRcNWVAkZvJ7co4LgB0LAgt4DFDaRu95+JI F1OT2QXLpfhRZKgzi6SN+VTpeNc43JQLGPzFQ22RS7W+WHZm3jCy61PLYOey04lng3k1oV b0t/MwFt4wJQIsyuuzqcqeuHWkcuvvU= Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-760dff4b701so81528239f.0 for ; Wed, 16 Aug 2023 10:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1692206112; x=1692810912; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=i7pZ8yXv877xqgWHoGs7GnAl1TuvEBADR0sH782/8U8=; b=ON1qj7hzWcby1d53aWfkaayYoCVQPcUlGlMszWIXfnKqPOVZkDoBvKhasvcTUdjeU/ xbPnlk815G0BzzeedvPkotEJg5nVD00UYV5RJu/wyqT7dUnXewOnWfWiyHv9Gaf3avY2 yFUOWxNV35R3JrfJuQBrZdMwEkhnH2nlbARVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692206112; x=1692810912; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i7pZ8yXv877xqgWHoGs7GnAl1TuvEBADR0sH782/8U8=; b=bBQrtfCadF5/7713Jgtnk65XOUMtaufjA4WQCGCqDTn5QfIVeIpoJPgfRpQN0DHUHC YBV/XGckMfkZfGH6lgH6i+mq7AQgPanK3359ZB2Pmoc55S2XI7d+JY8tAb7BZQiXYUFB qYw0eUrXy9vmCAsSs2mE4rarw7aXJFZmPNGYZalXkVhuTEbhylxho+RmvKW4u9qwlEM+ tFFjK+/yQv8WfuuyejTyQlkxg1rbYn94qyvdfPB4CGrElPN4pMSEoaOBRJUiDOzTytLB EwL0MYOe+3pN2AVnV3WUurvLNRbH5Y0V5O4tfF+oHcxX9bLYtim0KWB3FSkSdkhtyDRz voHA== X-Gm-Message-State: AOJu0YxXmGq6w4qFvxYBA0W+8CWa3evHkniqO1Sb1jkQSonCUQUpL4F/ RdNeiqmVfrf55lwFguY98lw9mw== X-Google-Smtp-Source: AGHT+IFsVDC5ag7WEIVMgg2Z2P5NR6QcXCAPC6Ahd7mWp5AmaHyYRTxHfuzvfLXohNFvnq72lFsxng== X-Received: by 2002:a05:6602:3983:b0:783:63e8:3bfc with SMTP id bw3-20020a056602398300b0078363e83bfcmr4086982iob.0.1692206112087; Wed, 16 Aug 2023 10:15:12 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id c15-20020a5ea90f000000b0078680780694sm4640181iod.34.2023.08.16.10.15.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Aug 2023 10:15:11 -0700 (PDT) Message-ID: <343469cf-47a3-c8de-dc61-dbcf41e5757c@linuxfoundation.org> Date: Wed, 16 Aug 2023 11:15:11 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/3] selftests: cachestat: use proper syscall number macro Content-Language: en-US To: Andre Przywara , Shuah Khan , Nhat Pham , Johannes Weiner Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20230815155612.2535947-1-andre.przywara@arm.com> <20230815155612.2535947-3-andre.przywara@arm.com> From: Shuah Khan In-Reply-To: <20230815155612.2535947-3-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2D2A0140013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 1hintx4t7obh5dcuguc4zew7k71kr9de X-HE-Tag: 1692206112-538602 X-HE-Meta: U2FsdGVkX1/om8gd8QJhWgyd/zdyLExOEoltOOMw1kEGMM7Ds5myHKzI6wIwdHjCkxHDHNizjZxsookxFDsdXkO36pBwac/7Tbe4Asvc3vjSFBot1xs6D4xtgS5aG6UFGfxIiCS12IjVgb0jyZZl07TNUQR1T6vrPToU0ttaH971QahwDXfKDRpkj0utHKLV1KiQ/gVWzGtEi3PVr1Rp6XQ8aXWbbwiQJS8IEJyp0IamPZf9wqQfeJxOJsaKMinQJtJDlyK+gDvvyO0BhU1oMbIreIRzUJKc1h/TzKukMQSNGQRWy9IFwBVO9rDTMvTFcOcEVo+6OwuoALG/9oKFCzgz5v8lZCte9Jk3PKQDczxW4W12582QsWMCKEeGjqNw3wUXY66/tF+phiO3QZublYIwT7MqwMMfgZhdkNw/PNOHmcdydwM2aWI9+VepU1S1dospmyigN0d1WPr/ZQdeMpcn0/XY6Tsh+JrzVIxJd9HByOQ8199/cjd0ZSE7/XrmfojGcJlWurPTJFsnij9po7ytld/ZczVc4AUqIDrTkru8ACvgR71hi6P6Q8PzMq/J+pfaeBTououyfr+A+buTt82Kpwq2edFmTwUi9LW3XBN5ysPL9zF6woRI5/K7GXJFfwHHbU6JWXGgvWYmRzJ7XaSO4+2Tzz7tznHiSkQ/X+ZVPAooMzHtIlXcmo0tnJk/PzSD46u6b/b6pf1pdlfeVwkh/SCxfmyB6NkfamRENk/0G8zUOkjtd3Z7wwEsvWP3D32fRlbUfJdo7Xt1HbkjFQz83RwcLU05mApB3YH/+j9ujxVSg9uAywrbLV5ezvuTrf19+LEHfDXZQiieqF98lxywRZee6Ht5Lge4WCItFvVq0y5ITmdw8v0rQA/yWGLv/zuu9vDqU59cQNEG06wV1uYzeZrNxLLNUMAePgH5gCB9lEnd4nHihGxD1qPL4XkkllquOzln4AeGONCdqDJ ecfxgmMG bWsSWzzlsZ6ZrbZI3qONEzKUOKS91RvhNOumuJixFtjsOJtNb7Wy26ocf6yFHo6XboNglhQoiXwYX/iq3FlPhbGolCz+Tvt5zJ46ndiMUyqiRSzj7lpMvHZxrgWw9G9hZStIZS4CvxMuVtMc72G2aG1c72W0p/b7r4kU5etCfc2CZe33W0GzHsXd7r5k2K2Dw9KzzUBgTpdcXkeKSHOI5KJTMH4lkDoWrpa1l7zqy1iThbnPb3UP6JfA7X55rsKRMvmc1svwLF4gwRWCwczxVBjjUBaEVskFlTJEl0hpvbT344MQaKBfLtnZmkdauyx9MLKjpjgMtglTGXkD9zrSa5LMB3fTQ20QfQNw3ULKdRDDx+8EfKbZsApfL3mlotf9vDLWOVIB1zMvEMwxE4RNGm9JWdf9xRLe4p30oythiuKOo5NzxYYrDk8sGJQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/15/23 09:56, Andre Przywara wrote: > At the moment the cachestat syscall number is hard coded into the test > source code. > Remove that and replace it with the proper __NR_cachestat macro. > That ensures compatibility should other architectures pick a different > number. > > Signed-off-by: Andre Przywara > --- > tools/testing/selftests/cachestat/test_cachestat.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c > index 54d09b820ed4b..a5a4ac8dcb76c 100644 > --- a/tools/testing/selftests/cachestat/test_cachestat.c > +++ b/tools/testing/selftests/cachestat/test_cachestat.c > @@ -19,7 +19,6 @@ static const char * const dev_files[] = { > "/dev/zero", "/dev/null", "/dev/urandom", > "/proc/version", "/proc" > }; > -static const int cachestat_nr = 451; > > void print_cachestat(struct cachestat *cs) > { > @@ -126,7 +125,7 @@ bool test_cachestat(const char *filename, bool write_random, bool create, > } > } > > - syscall_ret = syscall(cachestat_nr, fd, &cs_range, &cs, 0); > + syscall_ret = syscall(__NR_cachestat, fd, &cs_range, &cs, 0); > > ksft_print_msg("Cachestat call returned %ld\n", syscall_ret); > > @@ -152,7 +151,7 @@ bool test_cachestat(const char *filename, bool write_random, bool create, > ksft_print_msg("fsync fails.\n"); > ret = false; > } else { > - syscall_ret = syscall(cachestat_nr, fd, &cs_range, &cs, 0); > + syscall_ret = syscall(__NR_cachestat, fd, &cs_range, &cs, 0); > > ksft_print_msg("Cachestat call (after fsync) returned %ld\n", > syscall_ret); > @@ -213,7 +212,7 @@ bool test_cachestat_shmem(void) > goto close_fd; > } > > - syscall_ret = syscall(cachestat_nr, fd, &cs_range, &cs, 0); > + syscall_ret = syscall(__NR_cachestat, fd, &cs_range, &cs, 0); > > if (syscall_ret) { > ksft_print_msg("Cachestat returned non-zero.\n"); Thank you. Applied to linux-kselftest next for Linux 6.6-rc1 thanks, -- Shuah