From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 742CBC8303C for ; Tue, 8 Jul 2025 06:09:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2A686B0306; Tue, 8 Jul 2025 02:09:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C02046B0307; Tue, 8 Jul 2025 02:09:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3EC46B0308; Tue, 8 Jul 2025 02:09:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A4E5C6B0306 for ; Tue, 8 Jul 2025 02:09:21 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 36D2F1289AD for ; Tue, 8 Jul 2025 06:09:21 +0000 (UTC) X-FDA: 83640070122.16.FFB107E Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf01.hostedemail.com (Postfix) with ESMTP id EF3BC4000F for ; Tue, 8 Jul 2025 06:09:17 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=WgtQwHLl; spf=pass (imf01.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751954959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zh0GZgGllEOdHJ4JfcnZXS605Yci87SIRFoTaKVIHL0=; b=bEY4CSzM/Xje2htLJ9p/PmDrwc+kFiuzu6jgY0fgvugJ5bgYMkfGbtE++d3PtLnU0/TzcT GE0Z1WOFEM/V4pXDTHyCwb3YZEvor8mSQKv+KU2cE93mGzurjRYdoQ3uYoXsuGeqXEZlH0 wMsN8SeLzJj6FV5y0PpyELd976TyOFc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=WgtQwHLl; spf=pass (imf01.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751954959; a=rsa-sha256; cv=none; b=ifbO/KDWYv/kiq7OMHTTiNvsbwAH7JiMJ73QrLyrOCZmDbyXDo0duzdQtIAHQ5uBaSuRO0 mgqsL34FoZWeOFCioy4EB38rBKR5WW5W4CO8sim9h2ENKnjdln7TkTf9YWQL/+MyJ/CoqG YF9BsbMV9RgHVOX9SnTKBvbeWay6rLU= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1751954952; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=zh0GZgGllEOdHJ4JfcnZXS605Yci87SIRFoTaKVIHL0=; b=WgtQwHLlxa1M42TBYI2ooP+5blNjMNxRxKxO/rzsAKwzRNXLL0wgQWfy0BinSS22T84tqW925Z5dR+ww8BbOLhpaCXZ7CIPfKZ9n9yR8UHYcRaeVHS0O8E8aAyKwCV8llTrVr/V63XG3a6KVM/PLPZQEkDPmAbVpystHaQzOq3s= Received: from 30.74.144.119(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WiL4DJh_1751954947 cluster:ay36) by smtp.aliyun-inc.com; Tue, 08 Jul 2025 14:09:08 +0800 Message-ID: <342d5fe1-cd39-462c-b2a4-b5d6979a8a21@linux.alibaba.com> Date: Tue, 8 Jul 2025 14:09:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 14/15] khugepaged: add per-order mTHP khugepaged stats To: Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: david@redhat.com, ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org References: <20250702055742.102808-1-npache@redhat.com> <20250702055742.102808-15-npache@redhat.com> From: Baolin Wang In-Reply-To: <20250702055742.102808-15-npache@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EF3BC4000F X-Rspam-User: X-Stat-Signature: tbks6wybupfyyo36zpssmcusigbdnf7f X-HE-Tag: 1751954957-30641 X-HE-Meta: U2FsdGVkX1/m79s9ALocCCNeRUAceoI2KavmbCS+UB6oT1fCnApS7D2rmzzNVXBjbxMoVCDxGNUnUSuCx5sWF0CIg9d/fszxjWqTiQu6iGv+Ini3MJJZiyp0KfN0JP0byzw/qZOyKGdcfA5QooPJBoRdUN55aA4EYZ0rg7ZD3CVSnrkaXKD2gjymsZTmdbNxutmpYarfbwTcYrXyNjwlEm3tpGCW8vbdqfmTp+EIytxVidOW1skNReo4nFshwNW/8RDr9YpsIk0A8sWU0oy0FGZCytZVhJ1Vz1Fewpj4KH4Nzb/6H89XloFbqwaqeJDdNkBrRy+TtlIVnt1ywqswUjzs/JCJkoermDTw4BbB6Ucfatiuu6oR1cIN6RW8Hn4kXN2vVsAW9V4R9SCYGadINyzN/8fKhpa7JYppeXPrb9kX9xKnbvlnmI0Jcz7uIClxqe/s3FRi5h5FwSOkLAeuDeBBcr1ywXdhcU7LNcq4GJRxB12LhLFCI7NWhc5OFUyIq78xOeYfOHaNMv614g6ow2uJVeVD4veD75F2JeIuRQPvIxo/8oFzbqck5snDC/LGcG1ISVxOgnswtyLnB7lfRkYg3U8e7BDtIwBSC5H6MayKhPflBZmSLjBccnlQTShIhPGUg7AsxZKdxrcY6LYekAB/RpM9hi+pbw5QiXlRpQgh01NHC6jCLP5SgHgn6vReFVrBTJMhVr/bVzZcjlNSIATC4UhrDPX/D87qLwkWtFaExhGXwa/kX27QX7+t57QXbWtsjngKdDVsSGcbFjH7Xzl6z8Y3K3bmf5sgDJFtRmTe5l/+wDWZvYbIfOX/amdItOfFScbLuofjYIrkpw2a+55RaLWH1/Ucwq3qUST/LlM/FCF7nbyb14X49IZ389wo4Ne5QiPfCOyKJ0o1h9yVRuWSX7UKy2qyr/xuEH4/zccZEUjR5OmppV1xODN8wic1899swqC33Km8tstekzJ OTwbLIf6 qG5b57DaXgWQiUOqw/CDhsMpIBl4qN2JNk2MpLZGtYbILsnwLWkyIQQqod0+BnUdoHxwfmzfdACcYzts7AvDU1RCgOWp3ya7wU106IsULnehHNamSDHtIsIA5geJmI9ZrgJrzlWsVpqlD4U77hXaGGPcqAyedsgqJAPW4OcRUCBOWNlIiCyYWL+Dqd90yuRDvur0PaMAuZ/2Ukmic3lOyyPTY2JBqitddbksaIuOvuf37tw+aU9LBMoK3iNLqUH32FwlDAyjlq0PCsnYJGiXviC5Wv2VQLSKcn6GZzRAnj2LYI3c5d4a/6MDueIaOfbf2dkYwKu0FuJvBawa8zVyGp5Y1Qt97roPBGko4MozCFEArpTokqAh+Whsd3yEFDAKG79wNvd6DS2axAIXXyyD+41gCfozOoVtYrzUWcrAGLgI05PTPsS4tubdmUc3VBS0dOjVx3tfA9AMbv6A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/7/2 13:57, Nico Pache wrote: > With mTHP support inplace, let add the per-order mTHP stats for > exceeding NONE, SWAP, and SHARED. > > Signed-off-by: Nico Pache > --- > include/linux/huge_mm.h | 3 +++ > mm/huge_memory.c | 7 +++++++ > mm/khugepaged.c | 15 ++++++++++++--- > 3 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index a6ea89fdaee6..6034b4c9dae5 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -141,6 +141,9 @@ enum mthp_stat_item { > MTHP_STAT_SPLIT_DEFERRED, > MTHP_STAT_NR_ANON, > MTHP_STAT_NR_ANON_PARTIALLY_MAPPED, > + MTHP_STAT_COLLAPSE_EXCEED_SWAP, This stat seems never used. > + MTHP_STAT_COLLAPSE_EXCEED_NONE, > + MTHP_STAT_COLLAPSE_EXCEED_SHARED, > __MTHP_STAT_COUNT > }; Please also update the 'Documentation/admin-guide/mm/transhuge.rst' for these new statistics. > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 69777a35e722..3eb1c34be601 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -632,6 +632,10 @@ DEFINE_MTHP_STAT_ATTR(split_failed, MTHP_STAT_SPLIT_FAILED); > DEFINE_MTHP_STAT_ATTR(split_deferred, MTHP_STAT_SPLIT_DEFERRED); > DEFINE_MTHP_STAT_ATTR(nr_anon, MTHP_STAT_NR_ANON); > DEFINE_MTHP_STAT_ATTR(nr_anon_partially_mapped, MTHP_STAT_NR_ANON_PARTIALLY_MAPPED); > +DEFINE_MTHP_STAT_ATTR(collapse_exceed_swap_pte, MTHP_STAT_COLLAPSE_EXCEED_SWAP); > +DEFINE_MTHP_STAT_ATTR(collapse_exceed_none_pte, MTHP_STAT_COLLAPSE_EXCEED_NONE); > +DEFINE_MTHP_STAT_ATTR(collapse_exceed_shared_pte, MTHP_STAT_COLLAPSE_EXCEED_SHARED); > + > > static struct attribute *anon_stats_attrs[] = { > &anon_fault_alloc_attr.attr, > @@ -648,6 +652,9 @@ static struct attribute *anon_stats_attrs[] = { > &split_deferred_attr.attr, > &nr_anon_attr.attr, > &nr_anon_partially_mapped_attr.attr, > + &collapse_exceed_swap_pte_attr.attr, > + &collapse_exceed_none_pte_attr.attr, > + &collapse_exceed_shared_pte_attr.attr, > NULL, > }; > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 2c0962637c34..636b84bf1ca1 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -594,7 +594,10 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > continue; > } else { > result = SCAN_EXCEED_NONE_PTE; > - count_vm_event(THP_SCAN_EXCEED_NONE_PTE); > + if (order == HPAGE_PMD_ORDER) > + count_vm_event(THP_SCAN_EXCEED_NONE_PTE); > + else > + count_mthp_stat(order, MTHP_STAT_COLLAPSE_EXCEED_NONE); > goto out; > } > } > @@ -623,8 +626,14 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > /* See khugepaged_scan_pmd(). */ > if (folio_maybe_mapped_shared(folio)) { > ++shared; > - if (order != HPAGE_PMD_ORDER || (cc->is_khugepaged && > - shared > khugepaged_max_ptes_shared)) { > + if (order != HPAGE_PMD_ORDER) { > + result = SCAN_EXCEED_SHARED_PTE; > + count_mthp_stat(order, MTHP_STAT_COLLAPSE_EXCEED_SHARED); > + goto out; > + } > + > + if (cc->is_khugepaged && > + shared > khugepaged_max_ptes_shared) { > result = SCAN_EXCEED_SHARED_PTE; > count_vm_event(THP_SCAN_EXCEED_SHARED_PTE); > goto out;