From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C8AC3DA4A for ; Mon, 19 Aug 2024 14:08:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43AF66B0089; Mon, 19 Aug 2024 10:08:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C3B36B008A; Mon, 19 Aug 2024 10:08:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 264E66B008C; Mon, 19 Aug 2024 10:08:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 04C046B0089 for ; Mon, 19 Aug 2024 10:08:27 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A1A021A1364 for ; Mon, 19 Aug 2024 14:08:27 +0000 (UTC) X-FDA: 82469175054.23.6D33752 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id AE713120034 for ; Mon, 19 Aug 2024 14:08:25 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QW3BVxYZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724076490; a=rsa-sha256; cv=none; b=IJjl9DHux30ZfMGjof0sJXrnHMJUSgPeKpuRXs7tR6Jyoyc3EbwSrtGx/1pSb1KoieT9nL bA57y2yHWMP9lxwM+2hZZtgWO59wcCDMQdmdHpW9tYP5/oOFZgBjadhyBw9wL8fwyRUKMN EOrDO2wNp0xi01LjcsUeiyewSF4Q2NU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QW3BVxYZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724076490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6XYur11TPtGEn1C9y/LldAZB5i+hKJ1iTdKnEq29u2s=; b=Pxwad/6rJRdxyVp4ngyOoe+lD/xayAcQdBMUSanguwIb3r0sPnx35u7Cbb0QBUkwFChaYB wE2ppxoaNbkUFszC4C0p2381RIQoUZWfmgqDMq8osVc7/9+579+kPELIRqlc4Vwj5Bbx9T 4xoziO10iwX5IohmOPM/JcjfrS7nCPs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724076505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6XYur11TPtGEn1C9y/LldAZB5i+hKJ1iTdKnEq29u2s=; b=QW3BVxYZR687AOfHTOSY4z0gbUGMj0PUhBYBeGqyr218IucNFbWiTHbB5S5MniR5gHD8f1 iNodoX9QOh5dViC1HbKdhU8AATtC1ya2brD8m2VlgFAjz/Tu+MvyaPdowoI6bIBCPK0Tyd 8bZWdhBK+9Iw2KcxGw+iqaaKpdzD32s= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-jHbrzhgdPny4TS4KDOGWhQ-1; Mon, 19 Aug 2024 10:08:20 -0400 X-MC-Unique: jHbrzhgdPny4TS4KDOGWhQ-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D6B441954B14; Mon, 19 Aug 2024 14:08:16 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.30]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EBABC1955BF8; Mon, 19 Aug 2024 14:08:10 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <03ae65df-a369-436d-b31c-b3cec6ca3bc1@suse.de> References: <03ae65df-a369-436d-b31c-b3cec6ca3bc1@suse.de> <20240818165124.7jrop5sgtv5pjd3g@quentin> <20240815090849.972355-1-kernel@pankajraghav.com> <2924797.1723836663@warthog.procyon.org.uk> <3402933.1724068015@warthog.procyon.org.uk> To: Hannes Reinecke Cc: dhowells@redhat.com, "Pankaj Raghav (Samsung)" , brauner@kernel.org, akpm@linux-foundation.org, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, djwong@kernel.org, gost.dev@samsung.com, linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com, Zi Yan , yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, john.g.garry@oracle.com, cl@os.amperecomputing.com, p.raghav@samsung.com, mcgrof@kernel.org, ryan.roberts@arm.com Subject: Re: [PATCH v12 00/10] enable bs > ps in XFS MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3427741.1724076489.1@warthog.procyon.org.uk> Date: Mon, 19 Aug 2024 15:08:09 +0100 Message-ID: <3427742.1724076489@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Rspam-User: X-Rspamd-Queue-Id: AE713120034 X-Rspamd-Server: rspam01 X-Stat-Signature: 99gxf6dfrrxhpuji3oa63a47wdd84thh X-HE-Tag: 1724076505-474046 X-HE-Meta: U2FsdGVkX19Jx6Y8VXeSmdV9su7/5rbGjbF0RvtzvFmA9wzZzHEpbpnfFJw4HDq2PnbtUB4cFyKGC0Sof1NEbzvTuecdedKIq9L3i9K8jhZqNiirGjdqOZUcra9nnS0O67YAsN4QuHhB6TQMbkB2GixJ1jXlN59AVxSQXzsLeJZe4aj1T5V0kRJrDzWQ+Uf6o+AP5C3uzGCSfwJfLxu9VIGFsYlYbsJzHjE7FldT+BQPbqe1eIHHrf5adCHwfcYhNR0vou8D4cYQ+iYhZ4eTNCxP8qSStdUp7ACoxOSSgBaS/KoUBF7xaLOy3G6s9bQdAepMVFsYvtYODV83XZ3By9A4URToBB3ssLaclOhLm8IOEEFHmso+AmBBRtH0RKqhQJJS6wZ7DjXYCA2w3RKMJ0EW84k6DcVPJqc+R0aEKK3Bb6OyNiJl1/GuYoN0CT5JWVJ0kHN3ZLo1H6bZUA/NTCqo2VS2MD08TLnnpj5Z3yfbXMfaDuERnmCOeLmnhgMbRfBWhRRHBbEEuzMnOueoMlEfxUzxYNIXSyRTUPkvx68NmDl35C+ckZDIyE+XQAeIc58W4UKdgG6PxNHiQIR06hUINtovbFFd3RyB0MWcoU/k/lGUnKMqbaZB6ZhCeasZFAFjgXGyKu8AKSC2G3ZXv/qXhG0Zm2N7UZhHvJqdVPdXd7vtQfoTgU3eo5g+Y2qxYi0pR3snPeswf8p+BS5IUlu1aF/HxOwZTvKLXHq02X5r85G1UcDYezJkR9cYuXbJthrPVQQt4nljXzRhRpJe3+1FrOoGHa9nvnqOKeaeGfxJA/EYzhgx7Mf/J4hX4XCH0EAhGH1ebu3qrFf/aXj3VBBuXAusP9HmsbBurL57CrDve7/X5TdLctV7Z+p401ypgbnzBZ8tl6w3/dDhWaTcg6qvv0FzNeEJQJVp5kyFViau1M2x2xNaZs+Lj+2Dk1EHn89XPQejdWL/zrZJ2hn vJS0ttzI OOjFzKkty2F4vuyT9YwD1HzmQva0b/CXfOoyjS+t+Fu5d4FVdbvyB08SaRtfvv/nnmOlr9L4KM+tbhWmPn86MNDQTrtBvPCUsMxqLVBZbJq6ZaUlCFqsc2uKiREs+aw6/R/3ZVRMPOSwtiRtJaxYkKrz26G7nxL8ZuYPow1zv6JbA4VZtkpaO7zar7BIrzEgE/Di+IGTSjdDE7ns+EcKDftR4W/z87CEfNFLzDcz1Omp+c4YmJ+KzFdbCzvJVV3aaFowcR9wyuJZapbu0fMycL2Ppz7jP+fftD45J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hannes Reinecke wrote: > Wouldn't the second truncate end up with a 4k file, and not an 8k? > IE the resulting file will be: > After step 1: 8k > After step 2: 4 > After step 3: 4k Yes, but the folio should still be an 8K folio, and it is: > pankaj-5833: netfs_folio: pfn=116fec i=0009e ix=00000-00001 inval-part as indicated by the inclusive folio index range ix=00000-00001. The problem is that the bottom four bytes of the file are getting cleared somewhere. They *should* be "XXXX", but they're all zeros. David