From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D94C3600C for ; Fri, 28 Mar 2025 23:14:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 175B728016E; Fri, 28 Mar 2025 19:14:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12609280165; Fri, 28 Mar 2025 19:14:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 014F728016E; Fri, 28 Mar 2025 19:14:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D4959280165 for ; Fri, 28 Mar 2025 19:14:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DEE991208EA for ; Fri, 28 Mar 2025 23:14:04 +0000 (UTC) X-FDA: 83272514808.12.234ACE4 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by imf14.hostedemail.com (Postfix) with ESMTP id E3962100005 for ; Fri, 28 Mar 2025 23:14:02 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=BstV66bL; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf14.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.177 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743203643; a=rsa-sha256; cv=none; b=G3hL4efNzZmLnjUsRErmXyapzjPiN+lHpJ8NaK/qGGi5vPeGumkrdqiH++mUBJi4jG1v1x 8mk7oTlUFVFpTlrLuH7I7PpEd/AVbAblu9Hbptwbyorsw4WmXopg1X40Na+H9AM/i/vTtP dnKLdhxnDSrTj8jTNmva+NnOazUg4Js= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=BstV66bL; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf14.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.177 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743203643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yr92lcwq5x0ZFyCbkIww3KuTV12e93SVlPMAsCMg51Q=; b=SiKUUPtkwku4V0sdn6MhnIwXNduJ2p7IrZ3T12G0Ccs+rvqatEgyXmmekywHJ9s5IGHfjp N95cU6fQQHE5uW2eCsK6+iSYShAw362O/2Jcl9tytoCmhB8zpF9H0D6PWnSAKV/v8F2KXW bvlWj6wfgGBBfT+zK1LdTl01c0o1KxU= Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-3ce87d31480so14118705ab.2 for ; Fri, 28 Mar 2025 16:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1743203642; x=1743808442; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Yr92lcwq5x0ZFyCbkIww3KuTV12e93SVlPMAsCMg51Q=; b=BstV66bLxMN9nag0YAR5sXoAjGpNSOUQGvkRcP5nSd6XgWNIOg85JVLXl/nMu5I4u0 XRUxo/QjJ4Ju1jwiP7WanwANetb1eOjyx6U0TCGJecebSHvUfVkgJP8DtbtuMTg7p6IW DhZ9xbLnDABOK6YXQCKm+UwSIkG2/nqzLzas0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743203642; x=1743808442; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yr92lcwq5x0ZFyCbkIww3KuTV12e93SVlPMAsCMg51Q=; b=ZdDSTPUMn9YCIvHYV2ynL2FC1wO5ZsyNIdfivl1RJbBLYa4Djl0J/xqMPaLuVs/o9l E732V4UR4f7GoJhTrxRwKO6mY2nedgG1EsTHrfbic+qslUUw4B8GjTmQbC+RBPZ4zNjb l1+t+/6Wu3yUsHykOohvYOTHmeg2v45mZG9FENY7bjyK9Lc522qJiYwgGh11sWE+vhld JIsf+mjfAPBMMqjk7X4qH9GT6c7qhZWodwpFlfsRqmEfflBq5MExG4XsGPASj1A1XMfz jJlm5sPbx8qxdmN7GDMOU1DzSazMEI/LEluSpJHzk9tH5Sxv7y1lRevvfewTPb5bxwCv oHlQ== X-Forwarded-Encrypted: i=1; AJvYcCVlOrsZOck0Os9WbAxtsruJrynOY83/0QJ2PgYSGObxaMzncIg/HamMxtuV54l6DQeixObhL8F5pA==@kvack.org X-Gm-Message-State: AOJu0YyvXQYOkkl3q9EzFW9eU5GN34QBKXQRGnLS1LQC0b9b0tREM6wv mVHvoBStPgvQk2kGrlptTrw9xtvHIe9cloxbqdb3AYBjQ32vvE3Np2z2kJ72QN4= X-Gm-Gg: ASbGncvBf+L3v9yffXAIEdeurNDXON+czO6vJLwkn8nJo0UoIc7BEFq4iqRXto8IA5X iyaxiHarZegC6unc1Vi9w9daGRLCuncV4MlpPdnDZtPKw/9aeNTwLYXvU2dAvfLSdqGfIZarPHC yoTXQLp85jC7D9xaaJBp6przcUnokGv29Wak4ghHeA+H97cdYFlE6KmiZdXplSQY+SWHfCR+BKF nLtOFThHyV8b24BQoCZizYWYviqVbBx8AiJC8wItyeI0eWUWM5N9aA94I3ngbduL/C/cduGQpPf ZIe0HRGUZsRGDYGJUtDLOfDsBmFeHeJCZG0ZgXP8a1w4scvzPHrfzDE= X-Google-Smtp-Source: AGHT+IH70oQnJuM39SPUEueHTkjRUfH10oglLKDNJ/rt0bF923Ls3rYLJLdj2umTWLyd5RtMW24WAw== X-Received: by 2002:a92:cda4:0:b0:3d3:fcff:edae with SMTP id e9e14a558f8ab-3d5e08eb18amr15510035ab.3.1743203641817; Fri, 28 Mar 2025 16:14:01 -0700 (PDT) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3d5d5a6c6b1sm6921945ab.17.2025.03.28.16.14.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Mar 2025 16:14:01 -0700 (PDT) Message-ID: <341f69ce-2af2-4c13-8144-146f1aa9fb07@linuxfoundation.org> Date: Fri, 28 Mar 2025 17:14:00 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug report for linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c To: David Binderman , "akpm@linux-foundation.org" , "shuah@kernel.org" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Shuah Khan References: Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E3962100005 X-Stat-Signature: 73dej6w73ma33typecreoiqkcnc96opy X-Rspam-User: X-HE-Tag: 1743203642-805838 X-HE-Meta: U2FsdGVkX1/uLYz3uuHZ1O597bbbITlCZMknyfc7cG0AyYFbf8EbG5EYdo6Ifvs9f+rywxaJtTjS2hZ71u4AcH/Tm2CI0tJLvc17E+xQKsDcMUIIud9raOoL8ZEALKH4+/z4AQNfcmAYbJD7RguX9hFxiuCTP1JwmEqtO035cYLvpRCSoA+kYPg+1yn/Md4jjYUv0nyS0Sc/DmVcjfzATfJW4tvK3cGQe+NsXyxbXhoRCX8qrztBFta3yW5PBbhkkruyvuiCuJfohPPk+IpGEcI6aozQG2/KILpvVXs7/1JshdAEKon7pttYmgdIPStJRvoN7lQIr7lc4kRyzIrJs56if25Ez7jMsYl0GQvcxyeUKkIwdjL5wvZwRtICs55D2yzki0Q9sS79FTpvHtdPI2xjfHYH2X5cXeN/Cy77d+o91v+hzlIbkmkmmNti9PRPfiN09RiQlnTAHUbi802aTJXqo8+L4fmYxY7k1lM7gE/N3HOzhP2g2D1Ph5vVpW+fC6UOalATvAyIsS0uewRKbdwg7KtxCZCMA0KVFXI48qXMQcQwHQF6kWu5aUxELar4O0Fls4IebAiOlF0+R+yC5r6ihirRtWTLbt67QZTTzkK+BLo7H3AjnPVEpRXoLeHHzAJ/EStFY0YX46eFMjVIBCZvozIuR6FIpvjwXCscKezVRNxSYbd2UOMxufwkeAWRvGgbt1Npfz+KGjMJuEUPwZaSpEyJqWT4JU2bZF/Zyjd8OzXHxLsmUkrwYe3KhqMdPgEeM4hKFvWqeIL1M5RBWZNLLR3tHn/JME3F+PgqwkI64W5//kWOBCK6syfDOv65+9qBTNWawLNsY+qgnBQxFu8JbJ9TsKuk/UbaCibdUod49qlZc6cE3HMAq4eKNyDGmDK0oPLly+7NncBu+qieRkjpBamhrl9oYT/8ARm0HCUMvDEFFRmHgxNifqqP5rPUYNHimeSVwcV/yt2eU4t jgFxpJHh ZfPSpHjLOP40HlLau5UCgz1jJGkzB27MQozisg4qDihDUDJUPwmFtWRtchIoJdK9qJOWW5evHsNN3OcTkZhkHSDNHGLQG9UfX+MmSHv7OiYuPBLB59tNwI/fjjs8mOT1sUVJDeu6N+brZx2Q1Tblj+JhyFHNd7l7LbCz2QXPiAZ3FaQMdc2wZrnAW1lirXaNz7WqQDqHl1vwBrmsdg20qfMjJQBMFZkG0wv3n1LBv4AYqpi3czVSCfwhWzMYxrrvcBvyN0/APtHvYKJBDtNwlaosHfOJPQXUKgZPFqGMaOHCFvkP29gaS0yTpeJXr/q3gvX9VykZ57dTBWg9FKuGVWSpayHwwtVLy0CC5mO1WBDSalrFV35Ddi/TTv1JQYV56hNhuNwqK6wJuznSxmCGH3lXZgEyemRQh+eosiP65UJDQLRAnOyW0/ejncw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.010796, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/26/25 13:25, David Binderman wrote: > Hello there, > > Static analyser cppcheck says: > >> linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:1061:11: style: int result is assigned to long long variable. If the variable is long long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] >> linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:1510:11: style: int result is assigned to long long variable. If the variable is long long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] >> linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:1523:11: style: int result is assigned to long long variable. If the variable is long long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] >> linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:247:11: style: int result is assigned to long long variable. If the variable is long long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] >> linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:435:11: style: int result is assigned to long long variable. If the variable is long long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] >> linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:490:11: style: int result is assigned to long long variable. If the variable is long long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] > > The source code of the first one is > > mem_size = 10 * page_size; > > Maybe better code: > > mem_size = 10ULL * page_size; > > Regards > > David Binderman > Can you send a patch for us to review? thanks, -- Shuah