From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84CA5C3DA4A for ; Fri, 9 Aug 2024 17:27:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 186806B008A; Fri, 9 Aug 2024 13:27:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 135916B0095; Fri, 9 Aug 2024 13:27:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED5C16B00A0; Fri, 9 Aug 2024 13:27:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CB32B6B008A for ; Fri, 9 Aug 2024 13:27:35 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8A0B8C132F for ; Fri, 9 Aug 2024 17:27:35 +0000 (UTC) X-FDA: 82433388870.24.79F3E9B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 35EA412000F for ; Fri, 9 Aug 2024 17:27:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Iq50lTBC; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723224420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JFNIHJThdn/EJZUNURCAxg2SgRzsvo8wACtq52FCz7U=; b=HV35qnw6InngpJqF7ImhU7y33g2iP7JM2XH+2jTp/u0AzMgyzuAlmmKFxnAhQVCeAec9hr YGbYHKsPfTis2LBKFKq3bLLTiPeVUJFW9ipwkzv6+1VTGwurYk4X+af2Ai3Rcvkil9JWG3 2p171+rMdlQnVf5vUeUH9LfMLoT3s1k= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Iq50lTBC; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723224420; a=rsa-sha256; cv=none; b=Rg6NGW+vX1uScpyZWYuNj2mdVtgGBQ3jhgo0LQYNlwRgViTPBszywPNbGD7khf032mUQGL 84zH2soBvTGB4shK+KsUuCMiSdEgHG8Iwvd9cncNHTrJ1xhukSQkqgZxQQOeoF3K2nnvH3 mtjlHvSpLap6MscizBlDLUjj4nDx9aI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723224452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JFNIHJThdn/EJZUNURCAxg2SgRzsvo8wACtq52FCz7U=; b=Iq50lTBCjWqMazvwd9yM5zXq8Re8UPkDnKD6+/k8+QafesSHewZfoUodBWE6f3TMoY4aKa Y1fEIYDDgEwYuxMYdQNv0oCfduZAPzILZ9tPrgOGu7SW4WtqTcUI04l/H1raAbv/gZ0s28 n2oK0DgPueljbPOjM0Ez2vVS8HoUaBo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-4991HPrMNhuJa8VlH42Hmg-1; Fri, 09 Aug 2024 13:27:31 -0400 X-MC-Unique: 4991HPrMNhuJa8VlH42Hmg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3687eca5980so1073956f8f.0 for ; Fri, 09 Aug 2024 10:27:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723224450; x=1723829250; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JFNIHJThdn/EJZUNURCAxg2SgRzsvo8wACtq52FCz7U=; b=l45jAcdk5AxT0lFtxZB4dfiArf2z8Yb9yxQ61B8NL6dWcajm246BJJ6i5htGfolfKu c8WpR+aixRVntqQQE8CW4q1BIESa9OxObbJkwe10pverBsP0LVeT2SXdm5DebC1AJJTa R68HODYm04Xo5wCluUJZN0QxTMH+BbGQWsIpXI0vRpob5gPtrcOg4EKqtT1pwbNcyXjn sU6mKyA4LQYwwdZw1SW0HdFHhymBcnzcFwDeta8lo7Gh7MpJf3Ai9oaEKUTRKJzhyDMr JaqSBtqZejfpi/QtyHKRFJTVMtUrxVZoBp+tCkDSqct4yuvzf1BuwjkCNJCAL3P3GA1i pKqQ== X-Forwarded-Encrypted: i=1; AJvYcCW6VHCxoloDuLGJDfDlGtCmvBRPUyjzwCYom3W4UJqJXBMIGBs1fuDeqQlzi/iP0sqg87K+ilLq6quA+WLUxCR8OQY= X-Gm-Message-State: AOJu0Yy/vzcZOEiwYcROcKzfh78bdPTWLrf7NHq9qoW3wuotqDT4VnIT 02c/OxoFipsGb5LoGXiq5eVNvWr4cUwQnxscehvSi62z7suQPNCdZzC2bYc5x152gAcjkMJ4CY4 JdKDNaij+A4j5KD1J45ijF/SHzMknLcfVrxZoFUN4za2WUb48 X-Received: by 2002:a5d:58c5:0:b0:367:9877:750e with SMTP id ffacd0b85a97d-36d5fe74b28mr1710340f8f.25.1723224449781; Fri, 09 Aug 2024 10:27:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXLxRrUZzvjlmGLVdQZcN8EKFgXNGqZFjusWioPPshAOh6a+lMvF6ImASQFuihelLyRztFkA== X-Received: by 2002:a5d:58c5:0:b0:367:9877:750e with SMTP id ffacd0b85a97d-36d5fe74b28mr1710311f8f.25.1723224449200; Fri, 09 Aug 2024 10:27:29 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4cfef1a8sm37588f8f.56.2024.08.09.10.27.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 10:27:28 -0700 (PDT) Message-ID: <341acdcc-1745-436b-a3c7-26916b675175@redhat.com> Date: Fri, 9 Aug 2024 19:27:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/40] mm/memory: page_add_file_rmap() -> folio_add_file_rmap_[pte|pmd]() To: Vincent Donnefort , g@google.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu , surenb@google.com References: <20231220224504.646757-1-david@redhat.com> <20231220224504.646757-9-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 35EA412000F X-Stat-Signature: 9js33m3tf98gkwietisf1t71nb53exa5 X-HE-Tag: 1723224453-507857 X-HE-Meta: U2FsdGVkX1+mz6GoVvLY/jhQYi2D63tV/MrXqtm79dn00DuVKmBaYlqpBvGmVUDNG+q6kGAejgUylst7MP/JwXdgIPMVPQgyEahrGiunacmah6a2I2kSeqLrBuDXehO2dNkCpjvs7Ikz24ggY7QiBX9RkXsdLuqP8BX1XIrA7Pn2nQl5qIZvr4mx9IRzCsebInpbT04TNTUEP9zNDGg0boZZid3Pti2Z755shUXQwGAaDynyC7HQn4E/2wttnSDRvyfLMJ2eaKpv+ZaspUoMSWM9y1innFJP+AsNpgbu7+OjIqPLAOS2T7c4oaZ/rfaL3xAHHdokV3ly7NMMl9DKKRXb6HNV/Co757kqSeEZcJh+wRTKPsmgEnwQBxByD4GmpCpHNBzuKYHRcdZvjHq4qh9i1novblZrRS1XWi2vKuj/5B4QAMy5cLXjkCA7HDT9w7A4ZJia1zmJuKBpIJLTyUqLLYULHJEmU1RQMlasAEP+bwswzhSX+Pzgle9+wcPbPTOYrX89ZbMV5PVN0KCcdyB/c0ppU3m5wBlhKAvkODUjm5EfhykciYmCSHldUFpq8MUo92wmotTKNFcwbiPdqf9izDGu0F76hGg8vbXEMBfG9Gvid4Z9McKu+KSZt7invg4sIEk3gPqfQI05MztW6gBceO2lkE+JLRaess2LjpyrDlu+vS/JyWwXGnbX+V9KTFMnN00NMtIr+VarCPMoiYYnBVI8ABoFal24IHSFRr509m51rnUN6IkCkjYP4NXJZ94UOCMvDSd0ylK7fKuUcJUIzOV7ACkydODoVmbiBEQ8d1ji1Jt5lVNEsflawR53WvebbCvrmvUzXY0xJSffNi87Jz6wVt9yABwFIHSZxTgPw4mGOGPj7V6V4SHVdbS9CSa+IizNRvA2RfMZpnNOUGyBOuGkyYMAuLljLg/x3k0lG8muid78q9jL+QYc9q+NHgy6X+up+trTKRwHY6C V4XWs2ZI DaHUbi5PH2RIuDwotxL17LohH92BnPwy5xKdkJLeZ6gouPcGLxZPbmjYuFa3N7FiuliZVkBH4dVtzcmN+yqgRh7i53Iy7PCzCu6C85Makr9ob2VJSJN+upo1gx9EWvtwA3tvmtsaMq8yTwaHmFf/MTd67Nz5g8k4LIVs7BQfWl3ScRj6m4Z7MOB4m1Tyf5uwupF6GpSzwTgMvwf+8tVr/zHyr6e2yPj0IqKU8DG4I0wrbyb/hJ2wylJDgIqjhzkXja3atTfb4SFfhjBv+8+8gCT/Yt2NaR/v/mlMFovGe+Z4GJJLW4VkkCON9nXrYQQJBMbbEVUOC2YNihL+nvK9ZTbimUULWVVD4Qn/OiS6QXAODdFezzaJrJ6Gtvd05xMERlyuK157DM8B+ZWqFyRmi2B2L1v86ijnw6lQYIm8fz4CiaZGK2fjN0YoBrTQ/6axwY/kfKuSy7oAMfRjV7v3tZK1i8K2DCcTNGfpUZN0EPVG1+JTJ1C9Jm7BQNJCZE/NTQyu6WBlKjSnLaRavoLxYVQm6fCG8kvNBiVCDTRJidsrrQ74SrudqH15YGf1Whg0EwTRqQf2K9Rthea8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.08.24 19:13, Vincent Donnefort wrote: > Hi, > > Sorry, reviving this thread as I have ran into something weird: > > On Wed, Dec 20, 2023 at 11:44:32PM +0100, David Hildenbrand wrote: >> Let's convert insert_page_into_pte_locked() and do_set_pmd(). While at it, >> perform some folio conversion. >> >> Reviewed-by: Yin Fengwei >> Reviewed-by: Ryan Roberts >> Signed-off-by: David Hildenbrand >> --- >> mm/memory.c | 14 ++++++++------ >> 1 file changed, 8 insertions(+), 6 deletions(-) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index 7f957e5a84311..c77d3952d261f 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c > > [...] > >> vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) >> { >> + struct folio *folio = page_folio(page); >> struct vm_area_struct *vma = vmf->vma; >> bool write = vmf->flags & FAULT_FLAG_WRITE; >> unsigned long haddr = vmf->address & HPAGE_PMD_MASK; >> @@ -4418,8 +4421,7 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) >> if (!thp_vma_suitable_order(vma, haddr, PMD_ORDER)) >> return ret; >> >> - page = compound_head(page); >> - if (compound_order(page) != HPAGE_PMD_ORDER) >> + if (page != &folio->page || folio_order(folio) != HPAGE_PMD_ORDER) >> return ret; > > Is this `page != &folio->page` expected? I believe this check wasn't there > before as we had `page = compound_head()`. > > It breaks the installation of a PMD level mapping for shmem when the fault > address is in the middle of this block. In its fault path, shmem sets > > vmf->page = folio_file_page(folio, vmf->pgoff) > > which fails this test above. Already fixed? :) commit ab1ffc86cb5bec1c92387b9811d9036512f8f4eb (tag: mm-hotfixes-stable-2024-06-26-17-28) Author: Andrew Bresticker Date: Tue Jun 11 08:32:16 2024 -0700 mm/memory: don't require head page for do_set_pmd() -- Cheers, David / dhildenb