From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72EBCCA0FE4 for ; Fri, 1 Sep 2023 14:41:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97ED18D0022; Fri, 1 Sep 2023 10:41:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92F858D0002; Fri, 1 Sep 2023 10:41:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F7818D0022; Fri, 1 Sep 2023 10:41:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 717508D0002 for ; Fri, 1 Sep 2023 10:41:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 460F7B2D80 for ; Fri, 1 Sep 2023 14:41:10 +0000 (UTC) X-FDA: 81188291100.17.04A00CB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 0649D8002A for ; Fri, 1 Sep 2023 14:41:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LcGOFDFv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693579268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OqmyNseuv44Zzv1WRU9GbdFKMiMfyfVJ64aicRpb+Xw=; b=vrlSztUwbjdphbwSq+iZAW9oH5YC06/MskIPChtE+Pbus5bqMU78nEn5FTQUdwCWDvM4ib 4U8TZ4GZ4+X7zQZ8Dphcco8dbTnR6VhLH+e1uQ4JY7Ui2XddV5zDd+pBbu37hhY1A89vrN h+d7zCkjAnplpRYMYrOWCZtWBSSHVPo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LcGOFDFv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693579268; a=rsa-sha256; cv=none; b=L6sXCIzOg5uTkg2oFsScz7kwpZGqwero9i6MMecWXMV1R/id7Hs+oIkh6tTsia8XWRRWJZ 88m5hvxUDDVbFQVV0lOhwbIfTNEF+9ww11vgvXlFYmZvEIwZynebHZj1A52frsgtyeZDcd uzb8GqsdYQDq9uSU6LgrW6rY5pv6Vng= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693579267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OqmyNseuv44Zzv1WRU9GbdFKMiMfyfVJ64aicRpb+Xw=; b=LcGOFDFvLQODRaN0ande9A0+kMSJIKmLjGHMKFA94FV0V1xUXNVN6X3I/SPocKmTfZRTAp r1t5FCPrVnirCixmNjcLfiw/97Mnh8XkRz4jY1EK6MbbBki81vZTd5xxBPmh6ez+1j2q0m nShNAIpFDO0bBVH25Lu6tkJzot18fqk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-iXHjxvihP36K2XFuMS4gVg-1; Fri, 01 Sep 2023 10:41:03 -0400 X-MC-Unique: iXHjxvihP36K2XFuMS4gVg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-401e1c55ddcso15780935e9.0 for ; Fri, 01 Sep 2023 07:41:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693579262; x=1694184062; h=content-transfer-encoding:in-reply-to:subject:organization:from :content-language:references:cc:to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OqmyNseuv44Zzv1WRU9GbdFKMiMfyfVJ64aicRpb+Xw=; b=ITPc1REWXGA+XHF0OUfLl5Zbij96LOXB1Ro+6R7XD6duoBcmE8Ecc/QxMRFpzFbJM9 yVIRGQ7dnT+88Dah97IOw2v0qxpysuFzGgfY1AxTRaZlJKk07q/YM/Ibje0G3Kczgkdd zUQIH/PgoLUX5Gz/A1KA+XhgCfe0spjY5t3TFSLbHo8o4wNpRV1vJX675ldCJRPodfjG qLcVRtg3Ug4hE84VqsT3LKzBsLeLOJWmiZgGEq2TgIRwl4kyLh8bX4biWqNq7jBS6FRy dHPa0Ve1NCdn0koUCP3W6I+XZXlP99qUXVO10flhNEN/xDFM7dhTSUNbLF0GxdDQ6KSA hhdA== X-Gm-Message-State: AOJu0YxDvQbgsLXRQqzvEWt12CpEFDfZKBrKqFMBMdaZlBQEMecLe/hq lXHguSnQt8itdSptwK4XhxLf0hJn3eg48jAijQBYjgruKxLUkpmXWp/EKrtYVHQG2OyR1xfOy8g gCSyupR9aDLo= X-Received: by 2002:a1c:7715:0:b0:3fe:16c8:65fa with SMTP id t21-20020a1c7715000000b003fe16c865famr2277857wmi.4.1693579262501; Fri, 01 Sep 2023 07:41:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXFD2NQLNXWVAoK1IYmHVvhJD5QOCX5CJMB4P6IfjReWthYnob1B4GGaOQ2pj7Q1/lwThk4Q== X-Received: by 2002:a1c:7715:0:b0:3fe:16c8:65fa with SMTP id t21-20020a1c7715000000b003fe16c865famr2277827wmi.4.1693579262127; Fri, 01 Sep 2023 07:41:02 -0700 (PDT) Received: from [10.59.19.200] (pd956a06e.dip0.t-ipconnect.de. [217.86.160.110]) by smtp.gmail.com with ESMTPSA id n9-20020a05600c294900b003feff926fc5sm5086171wmd.17.2023.09.01.07.41.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Sep 2023 07:41:01 -0700 (PDT) Message-ID: <341a66e1-c71a-24e8-3eba-6c2fa16babe0@redhat.com> Date: Fri, 1 Sep 2023 16:40:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Matthew Wilcox Cc: "Huang, Ying" , Ryan Roberts , Andrew Morton , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, David Rientjes References: <20230810142942.3169679-1-ryan.roberts@arm.com> <20230810142942.3169679-4-ryan.roberts@arm.com> <87v8dg6lfu.fsf@yhuang6-desk2.ccr.corp.intel.com> <5c9ba378-2920-4892-bdf0-174e47d528b7@arm.com> <87cyz43s63.fsf@yhuang6-desk2.ccr.corp.intel.com> <4e14730b-4e4c-de30-04bb-9f3ec4a93754@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v5 3/5] mm: LARGE_ANON_FOLIO for improved performance In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0649D8002A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kbb6igzwfq4bsuic7rchowhkqsfzr3tt X-HE-Tag: 1693579267-766754 X-HE-Meta: U2FsdGVkX1/4Tpm2/MVVzPsw/IH39dD4MU3F7yEhQbpwfGTQyCRS8OhGUzilGe+Z2gW+nvesbZF2u7bzve1TI1DpmrfCiv19pqiaX2/LDEmazLFkgJ+UiNogFVnh+Ch446mNkn5rXzG/w7jrD4iz3DTgndxE3qzRtLzVja4tCeGQ8IztFNsrTVLqN1xaf9M5WrydGSgYFg0SXOcVTDSrPIbniPARLrKNEzo5f9Dj/NTGvAylWOO14lz8ZULgpYzX+5JJDRxBHwOV/cwDennytiJmG3qvZwvxwkfTzT2iVS8uy77KupDRaV5iVAbjbE9zEnaZdcI/MdIaKH0/RZ8q41JuHxpCRlAava1fJszKfMpyYsOS081LqU9fK/EFc8eC/KGvTH+iIG7vUAtDZWv6R82cFBuHX/UqVgqvyzIFbS6BqC74D7BvtSkXo6rFOFUEE5GD+QZOJ1RVVDzIuxHq61se9/3IW913bSQEO0ozCEDmSHnlocq2EaZRHVdWhGel0028ouQKDsRBhAyyou6O8/0gU8Vs4Ue1q9e+FamnEPmRuPkJwieNLwCEA0lPlyU8scDUN8poubIOuAXl47QdrD6yeIMqqKIC79upCrMBQ786ewdzELu4E2yHFhFkt4BZtL1rwn/7VD1TL/zUYQrclH/A3M486962CM/mMZpsRAbzdJ8WUkhBVtsM22YT1zgkLThPcC+OXayBuT19piOJT9a7vmNadyG4xZdIR3unGgAp8gMrHhAfTlk2AizrXDPI40qUbvttqWGp6OmAVre+uCzWKYWMMX/Gg5MPhaxXFmEMDdFKBm91bmFFptTjQgWOV+AYgCumdsou1sNFdSVbrOfBB48Em9w4ZoMOtfAT/c8Fyw+A58JcXwnYj+BhHnonJC937vrvRqC71Mgu9bpyT6TbQF1xRsJisjiRd2eUL+EN0kErkZLbyQwGwcVT+11bB66hbbVOfQe6aiSsrKZ At00+Krc FLX+sAumTFwuB+Kq1XY4/udzae1syayPXsd9b0goG7CuA7iQIoNG1/h2cHXfqivPfpDM/P07QJPD4rki9uxjdmkuG0jDM2gzAjP89kB6VsMgCzjMBZwMptvk1g5bsoOFAWlQ5P4Kv3JuXFpXoeVKLjR2zxaCzzdXZn1jl1wRJbOXuPJOXw1EbX8qlgh3+yCiz3e8CvLKpuJvfiT79HeKW04wHxehqHk4uhb4wmJtofSukuYMF8+tUmNYftrAUp/2zkPL5QapvNM7L91JnDU+twDFEtknGzuw+yP11J0QM230ShsCISXVXKLrsREd2vKV8iUupiTS+v6hpC5HU9dSP5MfWxwDtiZ83kiEyvbyiakIi5/DHicDlkikixLM0h2j1K9JoD1cRYKI5V9fToS4fkBMRosvUYy6JH/wfQiKrK/yuvVW52b0NVwF8DlTBYsNFblmh+PUY4ua4n01dMLG9DYlmUUOlg8y7NmlTHnI9H4vsHBQo/TdpjoU0/lzm0Vl3fufgxlqYuec+ySI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.08.23 14:29, Matthew Wilcox wrote: > On Thu, Aug 31, 2023 at 09:57:46AM +0200, David Hildenbrand wrote: >> As raised in another mail, we can then discuss >> * how we want to call this feature (transparent large pages? there is >> the concern that "THP" might confuse users. Maybe we can consider >> "large" the more generic version and "huge" only PMD-size, TBD) >> * how to expose it in stats towards the user (e.g., /proc/meminfo) >> * which minimal toggles we want >> >> I think there *really* has to be a way to disable it for a running system, >> otherwise no distro will dare pulling it in, even after we figured out the >> other stuff. >> >> Note that for the pagecache, large folios can be disabled and distributions >> are actively making use of that. > > You can't. Well, you can for shmem/tmpfs, but you have to edit the > source code or disable CONFIG_TRANSPARENT_HUGEPAGE to disable it for XFS. While you cannot currently control the exact allocation granularity, you can limit the effect it has on apps that are sensitive to rss (memcg) changes. See See as an example: https://www.suse.com/support/kb/doc/?id=000019017 For the pagecache you arguably don't care, because the assumption is that you can reclaim that memory anytime. So even if you allocated 2 MiB and only mapped 4 KiB into the process, so far you can work around that breaking existing setups by setting fault_around_bytes. For anon memory that's quite different (as of now and in the forseable future). For that reason, we have all these knobs to teach THP to not over-allocate memory (e.g., no thp on page fault, don't fill holes in khugepaged). I know that Dave R. can share quite some details about that. -- Cheers, David / dhildenb