From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E888CCF9E9 for ; Thu, 26 Sep 2024 07:08:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEC0C6B00A0; Thu, 26 Sep 2024 03:08:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9B496B00A5; Thu, 26 Sep 2024 03:08:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C150A6B00B4; Thu, 26 Sep 2024 03:08:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9FF886B00A0 for ; Thu, 26 Sep 2024 03:08:08 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0E6F91C7170 for ; Thu, 26 Sep 2024 07:08:08 +0000 (UTC) X-FDA: 82606010256.15.DB2122A Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) by imf24.hostedemail.com (Postfix) with ESMTP id 8D59318000F for ; Thu, 26 Sep 2024 07:08:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wSW+aXCy; spf=pass (imf24.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727334365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WclAnEXrzF/Gh4XbPxe2UDc6ATX/PcOlqBxVSmpUuVc=; b=YNZwXuDcdsbu2yJ4GQd1NC+M9Z3X9fYPBkGwqZWUo52a0WFNYvi7iQ4B8dTom5fpaudXRX P0zH4VbeFLrSJxzc+y+y5B7b7K2A11deqPSbyOf9tdy4c7Zk7hHmKIVi94pWvtaLdhP3n/ rL0s94Qb85Dup5vTjA0atJOb5t+GxOA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727334365; a=rsa-sha256; cv=none; b=PaS1B1EyUWivW8SXXQ2oq98mjH77FTKr500FDG3e7yML+2qKwdRdVVlK94pxkUhnP+hLDr BF6pXyzqQ2rflCn6lCeYof6ZzmPQGnBRD+TiEYiNIiX1WqOKh797pu9KyvCpVYgtwukRc+ uhdZFCTfGMVP29BPamXDfPkrBBI2oHo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wSW+aXCy; spf=pass (imf24.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727334482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WclAnEXrzF/Gh4XbPxe2UDc6ATX/PcOlqBxVSmpUuVc=; b=wSW+aXCyPsY6o4Dgbx65oTZJus+k13XJPDe/aM8cYxqcxGDREgn/+D7RD88j2kVPBa6cEI TykwwfZRqNlzTSPcaPt32nBl94JX6Zb7m3ubsqol8cO5a4MjKGHfaFvFbdW3CN2OMt1qMh MYXHGvqROg2c9qWaxO2wmgI48lcLwog= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Subject: Re: [PATCH v5 07/13] mm: khugepaged: collapse_pte_mapped_thp() use pte_offset_map_rw_nolock() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <055e42db68da00ac8ecab94bd2633c7cd965eb1c.1727332572.git.zhengqi.arch@bytedance.com> Date: Thu, 26 Sep 2024 15:07:12 +0800 Cc: david@redhat.com, hughd@google.com, willy@infradead.org, vbabka@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, vishal.moola@gmail.com, peterx@redhat.com, ryan.roberts@arm.com, christophe.leroy2@cs-soprasteria.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Message-Id: <3418680E-14B2-4098-8730-6F569ABF51DD@linux.dev> References: <055e42db68da00ac8ecab94bd2633c7cd965eb1c.1727332572.git.zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Stat-Signature: u53h1gttwng1hgx4wkucgoihu83kuc8p X-Rspamd-Queue-Id: 8D59318000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727334484-488193 X-HE-Meta: U2FsdGVkX1/G7UQpy/c+iADaWJLkIdAq9uPBDOWyRNE+fL+Vq/9c7LLErctbAAZxXgklB86a3A7NS3fENtVWS9+tNulFh5X5uuifQXd/ViPL/KW88+z9ZhTG4VPZO0OeWsrpblYosymC2PWrRciQw/h5PfpdbWnGm6BPaoN2jhNepKLZ3/qdJzdA4y0p5/iILGc+XtAbQ6ZDqUeaGdRwyIxr2qQEZkqZSEP0F0YM1sY1t3jVBFF/gKHOspofuMhP4N125KXSBGzVCiMqQYHcX3VTibA+rl9O8YPuiiUt0+lBk4wtCeq7IeZ9fRru/NX8vCZZEmgzwsqDU1JycJPLUqeVeResVuL4z+PaDznbu5GFlZZJP5PrxBLzN6RBebPMGA1BNwpYZ9aq283U090YkKrcyOx8OJqES3hRQMvSJlG1hZR6m5jg+z4MTNB1Je3ZQjglavXO20gMaGe+wQ0+trn6DM1CQDUJkYrAeHQek+68v19Y+e46BhYS8i+l0TOvGf2vuSwPKekboAR6JMODmO5H2O/iqlFwbrmT9dITugNzwkO8hwvnWNhTnmtAexG5yRsLupxEktYtLVN/flqZB4HhbT+opRNNi39YJaKTo/9GXxLTiqhyoJxzv3IzAirTucBwh/a7reuxXTapVjB9+naJo9WQbzWhZtyNPQ6T1hYQjrG0yW8Zb1mmyPQg/bRH6dfV4UvEdhPYMJLLvGJ3K5EgXi4fzn2abha5bFtnhnvqqRi3/vgKNEy/p099LOLQsjjccIeu/SiL4xo+RSVvuTmJ7ZOEBY2hSgG7bFuKepAdMeUlokg9MwYVA8uAYb0tsgnDHI9pK8i77QVuD30I1HomfabM1963qfSBM4f2RXWKrOfcSTrNkMz2/jAmFl3TzqmKVQ9vrArEACGcn0KaYTkjPFDTks/46fv8Ewk/EIuBqCqc8yaUM1DY2Q4FGRKVzN7xOrQzfVBh0r+iInn +TVJzL0Z AZy9STkN+y2HLwVS5Ql7TjEStZIW1yYcBl095bGSXjk1n0lrERoJxMMx/90qeOUUe8TUjc4NDZ8GNcIGoN/jtBRaun1PH7K1z7+sIHo+YBGKm8WQ8ANt//TPdd9Az78IOTfROCqHFuZkZ6dc4fice9flOpublUaefPynyfs8eTOR8Eo5AOb7C0+3TbbqF7IV6cUBbH59S5Qb5ZFmlA2X/D954oJfONIODykuUsrRqGoPcLJ5ZRJpDWvaLaESK4FUM1QMX97z+s49t9uriXs+CdvOS6/D2oOX+oAqmtunsJAgSl7j+C80LasmIOswZSFTvHmxGX16BTE/bNuJ1LHt+zYxrz5IqoJMN7e1o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Sep 26, 2024, at 14:46, Qi Zheng wrote: > > In collapse_pte_mapped_thp(), we may modify the pte and pmd entry after > acquring the ptl, so convert it to using pte_offset_map_rw_nolock(). At > this time, the pte_same() check is not performed after the PTL held. So we > should get pgt_pmd and do pmd_same() check after the ptl held. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.