From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A72F9C636CC for ; Tue, 7 Feb 2023 15:22:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25E606B00F1; Tue, 7 Feb 2023 10:22:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C0236B00F3; Tue, 7 Feb 2023 10:22:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 039DD6B00F4; Tue, 7 Feb 2023 10:22:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DEF606B00F1 for ; Tue, 7 Feb 2023 10:22:13 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A5AB5A03A2 for ; Tue, 7 Feb 2023 15:22:13 +0000 (UTC) X-FDA: 80440861746.15.3D07D83 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id B2BA0140016 for ; Tue, 7 Feb 2023 15:22:11 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WblU9YGV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675783331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l+MitBe2EyJwjQSROuNpetHX6JtYUVSt9jGRlkcNJ9A=; b=WykcrG6ZUidO2vdtJIDYR+hBaIkKKgqee4nhJWiV4IXzjMfKmzvlNysJlETaEDnWLKtP3g pqZVnlEUKpQ9ApikI8mb3bmGIzRIvjY8yHw86W3RNIMBJVMKFeIBg+KR1ZMh9mBV0C3ncx wFdmIG6+omew7kow8C+ih8Ub61xJ9Eo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WblU9YGV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675783331; a=rsa-sha256; cv=none; b=7VGQoTFYiVBEsL9AfzMVhDYnwKBfv6bNqim+BUgzOleimJz/QKhkuh5K6Kcslkkie6gbYD 6aIyuYlVmbaJiFPksvwyA3SjF4ZUoc3pYQelDBWVbchsjdXXtlmyTFWLdMqQ7VpMHXsz8i qVKTNdtQ8XYV24xcbwqF0cwPUcw66GQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675783331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l+MitBe2EyJwjQSROuNpetHX6JtYUVSt9jGRlkcNJ9A=; b=WblU9YGVGb7p6GPuUHWyJRM724C1rNr/qIkD9WahlVF06yzNmaFn/SutWTNWXHCy5odwrV sSeX13u/8ziXdLaKjt82U9cY5WgCJKbTWox6JTGYQDppe8vEyfJhJywje/1VjoSgra5xKQ Ezieu5f9YgBMMw+TH6HnMfGErZE5AYE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-Lfrk-Rt4O2m45zEoYlywPg-1; Tue, 07 Feb 2023 10:22:07 -0500 X-MC-Unique: Lfrk-Rt4O2m45zEoYlywPg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 49E9F101B44E; Tue, 7 Feb 2023 15:22:05 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78412492B21; Tue, 7 Feb 2023 15:22:03 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230207133916.3109147-1-dhowells@redhat.com> References: <20230207133916.3109147-1-dhowells@redhat.com> To: Jens Axboe Cc: dhowells@redhat.com, Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/2] iomap, splice: Fix DIO/splice_read race memory corruptor and kill off ITER_PIPE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3417264.1675783322.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Tue, 07 Feb 2023 15:22:02 +0000 Message-ID: <3417265.1675783322@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspamd-Queue-Id: B2BA0140016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: zc1fbhpegukicowo7znrw1renzznffzc X-HE-Tag: 1675783331-591121 X-HE-Meta: U2FsdGVkX1+cOALncRB3FclBbGrUIBjixzEypGfKNLBny3MRiFQfYL6f6h89JX0eR3gxLBGrZ/0ZvLP53XVjCiuaZnxK9pgCXgrjlcFhR8Z+f5aqbXRmWtb3+17Z5Xox6OfQ3JCJhQUMufuZcrALMqe97Fixe/gfEkUxt7022Z1oTY/Qs2cLBS7hkkOR/M3YKL+Hdi+4pjdFkvyA3qzoA57oHeYfumJ3e/PUkI5FV2HMpzmdqZ73xAGhvCKSe5hr0BI74eSdMF07z8yL2V25M7B6lsm1Yvkg0IRTHuOe1chQk11er2Kaats2zjC1Ze9aMIRENE8Vh8MWQMSVOafLvMiKLwU9M+ynDTSTDqX/CosVC7Z85L94ZaGZhwb6WUH8kXTXk++CYoAkrwFlOdmeUQjWe8Sz9FM0LwsRTW3ixdOd/vUnxy6fmADna+tMJOowUpEXmdczpewpCrEdQeetd0661xYecxLvjEmtpJnou7Z1DY3Ci07TIqJV7xlQhHUZ4sM2j/hj6n5aqinP6UzUJtHsdcKDmRls0x+ra8BWf+8LNfae3KHms3VFWl6c7UQ0IDc0G0aokjFIrhAz/eR7t2QJ16pJBKYNMDZxFy017oproX35AOdq9j1PgbW7YMgHjZLERUY8TdyWe1Cph+SuwvijmFYpmB8+R/Q9/UOuPRtvGf8qTv7yosmlLAi3FNgs+ZDL71FIWeaDIfWtWY73T+DA6QO/2B2eJGtmUbUe+q8EaUGq99T2+fnAPHIhS6hhS/9mBN7kS+Oa8hbUDhYiYCLmdSCe85So8Qwcx4CHNfDsRIbzg2jRSoMNcpoiD9cA/beZBMnZzcQDbUXWCUkBy+6VmT8KmWrLOe93bSfyyj8gjc28Eew8t6mhmnYwZcLXcVzEncq7BdHmZS6QBU3ZBIPoSzsgtAeDIjJ2ySm+vDmKJlKfcF778vzMFN1vUvNvSrJ63wDswRfdsFoocZI Ygv6vVMf doY49EqJgcwLoe4us6xfeJY6PNjUp3hXA3VXYG27CBwxRx47NvWH2J2/vzoEJlRQLkU9kpMVJP3X7+AgP+3BlI4TsCrBS1iIoKwMwnUYsU0uuhF2Va8Ro4gxjAVAUJDYJDqmSw5LPdL/2Ek2jVudH9Cx/cXuK4yVsJwiguL283rpiFXP55aimrW4eVdV4G0lriXMivrBgFyu+QPQ6aCWzc3x5qq04EH3bnxAlOFTVNbunxeXKwp7npR+xGld9B2CFrVUePbvxxOnzqWVNzLcMUVlZ3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Jens, > [!] Jens: Note that there's a window in the linux-block/for-next branch > with a memory corruptor bug that someone bisecting might hit. These > two patches would be better pushed to the front of my iov-extract > branch to eliminate the window. Would it be possible for you to > replace my branch in your for-next branch at this point? In case you would prefer to do this, I've updated my iov-extract[*] branch= to put these two patches at the bottom and pushed the other patches back on t= op of it, dropping the pipe extraction bits from the iov_iter_extract_pages() patch in case you want to use that. I've also removed the FOLL_PIN that was in that patch as it's implied by calling pin_user_pages_fast() and is being made private to mm/. I can also repost the full set of patches if that would be useful. David [*] https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/= log/?h=3Diov-extract