From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E07C021A4 for ; Fri, 14 Feb 2025 18:17:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10B5028000F; Fri, 14 Feb 2025 13:17:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BBDB28000C; Fri, 14 Feb 2025 13:17:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E777428000F; Fri, 14 Feb 2025 13:16:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C8CB028000C for ; Fri, 14 Feb 2025 13:16:59 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 529ECA084B for ; Fri, 14 Feb 2025 18:16:59 +0000 (UTC) X-FDA: 83119356558.17.B5FD80F Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf05.hostedemail.com (Postfix) with ESMTP id BAF2E100013 for ; Fri, 14 Feb 2025 18:16:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=esIS5XmJ; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739557017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CFVs+Lz0k0E0JLIg3Fxkoe7J/Swppaxx3OA5S3RyKT8=; b=pufG97mFZqSFgP+9cJHN6OXo4VhbUNOQVvBruL5OqPSJwIKHHyhYCV0QOobACoH+RYpLk+ PKLGZabIo7NCSr43lhAqcq2l9fze060Y9ZtEQGxJsPiAsecG2c4bouCJCBYRoMLeKfaQVu JJyDjfBx0rcfVktX27wzWhgkzpVyQn8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=esIS5XmJ; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739557017; a=rsa-sha256; cv=none; b=JQmHAT7wTC2VolfilofVhFoZ1B7Cr6i7UEyjK7I1NXSKI3AOmUR+0Kuv4yKJ3RykBeMXPS 8rpIPjYHDE/tGxEiUIx1jF/9Efx29HUN9OOsms4x7HKX8BDyrcwevRDmnqrqVCzgO00bxC 36u0Y3oSGozOIFn0mBymG7GTOIL7it8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739557017; x=1771093017; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lxYe9AM1ilptoz8PFAJgQoXR64WcvmMY1VFqYo8awI8=; b=esIS5XmJzFU3marESASHbEYBLsqREljQ3vgzHwEM1xrfxFJyaQBmTL5F 16x5DlO/l0EDZ3izGYYdwo3Vu16MkC0Xx9rQoxuMFKlAN5ecOPH9pNr9q ymV6Q/c7yojVlx0sVkB/zq95EQ9RXYdTr7+OjyNmClfBJeP3xSTIv11ZE 8bmK4iugt4TOVVOnLck+k1nVqfSmn1mULehvS7Js4KhBeXd+4bhHK9sOF 40H2/QrOk0d+UKQTncLkvQOTN2FOswfr7lx/OKzy0yFTSuw9p+MdK/2sk QWfYTgwrYbAqoo6j2o/M+s6CeBhEUkxEO9xmSkMb9WBtg+BXovjw0neje A==; X-CSE-ConnectionGUID: k+gnkv6jSz+fEuKQKOVYnA== X-CSE-MsgGUID: zlZXzJcqRyW7z8Sx3fy0+w== X-IronPort-AV: E=McAfee;i="6700,10204,11345"; a="40455965" X-IronPort-AV: E=Sophos;i="6.13,286,1732608000"; d="scan'208";a="40455965" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 10:16:55 -0800 X-CSE-ConnectionGUID: P+g8tzUNSgi9u2QQ8LTF9Q== X-CSE-MsgGUID: iz41BeoARLiStHylkiab9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="136753603" Received: from tjmaciei-mobl5.ger.corp.intel.com (HELO [10.125.109.21]) ([10.125.109.21]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 10:16:53 -0800 Message-ID: <33e34670-3c24-46d4-9c26-c05a03a8a1b0@intel.com> Date: Fri, 14 Feb 2025 10:16:55 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 04/12] x86/mm: get INVLPGB count max from CPUID To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-5-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250213161423.449435-5-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BAF2E100013 X-Stat-Signature: 7877spk8d1t8ko3bpnh9hso4kec6o3nx X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739557016-231090 X-HE-Meta: U2FsdGVkX1+IM69fliJXfHcpD39ynhYTIusq1t/1eWtYMdfygQ2qjsJaiEsUXlTKT9y+HLNkHBWALbtUfZv6bVHbFICO22H0f+VqNpUFRvCHEUwkHYJDggyRUWCvWZYyIaqgm8kEeSA9nMTk73ueDe9X3w+hpUfPo5jhaPNhWfd9Ak3jI+cemis+ug6C3oXWZi5vveSZqewDmTx6dPfel9QX3Zc9cEveg2tH3qLIACnUJwIdhFKQ2oBEvw+SDUNUssV+kRpj8X+Sdve2ZNB5bc+9l4TdcDaGlXrG7yOBx05ArvmNswMUGtoxnMmZmenUMPSLxQ/oYKXEXW9q3REb+Or8yNgfOvRCaWt2n0/WEayrrb9EP32QpBXqhSWvLbyc0b1pYLjAIBVBNPZpLxLJt8Yg4aDDdOxTz26S+nBrzbMXTJ1Iw3OCLm8VIB1fZz/kDTosxTOYiQQne6IfZqAzYdYAgNGryia8EWlB7RQ1uG2lx5czwqp+hC2oevQbWT8WuqgzamVlh5EtvOCFNsJn6pwKUZLbMMtVy0LUgN9fhXAzqWIVSJRqvXj8RpweT/b6cQ3HZklZaPZQL/81pD8GiXVD7msu3N0QGK20X+RG/6HCfZXCv929vBHRLDoNYy1OeM0G3lj6mXBKXAs+U7Y79mPLcT0P1iUwyexz0hIJeEpH6ZjFbvCqBXn9M6LpdmZ5fCQZsTjW1zr533PjVeeKHG2Z8ZlQIm6zqB2MMD/du5b8/cvY4NnowwB0Q0TMJMQZBOQfiiRetWML7gWwZ2FN6xUxuajP8rGLKzFKUuFykXBNfsOzZ/Dq8f+XsUNOR9dreZy3XycPVfLTIurW3/WCZ4w+FaUiXrMh+Meim3Ed78qIe3d8ZQrjWcPUxUr1yzeLLk1yfkEq+70NG0bN2tnT2WruFrI83OanBsDZxNDp4ZMmMUvY4GFNAvsh9R6cOAhfVfdQ1spgNrEOWbziu93 qm9otmEz MnT4MLBwOIEr4R6bVOaw+h8GKdgEu96sKRA7iDYYnSkBhA0sfIUR55sg74PgO5Adx8xyLycOAUNfHar6gIwalBnSdnRAlpWqPxN9+ilTu2Kp8ijFyKoU6rMtUIdLOPULX3UuiMCVRQbzCRsvBGHYCk0Ljajf7yLmgxFeIQ+zUdTw/8UTzam8Ej3POfkdoKlTv2o5Ber7PDHdcX1m6f3M0cGVGs7b1NzVj6qXTJfJvdHJOpargkdtbATUCut0FkGYjSqeESz+ciQ2adxuqMEhTlredPEwYdHCuXNTq8tIhK2hLLeU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/25 08:13, Rik van Riel wrote: > + /* Max number of pages INVLPGB can invalidate in one shot */ > + if (boot_cpu_has(X86_FEATURE_INVLPGB)) { > + cpuid(0x80000008, &eax, &ebx, &ecx, &edx); > + invlpgb_count_max = (edx & 0xffff) + 1; > + } > } My only nit with this is that this adds a seventh place that the kernel reads leaf 0x80000008. The users seem really random, though. Some cross-vendor stuff, some very AMD-specific stuff. So, I'll leave that at a nit since I don't have a good suggestion for solving it: Acked-by: Dave Hansen