From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8906C001DF for ; Fri, 4 Aug 2023 09:36:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4620F2802E5; Fri, 4 Aug 2023 05:36:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EB302802E1; Fri, 4 Aug 2023 05:36:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B2C42802E5; Fri, 4 Aug 2023 05:36:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 189A62802E1 for ; Fri, 4 Aug 2023 05:36:21 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E0BD4C13A8 for ; Fri, 4 Aug 2023 09:36:20 +0000 (UTC) X-FDA: 81085916520.10.C2E668F Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf05.hostedemail.com (Postfix) with ESMTP id D35C810000F for ; Fri, 4 Aug 2023 09:36:18 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=VOaKqkAf; dmarc=none; spf=pass (imf05.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.167.48 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691141779; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b3lbJTLxyqYJX0fxtiEjE0xWQWcO772B/HmxfLlMWGA=; b=woZwWZg35+k8yQ7+eH7v+/WiFEn/KVO0PntzsjsWqcEodukSElf4etYKnVmIKgku7YlAR+ e1w7366/NcKiXsCVpl1evt9X/WXHuIGfEJjjLeXs4SpGEny0VGgWco0bts3NWFhTkaHoL2 mTdHKg0U3aRYWyb7xKlWJw/WZmFM49k= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=VOaKqkAf; dmarc=none; spf=pass (imf05.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.167.48 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691141779; a=rsa-sha256; cv=none; b=sEXkiy9l0HMZ4mC4ZUnQaYuour1TF9p5owuKUyaTfXEZHMpzbVxmnf03y1RX8KBgqUpSp5 EW3KgI3c5Nk0oGXV2AelFqY7yvHtNHp/ab6rhZ7AOAYyTiL+pSLlclFmVRM7+HxbHyEDun uMgAvfBQeCoriBk8b81ihtxg6x2UnOo= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-4fe2de785e7so3289561e87.1 for ; Fri, 04 Aug 2023 02:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; t=1691141777; x=1691746577; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b3lbJTLxyqYJX0fxtiEjE0xWQWcO772B/HmxfLlMWGA=; b=VOaKqkAf6Ep3eJbBlWy9/IfPkSOcVAfnCdKa61kGrK9qIsaBTnsYi2wrOoVw5/Anz9 o0Nl5P9GLkcGxZbnZwQtJtz6TS03bSNyduzjiAO3yHHn/fyYYjBOjNIbfJbW6gdXSshh TvpfE3d/oyH+XKNNV+hJ4nVutixXFaxHRfjfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691141777; x=1691746577; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b3lbJTLxyqYJX0fxtiEjE0xWQWcO772B/HmxfLlMWGA=; b=Px0SdBGlU2o/r0Zbs2At1b/w1whRSREuEBycollx8Cb6GKba7aFeZd6ya/zBWrGx03 NIG6LhdYBK7fLw53+h+PGLk3iZhLJKa+qgHTFRLWdCLcEiWtJjQWLLeS8mWctYsGf0g1 xHmxsTCBCZAWaroyNd3Qxa1W11q8IrC6wGtF212pYpkaHufFFgTF/pf5uvYRo84I99L+ 8gr7UR+WneeVAtkl4zllFCn6/qNacUp1E+wdssoRjKPRnnL6jdUsJohYbbPKaQHIjF6g kSyCQ6p+/Zy1Y0zA6Q6bm+M2H31WGqS7MaLWTA+REc5ZB5yXpCxLuRhGb33RCZl5BPFg Uvbw== X-Gm-Message-State: AOJu0Yz5jM63hm+LOBNW4Zsu7UYM9Fz4vvI5wt4+GLw3spf/tbBlM/N8 8fhWvd33UgwcHzTCgs3Y4Eon6w== X-Google-Smtp-Source: AGHT+IFc2EnskwxlAotytkXsvAmMAiyzBKtBknSNu3wCYyYRLeDZbPirG2dtzOZRMIYX04Z5L4cAow== X-Received: by 2002:ac2:4eca:0:b0:4fd:d9e0:4d79 with SMTP id p10-20020ac24eca000000b004fdd9e04d79mr801440lfr.6.1691141777216; Fri, 04 Aug 2023 02:36:17 -0700 (PDT) Received: from [172.16.11.116] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id i13-20020ac2522d000000b004fe461aab36sm303606lfl.129.2023.08.04.02.36.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Aug 2023 02:36:16 -0700 (PDT) Message-ID: <33e128e8-9330-c73e-4c55-e56cbc87450a@rasmusvillemoes.dk> Date: Fri, 4 Aug 2023 11:36:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 3/4] lib/vsprintf: Remove implied inclusions Content-Language: en-US, da To: Andy Shevchenko , Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton References: <20230804082619.61833-1-andriy.shevchenko@linux.intel.com> <20230804082619.61833-4-andriy.shevchenko@linux.intel.com> From: Rasmus Villemoes In-Reply-To: <20230804082619.61833-4-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D35C810000F X-Stat-Signature: qx7j8aubqgmcsig18kzomfn3wzmy6jda X-HE-Tag: 1691141778-678013 X-HE-Meta: U2FsdGVkX1+3qOUHngw/N3QoKlD4Bex5aFt2lvJH5TnsiDYZNTszEVduh6+8scZVpEcjahKEgBwJWEsD+DLBVvR8+Ishl04QPiz7NqRhtOXZrMBUe7Xc9GjaNzGurkPiTXFs6elqgleOpVWhjZpHR151BAut+C/Gav5xoHdoRIplO1pDWZJLpFu6CKA9KlLG/05wO1XRf/0ejFkVcQfu3ukhlyqkuW8uLTAE3tf/b3Stp6Ku7ssPBRqib3wT4S6HXIssKDHFW6TJd1S0mW2vc6rkoIRV7bqCLD7eUbcJ8R+W5i3nZUmsQE6c5maWc8gHwFOXl/DP02lRgdw2IwLB/f6aa1RDg2Hhwy/DxT2QAwSVPulrJ407Al8QfKa9tetKy4GyvmfwzcCMCoQUMgYRfE/walCYnIdKlBj37vP9Gsc2uWfTixteTInmzjj342BPLigsCsiyD06hmqQjx5QANslGaWJPV6MshnZvIQ+kACPOpUQXdyoRcO1/n1ehyHussnXxo8HVwdUcWkIe/o5u+CdOtHO9QLIy80QA3GvVis2qLvL5YWTURlyD7ray64okWAajjIH0rJw72YUOb62lIjgYWBrNtB0aNPK74L4RyyqWhAyJDTk086z5y/KZUQhH3KqDjSCcOfax9ATre4EZ7mJBj69mUr/GxX4kKv5CzuN0CeJF9lCpl9aUPihCoCWDRqjFq4+YmTPyo9NctDWLWx45Ehka+Y56ICEqA1Yif+jC7P6QtnjBLLuh4Cl49KC3vKuaxCuXyqrtR0v/rAGUJ5STw3uWbF++za6ZO6HSF4o3Oy/tAohQbBhpcagBYD3FW+vHfDKFSQA5dPqe6W74PUv9SufSCM4iRTZcZgxbHEo/CwRhYRGsVcKsyefVxiBYdL0bTf7pjX8esIwZM/xQIhbuL1DIuoluVT+BZ2ONOLqZpDUhptGgEKOLSKDaD6/KtIJHBEjaM1wIO+iD7sp kaWkCxwo +4rA50VSGheT6aNzqiUR96F/1wJn7LKdtyvHQoT07u5HVTemHygeLGR/UuIdPpsTFaWp6FIR59X6mmpBx2cbvvvCWAU9PRB1LWzCijtBo197nT3b1MyGJd5uIsgb1znpT7335Sx4poMvq9QMj0IQa20gO43pGegudMOy5Qk/wKGG8MnF/uqPYRQ1XuK3yxbB0psFlQfifoGCMts+KZfME9jPqnWAu9ZJaOx39XB/zDghxUaFrXUj4r77cD4TJKfd7WXSn3un22615XJhgtt0ldJNTO6mybQkK3e3j0uckqSdkkpJuB+clVJ65wfTe6+wMqqs/yjMEeQy1XXqG2mhgp3BxT8F9MdNBrNUrzzCkmh0cfJQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04/08/2023 10.26, Andy Shevchenko wrote: > Remove inclusions that are implied and guaranteed to be provided by others: > > compiler.h by types.h > string.hi by string_helpers.h What? No. That's not what we want. Each .c and each .h file should include the headers that declare the stuff they're using. So if string_helpers.h magically stops referring to anything from string.h, one should be allowed to stop including string.h from string_helpers.h. Sure, those two may forever be so intertwined that it never happens, but one really can't maintain some matrix of "X always includes Y so if you include X you don't have to include Y" in one's head. Rasmus