From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marco Elver <elver@google.com>,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
linux-mm@kvack.org
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 3/4] lib/vsprintf: Remove implied inclusions
Date: Fri, 4 Aug 2023 11:36:15 +0200 [thread overview]
Message-ID: <33e128e8-9330-c73e-4c55-e56cbc87450a@rasmusvillemoes.dk> (raw)
In-Reply-To: <20230804082619.61833-4-andriy.shevchenko@linux.intel.com>
On 04/08/2023 10.26, Andy Shevchenko wrote:
> Remove inclusions that are implied and guaranteed to be provided by others:
>
> compiler.h by types.h
> string.hi by string_helpers.h
What? No. That's not what we want. Each .c and each .h file should
include the headers that declare the stuff they're using. So if
string_helpers.h magically stops referring to anything from string.h,
one should be allowed to stop including string.h from string_helpers.h.
Sure, those two may forever be so intertwined that it never happens, but
one really can't maintain some matrix of "X always includes Y so if you
include X you don't have to include Y" in one's head.
Rasmus
next prev parent reply other threads:[~2023-08-04 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 8:26 [PATCH v1 0/4] lib/vsprintf: Rework header inclusions Andy Shevchenko
2023-08-04 8:26 ` [PATCH v1 1/4] lib/vsprintf: Declare no_hash_pointers in a local header Andy Shevchenko
2023-08-04 8:38 ` Marco Elver
2023-08-04 16:55 ` Steven Rostedt
2023-08-04 16:54 ` Steven Rostedt
2023-08-04 8:26 ` [PATCH v1 2/4] lib/vsprintf: Sort headers alphabetically Andy Shevchenko
2023-08-04 8:26 ` [PATCH v1 3/4] lib/vsprintf: Remove implied inclusions Andy Shevchenko
2023-08-04 9:36 ` Rasmus Villemoes [this message]
2023-08-04 20:31 ` Andy Shevchenko
2023-08-04 8:26 ` [PATCH v1 4/4] lib/vsprintf: Split out sprintf() and friends Andy Shevchenko
2023-08-04 9:31 ` Rasmus Villemoes
2023-08-04 20:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33e128e8-9330-c73e-4c55-e56cbc87450a@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox