From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8264C19F2A for ; Thu, 11 Aug 2022 09:40:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 145738E0002; Thu, 11 Aug 2022 05:40:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F4788E0001; Thu, 11 Aug 2022 05:40:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F25E88E0002; Thu, 11 Aug 2022 05:40:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E42C38E0001 for ; Thu, 11 Aug 2022 05:40:42 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B5127415A7 for ; Thu, 11 Aug 2022 09:40:42 +0000 (UTC) X-FDA: 79786817124.20.D6302BB Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf14.hostedemail.com (Postfix) with ESMTP id 366F7100175 for ; Thu, 11 Aug 2022 09:40:41 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 69F90B81E64; Thu, 11 Aug 2022 09:40:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48850C433D6; Thu, 11 Aug 2022 09:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660210838; bh=q/v3dg67akdikMYOPlR6gnL028wD7LycKf4a1kmvX/8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=E7ayhDL52bXNsVrHoUoyQ+wAZTeoQifLoV2Q4j53SPWNLt+B4oGEld0OCpWBv3m4M MRdCcNQWMkMOgnqbkXIzXYESAxfuPjpP+i2xyIJcAYz1D+AnKjugGeK6JaVExqybUk cSsdrpQsrNWpdG1iGGCltAJ5ZnhZKrKb0CNPv+4r2suTy+mSRhOcRi/RK4SMR++KdR FO8pQAEGor1lVJorzA00qlrJwehxOXAQZiIb0dNzstoMxS/0wRLpzYd4MwvAqZ1SQY +HR5qDsEBw9/k1atUUZwnGqjRyET5xfAfkHQg799YyQUybMgCLVqgUIb5EEmdYkMVu aBdCEWsDlCDPw== Message-ID: <33d41fbd-a2ed-d2ef-4395-e18aac7c0d28@kernel.org> Date: Thu, 11 Aug 2022 11:40:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH v6] mm/page_owner.c: add llseek for page_owner Content-Language: en-US To: Kassey Li , kernel test robot , akpm@linux-foundation.org Cc: kbuild-all@lists.01.org, minchan@kernel.org, vbabka@suse.cz, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20220810013218.27416-1-quic_yingangl@quicinc.com> <202208101628.o6qUzx50-lkp@intel.com> <54f974fb-f334-78cf-d5f5-198810cc77b4@quicinc.com> From: "Vlastimil Babka (SUSE)" In-Reply-To: <54f974fb-f334-78cf-d5f5-198810cc77b4@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660210841; a=rsa-sha256; cv=none; b=eo2PSTwmc19exVeRF/YhVFTo/k+XsjhLlzgt6ayezeWZKeddpV3t2M3S1JUhFRDZ79ypnW lj+mI01atFS9xnipLyqQpePVyUqDmiFVwXiktfAjrIScOzh+9LgjmvfnpyCa0f/nrW1R40 MkvZtW5+eARqlNELMmaikmkVVAe84tE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E7ayhDL5; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of vbabka@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=vbabka@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660210841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7RKRuqZKqXVo9jhuegHJIjo3czibbjv4Gmps4g9AfYQ=; b=3JgpcjXA9R13kIgXyBiblbh7L+V24/mthcx2HHJUdt2QjgP0GNQSDlS/BPPxIb++b3FZzh d89HcNxTL+Dn9cI3EGVpr0ZznApoXabF4IOiHJOy+c5z2IlgNZGAGVG8J8hcLo4xvsh/BP jRtO4CBv6AssMf3WVaK+yoxG8dlSgFA= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 366F7100175 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E7ayhDL5; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of vbabka@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=vbabka@kernel.org X-Rspam-User: X-Stat-Signature: tmfcf8d37izitxyo95jxp9ursmhkidut X-HE-Tag: 1660210841-420909 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/11/22 05:02, Kassey Li wrote: > hi, Vlastimil: > > > On 8/10/2022 5:02 PM, kernel test robot wrote: >> Hi Kassey, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on v5.19] >> [also build test ERROR on next-20220810] >> [cannot apply to akpm-mm/mm-everything linus/master] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url:    >> https://github.com/intel-lab-lkp/linux/commits/Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220810-093417 >> base:    3d7cb6b04c3f3115719235cc6866b10326de34cd >> config: parisc-buildonly-randconfig-r004-20220810 >> (https://download.01.org/0day-ci/archive/20220810/202208101628.o6qUzx50-lkp@intel.com/config) >> compiler: hppa-linux-gcc (GCC) 12.1.0 >> reproduce (this is a W=1 build): >>          wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> -O ~/bin/make.cross >>          chmod +x ~/bin/make.cross >>          # >> https://github.com/intel-lab-lkp/linux/commit/d2decd69a8d5756c1706092c805a4c8af14df471 >>          git remote add linux-review https://github.com/intel-lab-lkp/linux >>          git fetch --no-tags linux-review >> Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220810-093417 >>          git checkout d2decd69a8d5756c1706092c805a4c8af14df471 >>          # save the config file >>          mkdir build_dir && cp config build_dir/.config >>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross >> W=1 O=build_dir ARCH=parisc SHELL=/bin/bash >> >> If you fix the issue, kindly add following tag where applicable >> Reported-by: kernel test robot >> >> All errors (new ones prefixed by >>): >> >>     In file included from mm/page_owner.c:16: >>>> mm/../fs/proc/internal.h:51:9: error: unknown type name 'proc_write_t' >>        51 |         proc_write_t write; >>           |         ^~~~~~~~~~~~ > > # CONFIG_PROC_FS is not set in some arch, so we can not directly include the > header file. > +#include "../fs/proc/internal.h" > > how about add an extern  ? or do you have other suggest  ? Hi, I replied to v5 after the bot reports: Sorry, my suggestion (to reuse mem_lseek() from proc) was wrong as the kernel test bot just showed us. mem_lseek() may be unavailable without CONFIG_PROC_FS. The easiest way is to add a page_owner specific lseek function back as in the early version, but make it correct for SEEK_CUR. Thanks.