From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B90E77178 for ; Thu, 5 Dec 2024 17:00:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E6F76B0146; Thu, 5 Dec 2024 12:00:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9970F6B0147; Thu, 5 Dec 2024 12:00:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85EC96B0173; Thu, 5 Dec 2024 12:00:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 680096B0146 for ; Thu, 5 Dec 2024 12:00:23 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DF595AF4D0 for ; Thu, 5 Dec 2024 17:00:22 +0000 (UTC) X-FDA: 82861518222.26.7967C3B Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) by imf10.hostedemail.com (Postfix) with ESMTP id 1BDAAC0008 for ; Thu, 5 Dec 2024 17:00:11 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dKoqPgxn; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733418013; a=rsa-sha256; cv=none; b=djvgWDlL0qFogBhZgALvr0zNSRw8DIvOslcqhJLHUAxKFtGCbtu1uLSAqvRbNleVaLVf9K nzzjNJIuHcc4ArdnM/HBB51dyEFFF9rlfHUD4JNWoftPMITUAwGFllDs+XpAVd2KZ4cegd SAQhNwaQ58CD3eUTiVIFxE8mGVa0FiY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dKoqPgxn; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733418013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mO0UIbfAAT857srzsQRM1yeqtHRA0tGKkLFerm/srE8=; b=Pn1PufQ7ns+K42koZF2JSLJkr94/7BLfZdZFZ/DSYsC3UFxoZRGPmqcqM9rI3knAHTMQoW DQjFm+FFfJOHNp3j+Zuydk6oHF/sNN9V2Y8C0cmRjFACP8gpcTeGzfn7hn8f1D5bDseyt9 n9sGJZgoP/h4QW1+kXqP7PLEchWFbkU= Date: Thu, 5 Dec 2024 09:00:05 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733418015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mO0UIbfAAT857srzsQRM1yeqtHRA0tGKkLFerm/srE8=; b=dKoqPgxnaKlyoLuWp3m1SRi9EaOCUIvyw9inFhbiAMknHVGSODxiv4kUMrxbpzv6bvFh7v ZaeV5AFQOJ5uBlnC7hVNG4QSWRtE/1cCJocWPVbbEffi6kcPizbCm1YW2p9cR0an5fGGLJ giBKNdYwa64aSuOfnavG/St+pDto6W4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Hugh Dickins Cc: Andrew Morton , Baolin Wang , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH hotfix] mm: shmem: fix ShmemHugePages at swapout Message-ID: <33cp6mak3viari6dkmq52htfulpagzhct4mn533nhghstny2gj@yfdax7oitydw> References: <5ba477c8-a569-70b5-923e-09ab221af45b@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ba477c8-a569-70b5-923e-09ab221af45b@google.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1BDAAC0008 X-Stat-Signature: 3roq53u7ogrfc7jxxhotach9uqauefdx X-HE-Tag: 1733418011-369543 X-HE-Meta: U2FsdGVkX18nXZVt61kN/khmnSX7727+OOfKnXhHoPmq/Hieuf7LSkP3h4ROogPmklMINgJsEIMauixn6zc6BmtUevivV4dUFoBvkhixkLAqzoN6ia/KzLbkIwDg5xIp06ytb+CxArIwHIY3fGdIut/ND6LjxsFhTR0/NLETgZbRI447Gj2jiJn3n+laIh7E1qvDcJQRB7hpEBO7UODlq6A06X3xacoPpYXAnHojhN+ed/FHlYoiX974vwizCPR4kSx19nekLZwbbxCaf6zEqzjwXjq20feuqDE5SP6V4PN/D1cTzoq0xxFqoFXtPlMI8L6bYFmTC2c1ncUBL+0jhamX9yV7Hkln5A63Na25POkkyiFesRPM806wKWU+VpN0hbtm1LBolz5nFvDm1cCH/JOLuXM6dnDwcqXI9jQokMZAhlTxHw9I99Zmb3m2it8r23Ed/b3p9ckMdc598OD+LsggERzZKeJL+ibOtmmOFJgtxRWK+FuZoKjlLUXmEWMyDkLgAaAO02d2Df7bZ/LThChRbwwMjTgUMq0hbE9OYm724vP5czKhMB+jlm3eZesNFHassgYtYrVzfCS0dsDnfhRuKgQPeVswj+77vQ3z6mVki/L7CRXNmpjpJXolPN4EKiUc3ULGvUiMOXZT36ZcVRXZ8ze+0CQNEnenOUZjrqgce4kFNOlR1m8/BdSz2AKCHPZ0Oc4GRbo0vgZW1nAFWLAOIrrjNHWpYhWRo1gldkQUFUU9jk0kr2CPvaywgqItJF7c2yOkEKVVGwhea+0jV3HRRKIKbyJLtE76dONKwrGmnSxiqxGowWHq1j59S8x4lZbnLA58IGMtfrww1fWAaiSHjXuKlYI0RqCYrzEV5rxOfud+NM3LwWOu4IEogUUDx+d61iKu1OEr5nnU5s/LFfvB6vt60/7VsPhIGGpPehSQDd/G0sbx8XXWyBnmyCrFcT65Y0u0prkF1Tj1a71 +t22VsSy SgRQ10raTtmhSjbMU9wWGZ8nEavG2iRRZBpUCdAhzEzxYn+D2E/gyYVgOQqTzZIqVy7hdWQs7dTelgfLG736NyOSkUBOINDk1czGdctnq15I6ulyFf0YbqDkgR4H2vPQpC0lfb5jt1aMYLuJYzuJcqI7zo11MPxEyzEShsQ8k+oBdZ86Lj4GgZ8SniY9gqvL+r3XUnFK86KJ2oqZQjeOOCemp+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 04, 2024 at 10:50:06PM -0800, Hugh Dickins wrote: > /proc/meminfo ShmemHugePages has been showing overlarge amounts (more > than Shmem) after swapping out THPs: we forgot to update NR_SHMEM_THPS. > > Add shmem_update_stats(), to avoid repetition, and risk of making that > mistake again: the call from shmem_delete_from_page_cache() is the bugfix; > the call from shmem_replace_folio() is reassuring, but not really a bugfix > (replace corrects misplaced swapin readahead, but huge swapin readahead > would be a mistake). > > Fixes: 809bc86517cc ("mm: shmem: support large folio swap out") > Signed-off-by: Hugh Dickins > Cc: stable@vger.kernel.org Reviewed-by: Shakeel Butt