From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C36C433E0 for ; Fri, 10 Jul 2020 01:21:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A789A2070E for ; Fri, 10 Jul 2020 01:21:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A789A2070E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 027686B0002; Thu, 9 Jul 2020 21:21:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1A0D6B0005; Thu, 9 Jul 2020 21:21:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E09316B0006; Thu, 9 Jul 2020 21:21:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id CC0A76B0002 for ; Thu, 9 Jul 2020 21:21:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5635C181AEF0B for ; Fri, 10 Jul 2020 01:21:13 +0000 (UTC) X-FDA: 77020412826.24.spark29_600ce7e26eca Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 2EE081A4C5 for ; Fri, 10 Jul 2020 01:21:13 +0000 (UTC) X-HE-Tag: spark29_600ce7e26eca X-Filterd-Recvd-Size: 2893 Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 01:21:12 +0000 (UTC) Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 5C638CEB53E9A7DF348C; Fri, 10 Jul 2020 09:21:09 +0800 (CST) Received: from [127.0.0.1] (10.174.186.75) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Fri, 10 Jul 2020 09:21:02 +0800 Subject: Re: [RESEND PATCH v5 3/6] arm64: Add tlbi_user_level TLB invalidation helper To: Catalin Marinas CC: , , , , , , , , , , , , , , , , , , , , , , , , References: <20200625080314.230-1-yezhenyu2@huawei.com> <20200625080314.230-4-yezhenyu2@huawei.com> <20200709164845.GB6579@gaia> From: Zhenyu Ye Message-ID: <33a5dc75-8209-e198-bb41-8b4ab82c000e@huawei.com> Date: Fri, 10 Jul 2020 09:20:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200709164845.GB6579@gaia> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.186.75] X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 2EE081A4C5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Catalin, On 2020/7/10 0:48, Catalin Marinas wrote: > On Thu, Jun 25, 2020 at 04:03:11PM +0800, Zhenyu Ye wrote: >> @@ -189,8 +195,9 @@ static inline void flush_tlb_page_nosync(struct vm_area_struct *vma, >> unsigned long addr = __TLBI_VADDR(uaddr, ASID(vma->vm_mm)); >> >> dsb(ishst); >> - __tlbi(vale1is, addr); >> - __tlbi_user(vale1is, addr); >> + /* This function is only called on a small page */ >> + __tlbi_level(vale1is, addr, 3); >> + __tlbi_user_level(vale1is, addr, 3); >> } > > Actually, that's incorrect. It was ok in v2 of your patches when I > suggested to drop level 0, just leave the function unchanged but I > missed that you updated it to pass level 3. > > pmdp_set_access_flags -> ptep_set_access_flags -> > flush_tlb_fix_spurious_fault -> flush_tlb_page -> flush_tlb_page_nosync. How do you want to fix this error? I notice that this series have been applied to arm64 (for-next/tlbi). Should I send a new series based on arm64 (for-next/tlbi)? Thanks, Zhenyu