From: Valdis.Kletnieks@vt.edu
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Nicholas Krause <xerofoify@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm:Avoid soft lockup due to possible attempt of double locking object's lock in __delete_object
Date: Wed, 31 Aug 2016 17:08:26 -0400 [thread overview]
Message-ID: <33981.1472677706@turing-police.cc.vt.edu> (raw)
In-Reply-To: <20160831075421.GA15732@e104818-lin.cambridge.arm.com>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On Wed, 31 Aug 2016 08:54:21 +0100, Catalin Marinas said:
> On Tue, Aug 30, 2016 at 02:35:12PM -0400, Nicholas Krause wrote:
> > This fixes a issue in the current locking logic of the function,
> > __delete_object where we are trying to attempt to lock the passed
> > object structure's spinlock again after being previously held
> > elsewhere by the kmemleak code. Fix this by instead of assuming
> > we are the only one contending for the object's lock their are
> > possible other users and create two branches, one where we get
> > the lock when calling spin_trylock_irqsave on the object's lock
> > and the other when the lock is held else where by kmemleak.
>
> Have you actually got a deadlock that requires this fix?
Almost certainly not, but that's never stopped Nicholas before. He's a well-known
submitter of bad patches, usually totally incorrect, not even compile tested.
He's infamous enough that he's not allowed to post to any list hosted at vger.
[-- Attachment #2: Type: application/pgp-signature, Size: 830 bytes --]
next prev parent reply other threads:[~2016-08-31 21:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 18:35 Nicholas Krause
2016-08-31 7:54 ` Catalin Marinas
2016-08-31 13:24 ` nick
2016-09-07 0:45 ` Rik van Riel
2016-08-31 13:41 ` nick
2016-08-31 14:35 ` Catalin Marinas
2016-08-31 21:08 ` Valdis.Kletnieks [this message]
2016-08-31 21:28 ` nick
2016-09-07 0:51 ` Rik van Riel
2016-09-07 1:12 ` nick
2016-09-07 1:22 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33981.1472677706@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox