From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: "Luck, Tony" <tony.luck@intel.com>,
Kees Cook <keescook@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Joel Fernandes <joel@joelfernandes.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Lorenzo Stoakes <lstoakes@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Ross Zwisler <zwisler@google.com>,
"wklin@google.com" <wklin@google.com>,
Vineeth Remanan Pillai <vineeth@bitbyteword.org>,
Suleiman Souhlal <suleiman@google.com>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [POC][RFC][PATCH 0/2] pstore/mm/x86: Add wildcard memmap to map pstore consistently
Date: Thu, 11 Apr 2024 16:11:55 -0300 [thread overview]
Message-ID: <3391c693-cf54-526b-79a8-d565e7140947@igalia.com> (raw)
In-Reply-To: <SJ1PR11MB608317E066B6B3390F55FCB1FC072@SJ1PR11MB6083.namprd11.prod.outlook.com>
On 09/04/2024 19:25, Luck, Tony wrote:
>>> I forgot to mention that this makes it trivial for any machine that doesn't
>>> clear memory on soft-reboot, to enable console ramoops (to have access to
>>> the last boot dmesg without needing serial).
>>>
>>> I tested this on a couple of my test boxes and on QEMU, and it works rather
>>> well.
>>
>> I've long wanted a "stable for this machine and kernel" memory region
>> like this for pstore. It would make testing much easier.
>
> Which systems does this work on? I'd assume that servers (and anything
> else with ECC memory) would nuke contents while resetting ECC to clean
> state.
>
> -Tony
Thanks Steve! Like Kees, I've been wanting a consistent way of mapping
some RAM for pstore for a while, without resorting to platform drivers
like Chromebooks do...
The idea seems very interesting and helpful, I'll test it here. My only
concern / "complain" is that it's currently only implemented for builtin
ramoops, which is not the default in many distros (like Arch, Ubuntu,
Debian). I read patch 2 (and discussion), so I think would be good to
have that builtin helper implemented upfront to allow modular usage of
ramoops.
Now, responding to Tony: Steam Deck also uses pstore/ram to store logs,
and I've tested in my AMD desktop, it does work. Seems disabling memory
retraining in BIOS (to speedup boot?) is somewhat common, not sure for
servers though. As Joel mentioned as well, quite common to use
pstore/ram in ARM embedded world.
Cheers,
Guilherme
next prev parent reply other threads:[~2024-04-11 19:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 21:02 Steven Rostedt
2024-04-09 21:02 ` [POC][RFC][PATCH 1/2] mm/x86: Add wildcard * option as memmap=nn*align:name Steven Rostedt
2024-04-09 22:23 ` Kees Cook
2024-04-09 23:11 ` Steven Rostedt
2024-04-09 23:41 ` Kees Cook
2024-04-12 20:59 ` Mike Rapoport
2024-04-12 22:19 ` Steven Rostedt
2024-04-15 17:22 ` Kees Cook
2024-05-01 14:57 ` Mike Rapoport
2024-05-06 10:38 ` Ard Biesheuvel
2024-05-08 23:23 ` Steven Rostedt
2024-04-09 21:02 ` [POC][RFC][PATCH 2/2] pstore/ramoops: Add ramoops.mem_name= command line option Steven Rostedt
2024-04-09 22:18 ` Kees Cook
2024-04-09 23:14 ` Steven Rostedt
2024-04-09 21:23 ` [POC][RFC][PATCH 0/2] pstore/mm/x86: Add wildcard memmap to map pstore consistently Steven Rostedt
2024-04-09 22:19 ` Kees Cook
2024-04-09 22:25 ` Luck, Tony
2024-04-09 22:41 ` Joel Fernandes
2024-04-09 23:16 ` Steven Rostedt
2024-04-09 23:37 ` Kees Cook
2024-04-09 23:52 ` Luck, Tony
2024-04-11 19:11 ` Guilherme G. Piccoli [this message]
2024-04-11 19:40 ` Steven Rostedt
2024-04-12 12:17 ` Guilherme G. Piccoli
2024-04-12 17:22 ` Steven Rostedt
2024-05-01 14:45 ` Mike Rapoport
2024-05-01 14:54 ` Steven Rostedt
2024-05-01 15:30 ` Mike Rapoport
2024-05-01 16:09 ` Steven Rostedt
2024-05-01 16:11 ` Mike Rapoport
2024-05-09 4:00 ` Steven Rostedt
2024-05-09 17:31 ` Steven Rostedt
2024-05-09 20:24 ` Mike Rapoport
2024-05-09 20:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3391c693-cf54-526b-79a8-d565e7140947@igalia.com \
--to=gpiccoli@igalia.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lstoakes@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=suleiman@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linuxfoundation.org \
--cc=vbabka@suse.cz \
--cc=vineeth@bitbyteword.org \
--cc=will@kernel.org \
--cc=wklin@google.com \
--cc=x86@kernel.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox