From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63496C433F5 for ; Sun, 30 Jan 2022 09:24:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C22B16B0072; Sun, 30 Jan 2022 04:24:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD3206B0073; Sun, 30 Jan 2022 04:24:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC20A6B0074; Sun, 30 Jan 2022 04:24:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0227.hostedemail.com [216.40.44.227]) by kanga.kvack.org (Postfix) with ESMTP id 9AD116B0072 for ; Sun, 30 Jan 2022 04:24:50 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2AB0980F9210 for ; Sun, 30 Jan 2022 09:24:50 +0000 (UTC) X-FDA: 79086418740.19.1402858 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by imf23.hostedemail.com (Postfix) with ESMTP id 70E57140003 for ; Sun, 30 Jan 2022 09:24:49 +0000 (UTC) Received: from ip4d173d02.dynamic.kabel-deutschland.de ([77.23.61.2] helo=[192.168.66.200]); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1nE6Rv-0001Py-Tf; Sun, 30 Jan 2022 10:24:44 +0100 Message-ID: <338bde65-5e1c-4e23-b4f2-671819c637cc@leemhuis.info> Date: Sun, 30 Jan 2022 10:24:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Thorsten Leemhuis To: Chen Wandun , Vlastimil Babka , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, guillaume.tucker@collabora.com Cc: regressions@lists.linux.dev, Oscar Salvador References: <20220117142712.3967624-1-chenwandun@huawei.com> Content-Language: en-BS Subject: Re: [PATCH] Revert "mm/page_isolation: unset migratetype directly for non Buddy page" In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1643534689;fae107b4; X-HE-SMSGID: 1nE6Rv-0001Py-Tf Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info; dmarc=none X-Rspam-User: nil X-Rspamd-Queue-Id: 70E57140003 X-Stat-Signature: jkyuxwab5pi3c5xkqypcwn4ssenw5w5b X-Rspamd-Server: rspam12 X-HE-Tag: 1643534689-845493 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, this is your Linux kernel regression tracker speaking. On 26.01.22 03:18, Chen Wandun wrote: > =E5=9C=A8 2022/1/26 0:40, Vlastimil Babka =E5=86=99=E9=81=93: >> On 1/17/22 15:27, Chen Wandun wrote: >>> This reverts commit 075782149abff45ee22f27315eced44d02b96779. >>> >>> commit 075782149abf ("mm/page_isolation: unset migratetype directly f= or >> That's an old -next commit id, it went to mainline as 721fb891ad0b >> ("mm/page_isolation: unset migratetype directly for non Buddy page") >> >>> non Buddy page") will result memory that should in buddy disappear by >>> mistake. move_freepages_block move all pages in pageblock instead of >>> pages indicated by input parameter, so if input pages is not in buddy >>> but other pages in pageblock is in buddy, it will result in page out = of >>> control. >>> >>> Reported-by: "kernelci.org bot" >>> Signed-off-by: Chen Wandun >> Acked-by: Vlastimil Babka >> >> #regzbot ^introduced: 721fb891ad0b Thx for getting regzbot involved, much appreciated. >> There should better be also: >> >> Fixes: 721fb891ad0b ("mm/page_isolation: unset migratetype directly >> for non >> Buddy page") >> >> Especially as that commit had a (inadequate, IMHO, for an optimization= ) >> Fixes: tag and could end up being backported somewhere without the >> followup >> fix/revert. > > thanks, I will send v2 Just wondering: Andrew, I don't see this patch in the list of changes you sent to Linus yesterday. Shouldn't it be in there due to above reason alone? And there is another reason: it seems to be an issue people actually hit, as Guenter mentioned in this thread. It thus complicates things for those that want to help testing pre-releases. Or am I missing something/asking too much in this case? BTW, let's tell regzbot about v2: #regzbot monitor: https://lore.kernel.org/all/20220126024436.13921-1-chenwandun@huawei.com/ Ciao, Thorsten >>> --- >>> =C2=A0 mm/page_isolation.c | 2 +- >>> =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/mm/page_isolation.c b/mm/page_isolation.c >>> index 6a0ddda6b3c5..f67c4c70f17f 100644 >>> --- a/mm/page_isolation.c >>> +++ b/mm/page_isolation.c >>> @@ -115,7 +115,7 @@ static void unset_migratetype_isolate(struct page >>> *page, unsigned migratetype) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * onlining - just onlined memory= won't immediately be >>> considered for >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * allocation. >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ >>> -=C2=A0=C2=A0=C2=A0 if (!isolated_page && PageBuddy(page)) { >>> +=C2=A0=C2=A0=C2=A0 if (!isolated_page) { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 nr_pages =3D m= ove_freepages_block(zone, page, migratetype, >>> NULL); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __mod_zone_fre= epage_state(zone, nr_pages, migratetype); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> . >=20 >=20 >=20