From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFBD8C83F12 for ; Thu, 31 Aug 2023 14:41:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4661D8D0010; Thu, 31 Aug 2023 10:41:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C7308D0001; Thu, 31 Aug 2023 10:41:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28EE38D0010; Thu, 31 Aug 2023 10:41:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 15F5C8D0001 for ; Thu, 31 Aug 2023 10:41:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DBA28A032C for ; Thu, 31 Aug 2023 14:41:48 +0000 (UTC) X-FDA: 81184663896.01.9131F52 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id 305661C0019 for ; Thu, 31 Aug 2023 14:41:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693492907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SDkJLzPPQAGRSmXQVN4I4HLAMmRssGZNl4z2L5+Iy0Q=; b=ZWR/aa/miGcOKFXe4A+W6Z7+avM0+d39INs666J392b8XhZkIlmenkx5lsrfe0b4++1W2C WEVQIxMDkpqYw7jFu2Ck5RMEEul0rAXcpHXLtG3UkuHXsts5HOBZ7pNEl1dl99SqXz3kUt /mo0Rc9Ma3PVR25v71L1cy9/301JOvg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693492907; a=rsa-sha256; cv=none; b=YTQFLOWn2m0fwR+IumQC5vPxm+uJLgEyJfeSfxod0X50Rk7hwYIiEym1nb+XqcXXIhAHRO 7otinkdCKMtuWSBCtLmo2dQ6KFV0fb6qgjOfCfYrZfyoIhTrIQZ/dH5+FTUMFA9FUiMdrg HLC7MX+/ziAE4eUKyZXtmt8frw7M7d0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1DCAC15; Thu, 31 Aug 2023 07:42:25 -0700 (PDT) Received: from [10.1.32.135] (XHFQ2J9959.cambridge.arm.com [10.1.32.135]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0ADF13F738; Thu, 31 Aug 2023 07:41:45 -0700 (PDT) Message-ID: <3389e220-187f-4e51-bdfa-f79b3d92c41a@arm.com> Date: Thu, 31 Aug 2023 15:41:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 04/14] mm: Use folios_put() in __folio_batch_release() Content-Language: en-GB To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org References: <20230825135918.4164671-1-willy@infradead.org> <20230825135918.4164671-5-willy@infradead.org> From: Ryan Roberts In-Reply-To: <20230825135918.4164671-5-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 305661C0019 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 51g4aqzu6uzm5cw731ob9ebj8c3sm8pg X-HE-Tag: 1693492906-431642 X-HE-Meta: U2FsdGVkX1/ROxTMmdtMcUp6JytjUnswDXBOqmbRs/6L7HjDb7R0V49Vhr6Fq1qC1jiDQp9SkWzFYGr8pYz0M0HPGZUdv2o0XUcJcipcByKhbQmHyUmSj+GR6WBj3BoXe9B4KwMY4GSQx6bk/fUDtCrP9tRFFQLd/r65yy/as2gxce+vIvJIR0oX/5pfM7dZG23a+3HffKuPH/2Ba7Yq+P4I0oySHhbSdePnOECWQb68kNCFHx+SmO/+IBwoJZUjQm2uf8cJVjTfemEYCKCTYUZU0qqWkgIlmjD1ofKgm43WdCDN7g4nqwDU6yLi2BU5r+pv9Nk1EWd1gusBy2UjBXM6MQ0nuKtPY+/dMjgolTx/pViZUUdB1VrXUvLmccXLKBwqLu9SewNzKsD+DKuZoneeFdvTuuzuUb/3MU4oKGe5JF64YXM56+Ms6FWixr6efhF+7uuQNqgsbHIqeiApPg1SlJrvpdu11pqH0O7hF9l63IdYzaZ+612fwcrMhjMrEHgPTm0ta9o5sj4gV1DkGMpKnKHaHcWJiEaK6quXD9rE0Q1gENsAb/BkipyNUx98ypNwiStLQmWtRIdrQ/JvA4VtA/XRV5A6KSRATinckTmXZHUE/30GJuNW3vZJnbIQLrX+02WdnEgrfkPGqhazBABiBmRwUdpY5wx8wcGwnLN6e4IhnTpK1MgVXSbQJYuDXI8OD3KWSEAumy5xfRzHiP1FdAJ+KlEI0hn6YKEGv3fpPqog6D5nBYogCqcm/5y58LIMoLOT1cEvNxqSfHIEsywL72HWvOA1X7nQTV3ciGEtPVEtmCm1Yh+usgqqKKOFFlnmG92crgoiyNG5wv+v9bosILieWS/QZXUXc8GE+UGyfEs0SOR2V8SXUdhmZaJys6uEPvd9XTgUdQSfLrn2H50pYGg5oJcdOGp4VKVb0fjot0D/vDVYQTYO7DT5X5QENl//3MzascV4TyDcobQ e7wqYDj7 9A9XQKyICgzaTR4SIZ13KLk9wFlCTq+DHVDuOhLjh+2PSMC7tez+5jcgFrSC9c1QUv1p7vfouJvsyEGbtwguzskSPVAE/roC/AMHQfMq3JfUP2w2szobVV1LxCc45DBO3Bgdb/Xbk7sr9zrhGwKEPeI5lVsOE0p3iH7B9khhdd1d1hgpScNSMRprWAjtr7z1t6wOfkIOVCc4FNEbOcIVRoPbBOXZix1flCVvf13yXMQCpFDfgJ9nWS1fdiVFiQu+bLw+3JdVX46yY106KZeZe5WeuoDiBMvN0j8yj7E9CC8i4HcvSXwyDygZ+8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25/08/2023 14:59, Matthew Wilcox (Oracle) wrote: > There's no need to indirect through release_pages() and iterate > over this batch of folios an extra time; we can just use the batch > that we have. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Ryan Roberts > --- > mm/swap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/swap.c b/mm/swap.c > index 7bdc63b56859..c5ea0c6669e7 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -1073,8 +1073,7 @@ void __folio_batch_release(struct folio_batch *fbatch) > lru_add_drain(); > fbatch->percpu_pvec_drained = true; > } > - release_pages(fbatch->folios, folio_batch_count(fbatch)); > - folio_batch_reinit(fbatch); > + folios_put(fbatch); > } > EXPORT_SYMBOL(__folio_batch_release); >