From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA08D767FA for ; Thu, 31 Oct 2024 19:12:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1DAD6B0089; Thu, 31 Oct 2024 15:12:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACC836B008A; Thu, 31 Oct 2024 15:12:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 994496B008C; Thu, 31 Oct 2024 15:12:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 734246B0089 for ; Thu, 31 Oct 2024 15:12:12 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C76A6A1779 for ; Thu, 31 Oct 2024 19:12:11 +0000 (UTC) X-FDA: 82734842064.24.ED6CF3E Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf26.hostedemail.com (Postfix) with ESMTP id 01C15140017 for ; Thu, 31 Oct 2024 19:11:48 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=CO847FxM; spf=pass (imf26.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730401798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+aMdUrek5lqvlZKodKKva4xJumBiFz9JBAG3043NKoA=; b=cIaEDpq+iNhlxU2N7VKyCmVJIJOE+24RyXb8WhcsIDY49JSjQElhBNoehJq/bb8Y37yld8 47k7PY5V14pB8RMHWAs219RRmI0bEKVzRiZ9qIqBGxBLTuKzyb1PaDdiV3LhOm6T0/Wu5w wmXUpUnZ1M4880JneVumvgNkqyKSg94= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730401798; a=rsa-sha256; cv=none; b=qdPyVhaGWuCkGa+VMOuhV/agOl6KUEHsJpFp8Nva0aZ0BT4N1hGwJE4uSHzU2ZvOYH9vik 68udzJFUe8gDVPkVmMLCqzpBFYjPnKGHg8Duh2X/7QcthlbnuOrIHrSQJAv6jvxu9ySPnJ izGMMONY3qI7eAm+XOI7Jq5ucRCkbC4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=CO847FxM; spf=pass (imf26.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com; dmarc=pass (policy=none) header.from=igalia.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Cc:To:From:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+aMdUrek5lqvlZKodKKva4xJumBiFz9JBAG3043NKoA=; b=CO847FxMlLq3zPRRQ1yey0VkO/ n7wcRKBMqedbA68kbbGyCA/yTfr4oa8dmGiTLm07L2X8aUo74Z2Ri7nTciOBhRNw+4lPO15zr548k F3MYeNSqHOy3wG5O9FODJoMeij0nFXfqwMDWFBy1psKRz9FG7C1CV2cJDgmlA/l/YyuBRmP9D41SE YpuXV8qQJ5RRHPHPZzrF93L4GNIpeMth1R1DZLzHGrPU1S+qouQuVRS8eODyaM35Wp+8f89xQxFxA QYAovVJ3JSk8nfqvSQvTNDMNj9LmMNQ0gYj9Ckya7vAK9AVgrkGanuzUcoFDGOPbguPlBIfnmjN3n exCpwDkw==; Received: from [189.78.222.89] (helo=[192.168.15.100]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1t6aaB-00098s-KT; Thu, 31 Oct 2024 20:11:47 +0100 Message-ID: <3386dc35-3ed1-4aab-abd2-42adfa25ddd9@igalia.com> Date: Thu, 31 Oct 2024 16:11:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 8/9] tmpfs: Expose filesystem features via sysfs From: =?UTF-8?Q?Andr=C3=A9_Almeida?= To: Nathan Chancellor Cc: Gabriel Krisman Bertazi , Alexander Viro , Christian Brauner , Jan Kara , Theodore Ts'o , Andreas Dilger , Hugh Dickins , Andrew Morton , Jonathan Corbet , smcv@collabora.com, kernel-dev@igalia.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, Gabriel Krisman Bertazi , llvm@lists.linux.dev, linux-btrfs@vger.kernel.org, Chris Mason References: <20241021-tonyk-tmpfs-v8-0-f443d5814194@igalia.com> <20241021-tonyk-tmpfs-v8-8-f443d5814194@igalia.com> <20241031051822.GA2947788@thelio-3990X> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 01C15140017 X-Stat-Signature: ed94n59zrgwa3tu3n5jnuaeh7fm6o8dt X-HE-Tag: 1730401908-94351 X-HE-Meta: U2FsdGVkX1+twn24iVZagteH2QeO1ArolCvgh5YQXJii7iNf9Rh7pAiUiOn12ihHKfCvL9a7PSiG5EY2HpC6MzU+g5aRTBOGlQynOMdJ6zjOzmq66GWimDxr3IC7zI7LVuFrQ0AHMUVxXk4Hyu/4QyYBBCCI05tlhXzGHWg8OGTOMPf7s/YzJbxJ3OBbhszPmpqr5Dmcdjut0DG0lNgm/vUQrUCX//l8UWQoTKTDjxlJhvQiCWjHKkG3LVrcRgyGPJ+BLIMAJ/lEJmkw2ZV7i6EzYyiFNTtN/9M5sTqmngV1zE9NYWyqk4dUlj6xWqbZvb5BshJZH74zasQmj5fO14JzOzDOwGtrjEdp0qgTnJqm1EXzyA5og30BO682PYH3Oh6TjrywlQuXlacYkO8e/DDb1T+nGHhRoBgzxOaJVLoWxK9MROQwlcw+yETJ9wOcAD1qdAdSvE+67jgm8SWb5FAdpyuuQAK08mDy3SgFw+Ri87qVpMt1Wr2nwtyXD/bSXThWv7IUGqWorSHvZ9YMNgbGG0iYnYiSzwEDw3yzSq7JSjXcBVT59p5r75McR5xBVmwAyA6SbdzhtkrpO0GttU1PfsJ34M/ydlD2/AZhH6+U5xZVtPv1jiAgRXgYCVR+DCNd4CifKJGqmhxu1wmP/Pd960yeVzq2YSIjiPnEpiexl4TjaP9VkLP9tR7XSXbfmELN0A0pyWMgdl2j7eNAKkTEDlApAgjAG3kYGBeJrowkWryOP6T1qxpd9wA0ZXhY2uiOUrxs+qFk5qwKegmA+oFtBvK9YZU4PPV2JlxpTiwken54sO2+seBc/LRyv3AzrdvRjCyuxkdAPmycUwmvlqYRjBR0PaWwIylen3EpullZTqp1WMjlGuobQXAzR0/6YrjP3fMJmiIgqUj0OpEoI3GkO4FKJo8gXi5XGqjFukKt8gCOB6fUyWc4P1GRmm34RerlmHAkVePxlciDQ3t nAXg2V6R RmQXKg6m7hKCZlTiY2w70FMGYJlXisuie8nxuhb4eRtCtXEuc7YqxibdjSqKRqt4iiMSBAiMaxIhGeoNye80A9mEWmt7uWoVSHntbEE7j4CC+Iqyh2GeYsOZKU+IUSo2uu3M1dd/GOg0228XnDgukmtv3e07vWYRgjIVREcRBQsJLEU54y0BYYrmgze1uF7i44i0k7Y7lwD/A0RrRxRSTmp27JkT6PjKc3MH9ufli8/16RyEgkpIwvjc8bPWSCCGlax+DSbD3KS9/p5QmOymeVbI5M0FoDpdufgJiHDQ3PtNsmRck8eCIQsH6og== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Em 31/10/2024 14:31, André Almeida escreveu: > Hi Nathan, > > Em 31/10/2024 02:18, Nathan Chancellor escreveu: >> Hi André, >> [...] >> If there is any patch I can test or further information I can provide, I >> am more than happy to do so. >> I found the issue, was just the DEVICE_ macro that I wasn't supposed to use inside of tmpfs, this diff solved the error for me, I will send a proper patch in a moment: -- >8 -- diff --git a/mm/shmem.c b/mm/shmem.c index 971e6f1184a5..db52c34d5020 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -5551,12 +5551,21 @@ EXPORT_SYMBOL_GPL(shmem_read_mapping_page_gfp); #if defined(CONFIG_SYSFS) && defined(CONFIG_TMPFS) #if IS_ENABLED(CONFIG_UNICODE) -static DEVICE_STRING_ATTR_RO(casefold, 0444, "supported"); +static ssize_t casefold_show(struct kobject *kobj, struct kobj_attribute *a, + char *buf) +{ + return sysfs_emit(buf, "supported\n"); +} +static struct kobj_attribute tmpfs_attr_casefold = { + .attr = { .name = "casefold", .mode = 0444 }, + .show = casefold_show, + .store = NULL, +}; #endif static struct attribute *tmpfs_attributes[] = { #if IS_ENABLED(CONFIG_UNICODE) - &dev_attr_casefold.attr.attr, + &tmpfs_attr_casefold.attr, #endif NULL };