From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71614CF9C6F for ; Mon, 23 Sep 2024 21:50:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C42A16B007B; Mon, 23 Sep 2024 17:50:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCB946B0083; Mon, 23 Sep 2024 17:50:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A45416B0085; Mon, 23 Sep 2024 17:50:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 862F36B007B for ; Mon, 23 Sep 2024 17:50:39 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 213DE81603 for ; Mon, 23 Sep 2024 21:50:39 +0000 (UTC) X-FDA: 82597347798.22.7131069 Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by imf19.hostedemail.com (Postfix) with ESMTP id F1BFA1A0014 for ; Mon, 23 Sep 2024 21:50:36 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=HZvEt5IP; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="L TdAPKi"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf19.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.159 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727128141; a=rsa-sha256; cv=none; b=GA2Geo4c9LElmoQJx1wetk9jzBvwEJDbkGvjHxH4pEXNuzEtxc+MdtiCoCNJaJhMkyILzZ BADyV7/iHUcRpvZ4Q2esjC/JuK0xt6oZFlO18hnSqN5Z1kZbZk6VXqh+ZvleFy8q7W1Olh zlHIxldzPbFaWvmt2C8qVpogblaM3ac= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=HZvEt5IP; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="L TdAPKi"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf19.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.159 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727128141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O9Q/eImCaEWCrXoZrzE5xrq6F5YUMncTztU3Tb7lqN8=; b=G3thrlFlHiqgrKBMG8igF2XU3DdQndaM351RkeclvwBakgqXh/mVtOV0WsASXabQ/9ALc8 fADjfu5L/4JGXJgZq7J0dthwwQ/jP29H48idiEwwGuEIP0cOuE1bLnyDNx1G9YCEdQ2BWd kzO+SXUDRDInk2DFLYschC1/7yQ3aPc= Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 312FD11401A8; Mon, 23 Sep 2024 17:50:36 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Mon, 23 Sep 2024 17:50:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1727128236; x=1727214636; bh=O9Q/eImCaEWCrXoZrzE5xrq6F5YUMncTztU3Tb7lqN8=; b= HZvEt5IPNg2ONCbdFOIUYj1y5TP7QfFXn6dSsbLLHlKnIbcFf+utUjHwJqjuHuXO 18HORSZinuDOb7QKRQsauCYDcsl7M/lO7pviDzkucfJzLxF1lukaHkqTbxMIQ5hO G3iXDwn0c3zjdyXNooZ5cPABBvZvga8wN1TajU4LLB1X+QAiejGirdGa9+XCZ84K 3plNKso1qqrITtT25EFc/3NHewLVOYKMMqrAFaGB1iIHSd4l+le/KBlhu2MNmM3S InTcVAIxIyuwcGopqToG8zH4D4kzpAY79xlz2BxfLN8GDRNfuipSLUbrGG7V0vS1 SKVfXOpJ6ouZB7cIzgA0UQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1727128236; x= 1727214636; bh=O9Q/eImCaEWCrXoZrzE5xrq6F5YUMncTztU3Tb7lqN8=; b=L TdAPKi9+eBrZKoZTjMK31/zAtWm9vVP0VWE3G6++eab6VAuHyYw2ylMea7CfrZqo cr5IubP4/pbRtrfrFukOnyHP3FCLKLaPW4d2DFu/M7424hj2YfpGoaceNLxuB0GM 5ci5L//lGHGBUA7D75pILD49fUoD0U43SalKQOLr8HgPCT7SyTEeaIo4OQaZzNDo mQOjvwrJ3mb2sRfnFNhLh7HluYxfeSLQLV9ArILvUXGatLQ7eXSJpt5tQzASJ8zn aoLbqEyQaO8rvCQuA8jkzLq+udRLapqjzEAAzPQRMPhBIAMhwhsdZ9VYc0TGx7f3 DHVbmt3xpHxIPJA5+SexQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddttddgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefg gfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepuddt pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsuhhrvghnsgesghhoohhglhgvrd gtohhmpdhrtghpthhtohepmhhinhgthhgrnheskhgvrhhnvghlrdhorhhgpdhrtghpthht oheplhhinhhugidqmhhmsehkvhgrtghkrdhorhhgpdhrtghpthhtoheprghkphhmsehlih hnuhigqdhfohhunhgurghtihhonhdrohhrghdprhgtphhtthhopehshhgrkhgvvghlrdgs uhhttheslhhinhhugidruggvvhdprhgtphhtthhopehlihgrmhdrhhhofihlvghtthesoh hrrggtlhgvrdgtohhmpdhrtghpthhtoheplhhorhgvnhiiohdrshhtohgrkhgvshesohhr rggtlhgvrdgtohhmpdhrtghpthhtohepvhgsrggskhgrsehsuhhsvgdrtgiipdhrtghpth htoheplhhinhhugidqrghpihesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 928C12220071; Mon, 23 Sep 2024 17:50:35 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Mon, 23 Sep 2024 21:49:43 +0000 From: "Arnd Bergmann" To: "Lorenzo Stoakes" , "Shakeel Butt" Cc: "Andrew Morton" , "Vlastimil Babka" , "Liam R. Howlett" , "Suren Baghdasaryan" , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Minchan Kim" Message-Id: <337e4359-37e0-4ed7-894d-6c88b3498a42@app.fastmail.com> In-Reply-To: References: <077be0d59cb1047870a84c87c62e7b027af1c75d.1727106751.git.lorenzo.stoakes@oracle.com> Subject: Re: [PATCH 1/2] mm/madvise: introduce PR_MADV_SELF flag to process_madvise() Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F1BFA1A0014 X-Stat-Signature: m8t88n5z5soyoeh7waufkfsrybugpxfp X-Rspam-User: X-HE-Tag: 1727128236-210619 X-HE-Meta: U2FsdGVkX1/QK/VvkQI0fyIJIKPLQdrLtUlJPTmIYZRk4Eo9EkLROWHjnJYw5LK1r5bcLR19SHiHhbDLbcuVcQOe5fpOk0NnvvPl5i68QvfFYO23QgSwbVNcPXuAklX0ksIWg2dZQU7tVdVHm/paXBtWXnbtLK1/3WD3yXLkRKa2mUB7kwdHYU9ZSH21iwD1etvFGgygeeymm6VF7BP5x0BvTH6DOtjRDJNA9DrcE23s3kxVGZgnWLM9Wx8wLxlZE8egMvY9N1y9Ai748ixcXUOj3LFgxodFj9CeLTcOubIv9uxaKbrWlmkRGmUCuBZTDLBt+tA/H5VnVs9JiUhIDR/IXCfvH0Bj7AJiHNiiRFa5neDWi134OCBlj7PRcADccMnYqJe4u/7U8MoxnANWqZ4YYCFjEeAiDAdmVZEFf9J9VY03CgCYQ1+lEOo1UXsiJOwk9Cd/1v3mhrqVX4AJ9ffRhAMYilP2pS4pR5bGewK+47eTXI/sTaazi11Ti7h3A7gtqzuVssQwlTu86P8+yths3YfG996kN7/RuvMd/FceaOVaoRm753c/fi8ng5HMv9uxZ8c7Ct914A0BeI31acxHUzOLLkdeGXt8mKOWiH5Rt6mqjoHFKheNYzoRJHmQJ+IPfJ36NDrRMtfMbHm2qAtdULm1J40KB271Iw0FuMApXFMJrTwJX7bDXa9QcG64hYAthoc+flrse1dq5hJxN8vMFJ+b/smQ+4zIDxa472gFmEx7aE24Jqycl7J3gd1msH455uMANqqW1psjgBmsev7WrdsdtD5BpzS5jjBiQLVapYeqGhTeh/oApSXf4MN7Er5g4IwffE0E7rovXX8JEMQYhfixMNJZeeWb4GOnZIImyYIoxyqZUW/L36fK1f9nEUh7nlJtvw/xYNaQdyEUHtuTolveCvkcDHmjHWO3uIODneoREnslKuQEGDbmmK5eDT8HWs/PCnAwNNBAllr DsOtaioy oSbX0OLCqkfcQq6uShwBsfl2+svtgv462h5QHiK1avhCqzviq1d+U9o+Nt74H4ujjRjxBWsyP/wjmxs9mop3m1Ogzn3Aq7LHogOxtVeWvFd6xNenzRNbxYbwShJELUJ1hn+bv97KyHTiK9NYmEX2+n7yDSM740ZIltgM1M8GRxmnEFmW6hMMqS8cZ0lsiQCAJv8c6/dVAD5q+lHlCGXzxn/3foVeYO2YuPTUxa9YaLxWWUW44kv2OxTa3jaVQRviYO3dJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 23, 2024, at 19:34, Lorenzo Stoakes wrote: > On Mon, Sep 23, 2024 at 11:56:06AM GMT, Shakeel Butt wrote: > > + /* Require PTRACE_MODE_READ to avoid leaking ASLR metadata. */ > + mm = mm_access(task, PTRACE_MODE_READ_FSCREDS); > + if (IS_ERR_OR_NULL(mm)) { > + ret = IS_ERR(mm) ? PTR_ERR(mm) : -ESRCH; > + goto release_task; > + } Any chance we can fix mm_access() to not be able to return a NULL pointer and an error pointer? IS_ERR_OR_NULL() is usually an indication of a confusing API, and this is clearly one of them, given that only one of the callers actually wants the NULL value instead of -ESRCH. Arnd