From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 972A3C17440 for ; Tue, 12 Nov 2019 23:29:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B35121872 for ; Tue, 12 Nov 2019 23:29:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="RAj1WC+w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B35121872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0151D6B0005; Tue, 12 Nov 2019 18:29:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F07636B0006; Tue, 12 Nov 2019 18:29:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1E026B0007; Tue, 12 Nov 2019 18:29:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id CC35E6B0005 for ; Tue, 12 Nov 2019 18:29:17 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 865DA180AD82F for ; Tue, 12 Nov 2019 23:29:17 +0000 (UTC) X-FDA: 76149218754.10.land90_33f42ceef0740 X-HE-Tag: land90_33f42ceef0740 X-Filterd-Recvd-Size: 4887 Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Nov 2019 23:29:16 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 12 Nov 2019 15:29:18 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 12 Nov 2019 15:29:15 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 12 Nov 2019 15:29:15 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 12 Nov 2019 23:29:14 +0000 Subject: Re: [PATCH v3 08/23] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM To: Dan Williams CC: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Christoph Hellwig , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , , Maling list - DRI developers , KVM list , , Linux Doc Mailing List , linux-fsdevel , , "Linux-media@vger.kernel.org" , linux-rdma , linuxppc-dev , Netdev , Linux MM , LKML , Aneesh Kumar K.V References: <20191112000700.3455038-1-jhubbard@nvidia.com> <20191112000700.3455038-9-jhubbard@nvidia.com> <471e513c-833f-2f8b-60db-5d9c56a8f766@nvidia.com> <729a16cb-3947-c7cb-c57f-6c917d240665@nvidia.com> From: John Hubbard X-Nvconfidentiality: public Message-ID: <337c1eae-0bc0-f10e-1d94-bfaabb458ef1@nvidia.com> Date: Tue, 12 Nov 2019 15:29:14 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1573601358; bh=o6ia2d63RJ0qxkFwgtD+YyXN5GfFC9WoewC+wxSu4kw=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=RAj1WC+waGrwzzu1rcNVg5xTDJ4YFSGOJSfwi2oimLIOQaVkk915bIrPMUaThYfIw ky/YXTMGIvWaDuZc47fvOH+PSyqmQoTrBwt0Wa509eFKFDuIhRxPrlGygvCZBlYH7F e7G7i7kI+5JBe9jpDcCLEF8nqBf+7Jp0Acs8Bh7NVnPfxELLKIp8A2qiCGfFQtoi0U 1hVsHCbQquq5G7id5r5AVCDNCbejp+r3iesGNJpN/Jlv6Xqu0/TA5bPv+XypWrU59G D1u3GlrRZEncRTYPb/7asQBi8wwD6pWmTiU8qTKzfKwu3yComaEYolsu4mdM+kKDAa r3XrSXBXN1ykw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/12/19 3:14 PM, Dan Williams wrote: ... >> >> Is that OK, or did you want to go further (possibly in a follow-up >> patchset, as I'm hoping to get this one in soon)? > > That looks ok. Something to maybe push down into the core in a future Great! I'll post a cleaned up v4 (with the extraneous up_read()/down_read() removed), then. > cleanup, but not something that needs to be done now. > Yes. I've put the FOLL_LONGTERM cleanup items on my list now, in case they don't get done as part of something else. There's a lot more change coming in this area. thanks, -- John Hubbard NVIDIA