From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DA0CC636D4 for ; Wed, 15 Feb 2023 15:56:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06B7B6B0072; Wed, 15 Feb 2023 10:56:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F36C06B0073; Wed, 15 Feb 2023 10:56:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD8216B0074; Wed, 15 Feb 2023 10:56:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CB0A56B0072 for ; Wed, 15 Feb 2023 10:56:26 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 81D89C0181 for ; Wed, 15 Feb 2023 15:56:26 +0000 (UTC) X-FDA: 80469978372.15.63F630B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 5CBA1140006 for ; Wed, 15 Feb 2023 15:56:24 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DvZUbSpg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676476584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nm0HPTn1WBz7EEySW5XokT/OmRqPcGxSZjzB2Xj17F8=; b=qTA9aQe+V+lrrR23Bjd47b5W8QMzeZK8rD8k1nmJ3+uQkivSK4Dk5IUMU5Opv6GV6ETeSm la8iGarvD1roiX2cB5aNX1VKlBR0BaAQgqvahOsQwltneGYM3n6ydAnFjglTJh8+bW0juO 8+dsxmt56qg4jsUzjzcHcwh7CgcgBD4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DvZUbSpg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676476584; a=rsa-sha256; cv=none; b=Lmwdhle8antZW8+WoeH4gR1Rm+fUkjkV+Ldf2r7vjcGJ2g+y2PrM6IUKLh+Qvu16FZrsry uXx8ejeJUOLwYq1e6QlSFyTaypsiDNOXfXBxuFZvmbRhDRgppKTfSUgTyOQsxdky3Yzo3Z /+KR2ZVr15+fqo9rppRKCYo56xaf47c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676476583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nm0HPTn1WBz7EEySW5XokT/OmRqPcGxSZjzB2Xj17F8=; b=DvZUbSpgxOMd6osP1fqhajfXtco/BkN2cztH+lv1WdQu2rGd3tO/zHE7Bl5DC9BUcKnC2d DH7OkESVWDy/UN6p4aQvzKNIX1awE3c8RhYLekh7pHSICBJ99MtSrqOQ7PWr5GuPZjkxNy pYcdWiAoWJTNhw70WAmXkqqXsOIS+eA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-365-e4UuQIm_MQKz2GqYpEKZQQ-1; Wed, 15 Feb 2023 10:56:15 -0500 X-MC-Unique: e4UuQIm_MQKz2GqYpEKZQQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B7DA68027EB; Wed, 15 Feb 2023 15:56:12 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C337492B0E; Wed, 15 Feb 2023 15:56:09 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230209102954.528942-1-dhowells@redhat.com> <20230209102954.528942-2-dhowells@redhat.com> <909202.1675959337@warthog.procyon.org.uk> <3057147.1676467076@warthog.procyon.org.uk> To: Christoph Hellwig , Jens Axboe , smfrench@gmail.com Cc: dhowells@redhat.com, Matthew Wilcox , Al Viro , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+a440341a59e3b7142895@syzkaller.appspotmail.com, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v14 01/12] splice: Fix O_DIRECT file read splice to avoid reversion of ITER_PIPE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3370609.1676476569.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 15 Feb 2023 15:56:09 +0000 Message-ID: <3370610.1676476569@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5CBA1140006 X-Stat-Signature: qyqrguof9u75rrju5re9tdtwfgidrr9w X-HE-Tag: 1676476584-303091 X-HE-Meta: U2FsdGVkX1+tOXnHlGchOCQWXFZ8NQIoBHH5BizcHa/pdhjF67WzPX5/Eo1Vz+a24Huy+HPjFEZtds4oRjEZCtwM0uIlQ+JZ5LQ7kxwB7ZE2nckS81+EN+EdsdXo0mNBXqFI7JvIIJUMXtVdMRFcMeu/lvGUlyAGDThl+eJPa8fdMHS8sW6P5PyvCOjd0MZV51M5SK7J4i0qDD3BlSGvdj/4yoKva0QPjzyLm8ys43Hwy8DIUmBOoRdKeMXR/bQ4fvmQD8V63VDjMqrXuBH8FlABKawZt2TMKa8hZfgeHX0hUbsEPx2Rfkb9fK36apS23NRLVt1nV9BKxl9bhhd/0NyXlTSPZ3GkHLNI9K/USpTwFGqn0LWmL62YEArkIwrUHrvVXXsredrafQpPv7xzBzvSY2pwlAV74HzDqkIE1ZRLv0j1Sn4mwIZgiLIHDIa4OeC1a/5B571G6ymipDe32vnIIBKX+yo3eM9xUxMu1fDNTebCatBrFVc/rM45WruYg+zQOxWaYMCFX/fmnZq41YJdvy2J6Y4fUMV5NdG3zftXYktB2zYGxYsyqoARmF8QpyhNzj7fzIpXCEI3pIx4rQQGEMY9VUq9wHWf8rshfLmKBNyMTE/i8ChW1GBTi9dNvRxIJPtjpN6rmvH/Pj6K8wEf9+b39rlYwOXx4yEWSAP1fqEcvNOy/b6lc0wWlV0wX5GudaPYZ1bmMcXK3qXHi59pYv7NHqR+gFlF19pFt8ZymBtFNrigcfZiGWlieGrIANntKTCBvMGaEUgGnarAr+ADtV3i9I8WxIqznr+98xtk0MI6RhDEw3avrfzfmhpYMFf3U1USBbny+JW4/hqvg3UmvdelDXvK8rc7oC1yrXaQ0F6qbCIjse3V7M9JoioB0jKB3+Nd5gevJlNCOWOu4yH9fyu4VjPQzO0N7x0KG/57ZJes6NrFwZMqyjEHdZkjVkwg1qqTQ6cZ2VPYhpy Q6IkgYIX LcTvMKR9DNvkTIJlufxl4FAAHKXdrHo6UcRKwMqu2Jl7JEt2RDFgzn22n4gQ6X9uKA60lM6xyXuUP+z72UQ8qVLzDD+8oHt/pAB2PIe+Gf9aUcpwzFNuMy7gkuQwWmjfNUyYDGxl+w1efdpT+faQve1eGVXr70EJDavpdEge0qR5hJSmJz6vCEWIeC83+633iWWW4kqAsSGTz+ljeiExQ7uRVCP/FPO3kQdd4DTAmiENmr+1vfaxx6Rxp0ZD+2BTlSzQYl6qDZwVa2M84EwP2HQE0QKGCm17X7S1AslTpuiNp0fKGK/sdytvwheSDQXlYz0Rn08FLkzviQqN+OZff5I0xGjSIsPdTCV6i2JuonhpJKBV2TnllWINmWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > On Wed, Feb 15, 2023 at 01:17:56PM +0000, David Howells wrote: > > Probably not, but I don't want to fiddle with that right now. I can s= end a > > follow up patch for it. > = > Honestly, I think this rush for 6.3 inclusion is a really bad idea. > > This series fundamentally changes how splice reads work, and has only > been out for about a week. It hasn't even been Cc'ed to Al Sorry, what?! Al has been To'd or cc'd on every patch. > and Linus I don't know that it's necessary to cc Linus on everything. Jens is the splice maintainer, I thought. > which generally have a good knowledge of the splice code and an opinion > on it. > = > I think it is a good change, but I'd feel much more comfortable with > it for the next merge window rather than rushing it. The lack of iov_iter_extract_pages() is blocking other things I want to wo= rk on - and will push those out another 3 months further beyond this. I'm fine with dropping the block layer changes and most of the splice chan= ges, but I do want to try to get patches 1-3, 10 and 11: mm: Pass info, not iter, into filemap_get_pages() splice: Add a func to do a splice from a buffered file without ITER_PIPE splice: Add a func to do a splice from an O_DIRECT file without ITER_PIPE iov_iter: Add a function to extract a page list from an iterator iov_iter: Define flags to qualify page extraction. upstream through the cifs tree if you, Jens and Steve French have no objection, with my cifs iteratorisation patches on top. It shouldn't affe= ct anything other than cifs in this merge window, barring the change to the f= lags to iov_iter_get_pages*(). David