From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA71C636D4 for ; Wed, 15 Feb 2023 15:43:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B23506B0081; Wed, 15 Feb 2023 10:43:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD38E6B0082; Wed, 15 Feb 2023 10:43:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C2836B0083; Wed, 15 Feb 2023 10:43:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8C9996B0081 for ; Wed, 15 Feb 2023 10:43:14 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F1015140C2C for ; Wed, 15 Feb 2023 15:43:13 +0000 (UTC) X-FDA: 80469945066.05.73D7B6E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 130FF1C0019 for ; Wed, 15 Feb 2023 15:43:11 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R2+RBtSM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676475792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PMqJa7q0H8qVEbf7pymm/2XGZiQOArn54qlyx+FXazM=; b=AyJ4mJ2tl0T6FWkmp2rNVFVECHZvMs4E5KOi2cKKpY6Pnnetv6tqWbxROLQ772Zct7t73l gV5ZgkOTFvnK8JpJjR5/iMab+iwpfnwfUMccsmp/84BKng/r0aufwjFYIpTPEUQI3Q3jCR 7MvztZMNtzhe20ZLiJCNEuQIXe1+YeU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R2+RBtSM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676475792; a=rsa-sha256; cv=none; b=7fHHQT7I+VB8Wd8+CReF5X5guorVPLxrDGWfHv+tWv5q6gx7G4SaAKRjfCP+Z6/N00qRoc Q9LWL2V74i+xgXpW5k083SYJ6DqOEgiS2zXF4MWxShvHEOuQlODdXucx4ob0UWxY8/IZkt fJTEDpvbflJR/tk9zROTNB5OdPOnXq0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676475791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PMqJa7q0H8qVEbf7pymm/2XGZiQOArn54qlyx+FXazM=; b=R2+RBtSMEUmGD7jrdmXRZEKSeFATB0/+oYU4+44zOuvrQYZBUhP4NR0mWIsUtN6mlvbOpx AasfeNVi5WT5Ne6MXCsD8zQ38W2TuI9bSeIdf6EMjPwTtonKxJUgE1lLRFaBLadfuaz3/x Sp7nL+d9XMUTvvOG/g0S0vVj9HKAOAE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-147-AWjaTIU5MtiuWFLkfmFwMA-1; Wed, 15 Feb 2023 10:43:08 -0500 X-MC-Unique: AWjaTIU5MtiuWFLkfmFwMA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 81797100F911; Wed, 15 Feb 2023 15:43:06 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 486ED40CF8EA; Wed, 15 Feb 2023 15:43:04 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <867e1e3e-681b-843b-1704-effed736e13d@kernel.dk> <20230214171330.2722188-1-dhowells@redhat.com> <2877092.1676415412@warthog.procyon.org.uk> <2895995.1676448478@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Jens Axboe , smfrench@gmail.com, Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v14 00/17] iov_iter: Improve page extraction (pin or just list) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3370185.1676475783.1@warthog.procyon.org.uk> Date: Wed, 15 Feb 2023 15:43:03 +0000 Message-ID: <3370186.1676475783@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 130FF1C0019 X-Stat-Signature: m736z3eikofa3d4rn1ytiemfsirwadp5 X-HE-Tag: 1676475791-928141 X-HE-Meta: U2FsdGVkX1/DoWksxEFqdl4Fy2RwP8EP8YlghzilyNrW9DVSupHUD2gFVjUmenvbwZbzLHm4jmAYbOzSvqbf5mN3aSoGzLkDTd8eec/ncEf+GA2YMSJjxsRjgJiVPBVFK7BxhVbIaY9VvWLPeR/GES7ns6qk7proXY4UJShnpu6j3zWbwJNe3whUGCj2OWOV75tOOJhEwXgoyQWJf5sptbHLU93LxLnOv5q1yoEtWBoyDcUtPNUjEL0C9UsRNHLZbHSUqVB0NMhG8DMZlTiUU5dBYbg345DKd/kpNxj6E/InaAUfOh7tBvr70NaB/OSSlU+nDCl5TlQcN2KH0J5ML3TYFbVcrszLeTxPLRLX6zfMxS3lhu4aW0g4U23yDYeEW8ZLqYivYdU0d9ASSXQa+wOjg+Zn0v8ayX2P/xrPKWwpNO+ocah4E8hX1nmQqkgayHWePv+zwTqUcqoSDBQLKvruJbDRzf71KZEP8oLVEveaneZLsOgfwYadY76G6sB8JNti9ljSJfjKsZlw7Zv6DG7z9zbIcg8rqZ+L5weSighFu8v7M1tSVDx/A2RwKDgQ1mN36lNF+vtRYL+PtLZX+wnZeiYr2+4C5hbGFoAJ0uaSULmHHiiyS6IkzMXvbDtS/ynWahskIYd1JSiKnQ+z1zXAr5POLYyZxku3Ij2UCMLgsYET7+jpsl7WhejrjoQWz9oBLJWDBsOLYJCqNvTf64h7XobXyVVMNXBSXOjdPWTuIvD9CQ3ow0mxFwn+TlTmOc/jVaMF3jTT/+AGrozLAN2v5R6MBUP9BdCb0Ead1VMec3NZbpVwCQOnXS+zm9K7ARCUPP04nRXB24JqZ9I2ZHRSH8YIxJPysCsnNoZR1Kbpgd45WLYVgX2Gc/x3VtB+D/c3qbsbvaiK0WVNzDLClNBdYylNme0HyL8JSKS8YYktpChwM2OpEl9gVbliUpk6K0MG4hnvhjFfNWnzK00 Gt5cr3Yt hZjAu39CoMbyfuvprwS/81xIjsl27RZTgLewosF1z1WpSlRg3StFDYKHF0Fz1R7DhEDC443aPXH2oceWi7jXoLmV6hTIzsQdjqFWghfnGkEgMFqAcCSrVPsk08R6Yo3SJHvKpgvFRwPsTPkJHR3jBgNgQxNgsWvHazY39D8MR01uTmmHJLNn1QCMfX37EUR5tpSTO5Fvo+6RZqngRvpcG3gsMeBC7VpJpVW3XpryaHuFfmirKY8re2xeHmvgxtuUgD9RcTAdkNeIFSJI6i//f96+5Fg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > And who is using filemap_splice_read directly anyway? I can't find a > modular user in any of the branches. Fair point. I have a subset of the patches on my iov-cifs branch that doesn't make the change to generic_file_read_splice(), but rather does that bit in cifs.ko - that does require access to filemap_splice_read(). David