From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD74C4706C for ; Fri, 12 Jan 2024 20:37:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 232D76B0087; Fri, 12 Jan 2024 15:37:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E3566B00A0; Fri, 12 Jan 2024 15:37:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05D2E6B00A2; Fri, 12 Jan 2024 15:37:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E71D76B00A0 for ; Fri, 12 Jan 2024 15:37:39 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B8F5CA2442 for ; Fri, 12 Jan 2024 20:37:39 +0000 (UTC) X-FDA: 81671819838.02.5DEF26D Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by imf15.hostedemail.com (Postfix) with ESMTP id 5B421A0022 for ; Fri, 12 Jan 2024 20:37:36 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ktCtlvtX; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705091857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IseLdp4Np9hrJtpLIZ43kYB+VSHf4VkwieodfflwR9M=; b=76W+DpLRnic+A8w4I9Gea4GEMpGX9g9GPH3M3i7a/E5jzB2EynTsGnhecjUfS94nCPXJC6 Y94L2iGZLFN9M7ipa++6u89xLu+P/N8vi3yb5SUCdhid7mHKssYzkakVCMSoMwwY49w7gJ 7ZQwU3uYRusj2/vbIRQjHnAiNUbIqJs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ktCtlvtX; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705091857; a=rsa-sha256; cv=none; b=n2xEt1DNm0cCyf/AwP7MsCz0DvKv/ZJm9Sp4hWkjddjpX5yCEVlBUqDlwdIX/SkYNlCac7 ArTPDjnXxAcGHBTt462iAn42Hrad6rJEmEA9lDy797Np0ojQqG5leusf0f069haGijtAyM bTXksgkodnaJvr2JCVFemir/dQS1qLY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705091856; x=1736627856; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=7Ghu41Z2IsEQ66CSni8Rd5fHmhbvJ8BiP5Up0k2SILE=; b=ktCtlvtXjf6XdGVX6+3Jzc1RTzuZ2CJIrewGtkjGChZeY33soKc0uWnO XPkXqgg1Wje3mRSIai4QCdPEkv2sAD1Dgn2nTspgxv/N9bN0hY9KP0hFl p9VLxkP1ri1i8tG4N65PQoqgh317wGTvt/p/ego4gKQ5qH+sVQAutP3bd HCMRnoaSl79APZjxsXsk9zyrr1w49UsSHXc7+l3pdItfamf2nZVansnLp LtCFRvSbj9DZQcFvG/C81kYuBoxvFo8egDkmXrWjaeOZT4o6QBiCZS+Kx ghRuGBkc61hYLldS6SNSu6GzagKIJcidZqwxg08h1ngNATt4b0sCIbTL6 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10951"; a="398959166" X-IronPort-AV: E=Sophos;i="6.04,190,1695711600"; d="scan'208";a="398959166" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2024 12:37:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10951"; a="853392188" X-IronPort-AV: E=Sophos;i="6.04,190,1695711600"; d="scan'208";a="853392188" Received: from yrayx-mobl.amr.corp.intel.com (HELO [10.209.50.27]) ([10.209.50.27]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2024 12:37:32 -0800 Message-ID: <336b55f9-c7e6-4ec9-806b-cb3659dbfdc3@intel.com> Date: Fri, 12 Jan 2024 12:37:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 11/26] x86/sev: Invalidate pages from the direct map when adding them to the RMP table Content-Language: en-US To: Tom Lendacky , Borislav Petkov Cc: Michael Roth , x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-12-michael.roth@amd.com> <20240112200751.GHZaGcF0-OZVJiIB7y@fat_crate.local> <63297d29-bb24-ac5e-0b47-35e22bb1a2f8@amd.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <63297d29-bb24-ac5e-0b47-35e22bb1a2f8@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5B421A0022 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 34s1p4bnmqo6ga9s83mmxnzts89gmttk X-HE-Tag: 1705091856-127183 X-HE-Meta: U2FsdGVkX18J0O/jQywqF+NuWQsxKVQhv3mX1BfXTnvdD4eO+tm5vHZG62glyuvQyJUhPR0+xt2504DBuJbPRTxRSmjYWoeAkUzAjVSDazoe7VFlZQJsYRhdUWiqIOabN+LQqLdFMa1DK0yEk03+cjUoTjlG7M8g4IBo7CrzsN6cppD+G3k81EVinatbWPbPmQ79aIOeUqr0yDI7KpGNAsiizROB09uxlNjLxJOH3S+pJl08EtfeTRUgtJ0kaP9eCLxBff8OzIyWkpU+S8cFaWu34sIDcEYJhDQZXHiicE8UkXSdgQgk/kHsBeei+3EMzLP5GkiUA7PvWBFIsEzGHx7QncG0TCMlGzXsMV4dwQRlfjs7ErrW9R9/s7r9IPFx7uG2KKwGejiwwrFozLh2lqCJRHyGDH3Snfc9xcisJTh3w308BdiIecYO/iTsj0kBoI/IOOdT0gvEkuwyGh+ETXHswJ8djith4osTQtYr7tfZbzoqUiq6gr1mOGUt3CTzR9Yft/t2i2iXkY14ZB+8r9w1e0A3xbQgJZwtoO8jcIq4zNNYHUOk722yrlSRAVAJFtFgZWa9DXMcY7tLq2+rpKBA5TbJn0Wuh9daupomoij8zJF9P4Tcd3lvJDScb3GKC015j7/+A2YIgP/Jxqgdz6UvOXeYlqqKsq/osAfCgMkj+Z/r6uyEEn3lYeukDWN+SLHzg+/Y9izBdCqj5+t41ouS1KqykLeMRigYpCgGEbt8qo3FTSgJGhgQjn+H3XGMOia/cf1T2Me1S2bhCDrs9hgiYTXW31aG8D/zZdyDGCsgD70OZ7OECDVH4Gn8QYpjvwHgaFDX8czFjYlbEFdnJKPEo2rC5DaDMg9FNyoDsnlpWBnM+XKQAluyiGCPdY8I+rEJkWe/bZ/F8wMGcoiolRdfRsA5w048tKjcA1gSw6OQMmODctUsAgTeFc0M4jfrFYAcjwohFevUfdKDiSu xpjl1fQC qoZ2Sc8MandRWfG4Pb98JVR2i9tu+Dvx4lNVU/itP+0ePi0bpVAKWiuXuOXZhEH7hufPYGlpag06AP6JYAndFaGLNsB618MUT+24tF75zul5NgYzv0QpBcTnwwFu4Vv8yRBxXbP8OZA2OA+dAjB+mP920XZgAmr9s2OKuDeaAPP6X+cLcZBLzhVSFYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/12/24 12:28, Tom Lendacky wrote: > I thought there was also a desire to remove the direct map for any pages > assigned to a guest as private, not just the case that the comment says. > So updating the comment would probably the best action. I'm not sure who desires that. It's sloooooooow to remove things from the direct map. There's almost certainly a frequency cutoff where running the whole direct mapping as 4k is better than the cost of mapping/unmapping. Actually, where _is_ the TLB flushing here?